make test: improve handling of packet captures

Perform accounting of expected packets based on created packet infos.
Use this accounting info to automatically expect (and verify) the
correct number of packets to be captured. Automatically retry the read
of the capture file if scapy raises an exception while doing so to
handle rare cases when capture file is read while only partially
written during busy wait. Don't fail assert_nothing_captured if only
junk packets arrived.

Change-Id: I16ec2e9410ef510d313ec16b7e13c57d0b2a63f5
Signed-off-by: Klement Sekera <ksekera@cisco.com>

1 files changed, 7 insertions, 10 deletions

diff --git a/test/util.py b/test/util.py
index 0ac23760..6658febf 100644
--- a/test/util.py
+++ b/test/util.py
@@ -24,17 +24,14 @@ def ppc(headline, capture, limit=10):
     """
     if not capture:
         return headline
-    result = headline + "\n"
-    count = 1
-    for p in capture:
-        result.append(ppp("Packet #%s:" % count, p))
-        count += 1
-        if count >= limit:
-            break
+    tail = ""
     if limit < len(capture):
-        result.append(
-            "Capture contains %s packets in total, of which %s were printed" %
-            (len(capture), limit))
+        tail = "\nPrint limit reached, %s out of %s packets printed" % (
+            len(capture), limit)
+        limit = len(capture)
+    body = "".join([ppp("Packet #%s:" % count, p)
+                    for count, p in zip(range(0, limit), capture)])
+    return "%s\n%s%s" % (headline, body, tail)
 
 
 class NumericConstant(object):