aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVratko Polak <vrpolak@cisco.com>2024-05-20 17:01:11 +0200
committerVratko Polak <vrpolak@cisco.com>2024-05-20 17:01:11 +0200
commit55bdf4cc0046617100676685d1f5ef075167af1d (patch)
treeffefa62b316881619047bba77ebf5e5e54d8ac86
parentc5d1ec293164a5aad9b04a7df749b85c2ef01582 (diff)
fix(perf): Increase threshold for jumbo
The old limit of 1522 was introduced long time ago. First, it appeared here [0], where it is correct as that suite has zero overhead. The first suite with wrong logic seems to be here [1] (no "Add No Multi Seg to all DUTs" in 1518B testcase). And when I was moving that logic to a keyword in [2], I did not realize it is wrong with overhead. This Change uses 1800 as the new threshold, matching the value used for non-jumbo MTU. [0] https://gerrit.fd.io/r/c/csit/+/2652/12/tests/perf/Bridge_Domain_Intel-X520-DA2.robot#70 [1] https://gerrit.fd.io/r/c/csit/+/4454/96/tests/perf/40ge2p1xl710-ethip4ipsecscaleip4-ip4base-interfaces-aes-gcm-ndrpdrdisc.robot#229 [2] https://gerrit.fd.io/r/c/csit/+/13411/35/resources/libraries/robot/performance/performance_utils.robot#84 Change-Id: Iff3703fcff0e4bbb1a6b10be359fa5ef67fd5422 Signed-off-by: Vratko Polak <vrpolak@cisco.com>
-rw-r--r--resources/libraries/robot/performance/performance_vars.robot4
1 files changed, 2 insertions, 2 deletions
diff --git a/resources/libraries/robot/performance/performance_vars.robot b/resources/libraries/robot/performance/performance_vars.robot
index a0fa277e4c..1bab1071b7 100644
--- a/resources/libraries/robot/performance/performance_vars.robot
+++ b/resources/libraries/robot/performance/performance_vars.robot
@@ -1,4 +1,4 @@
-# Copyright (c) 2023 Cisco and/or its affiliates.
+# Copyright (c) 2024 Cisco and/or its affiliates.
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at:
@@ -413,7 +413,7 @@
| |
| | # Some suites (e.g. device) are not calling Set Max Rate And Jumbo.
| | Set Numeric Frame Sizes
-| | ${jumbo} = | Evaluate | ${max_frame_size} >= 1522
+| | ${jumbo} = | Evaluate | ${max_frame_size} >= 1800
| | Set Test Variable | \${jumbo}
| | ${recommended_mtu} = | Set Variable If | ${jumbo} | ${9200} | ${1800}
| | Set Test Variable | \${recommended_mtu}