Suite: lisp.

Files: lisp_api_untagged.robot, lisp_dataplane_untagged.robot.
Updated test cases names and test cases documentation.

Change-Id: I5381a800d3fc27694892c70e8538b9312940588f
Signed-off-by: Maciek Konstantynowicz <mkonstan@cisco.com>

Conflicts:
	tests/suites/lisp/lisp_api_untagged.robot
	tests/suites/lisp/lisp_dataplane_untagged.robot

Change-Id: I5381a800d3fc27694892c70e8538b9312940588f
Signed-off-by: Jan Gelety <jgelety@cisco.com>

2 files changed, 105 insertions, 58 deletions

diff --git a/tests/suites/lisp/lisp_api_untagged.robot b/tests/suites/lisp/lisp_api_untagged.robot
index 8769b17e18..83c5853ed9 100644
--- a/tests/suites/lisp/lisp_api_untagged.robot
+++ b/tests/suites/lisp/lisp_api_untagged.robot
@@ -12,7 +12,6 @@
 # limitations under the License.
 
 *** Settings ***
-| Documentation | LISP API test.
 | Library | resources.libraries.python.topology.Topology
 | Library | resources.libraries.python.NodePath
 | Library | resources.libraries.python.Trace
@@ -28,30 +27,39 @@
 | ...        | AND          | Setup all TGs before traffic script
 | ...        | AND          | Update All Interface Data On All Nodes | ${nodes}
 | Test Teardown | Show Packet Trace on All DUTs | ${nodes}
+| Documentation | *LISP API test cases*
+| ...
+| ... | *[Top] Network Topologies:* DUT1 1-node topology.
+| ... | *[Enc] Packet Encapsulations:* None.
+| ... | *[Cfg] DUT configuration:* DUT1 gets configured with all LISP
+| ... | parameters.
+| ... | *[Ver] Verification:* DUT1 operational data gets verified following
+| ... | configuration.
+| ... | *[Ref] Applicable standard specifications:* RFC6830.
 
 *** Variables ***
 | ${locator_set_num}= | 3
 
 *** Test Cases ***
 
-Vpp can enable and disable Lisp
-| | [Documentation] | Test lisp enable/disable API.
-| | ...             | Enable lisp on the VPP node,
-| | ...             | check if the lisp on the vpp node is enabled.
-| | ...             | Then disable lisp on the vpp node and check if
-| | ...             | the lisp is disabled on the vpp node.
+| TC01: DUT can enable and disable LISP
+| | [Documentation]
+| | ... | [Top] DUT1. [Enc] None. [Cfg1] Test LISP enable/disable API; On \
+| | ... | DUT1 enable LISP. [Ver1] Check DUT1 if LISP is enabled. [Cfg2]
+| | ... | Then disable LISP. [Ver2] Check DUT1 if LISP is disabled. [Ref]
+| | ... | RFC6830.
 | | When Enable lisp | ${nodes['DUT1']}
 | | Then Check if lisp is enabled | ${nodes['DUT1']} | ${lisp_status}
 | | When Disable lisp | ${nodes['DUT1']}
 | | Then Check if lisp is disabled | ${nodes['DUT1']} | ${lisp_status}
 
-| VPP can add and delete locator_set
-| | [Documentation] | Test lisp locator_set API
-| | ...             | Set locator_set and locator on the VPP node,
-| | ...             | check the configured data and then remove it.
-| | ...             | Check if all locator_set and locators was unset
-| | ...             | from the VPP node.
-| | ...
+| TC02: DUT can add and delete locator_set
+| | [Documentation]
+| | ... | [Top] DUT1. [Enc] None. [Cfg1] Test LISP locator_set API; on \
+| | ... | DUT1 configure locator_set and locator. [Ver1] Check DUT1
+| | ... | configured locator_set and locator are correct. [Cfg2] Then
+| | ... | remove locator_set and locator. [Ver2] check DUT1 locator_set
+| | ... | and locator are removed. [Ref] RFC6830.
 | | Given Lisp locator_set data is prepared
 | | ... | ${nodes['DUT1']} | ${locator_set_num}
 | | And   Enable lisp | ${nodes['DUT1']}
@@ -60,14 +68,15 @@ Vpp can enable and disable Lisp
 | | When Delete all lisp locator_set from VPP | ${nodes['DUT1']}
 | | Then Lisp locator_set should be unset | ${nodes['DUT1']}
 
-| VPP can add, reset and delete locator_set
-| | [Documentation] | Test lisp locator_set API
-| | ...             | Set locator_set and locator on the VPP node,
-| | ...             | then reset locator_set and set it again.
-| | ...             | Check the configured data and then remove it.
-| | ...             | Check if all locator_set and locators was unset
-| | ...             | from the VPP node.
-| | ...
+| TC03: DUT can add, reset and delete locator_set
+| | [Documentation]
+| | ... | [Top] DUT1. [Enc] None. [Cfg1] Test LISP locator_set API; on \
+| | ... | DUT1 configure locator_set and locator. [Ver1] Check DUT1
+| | ... | locator_set and locator are correct. [Cfg2] Then reset
+| | ... | locator_set and set it again. [Ver2] Check DUT1 locator_set and
+| | ... | locator are correct. [Cfg3] Then remove locator_set and locator.
+| | ... | [Ver3] Check DUT1 all locator_set and locators are removed.
+| | ... | [Ref] RFC6830.
 | | Given Lisp locator_set data use for test reset locator_set are prepared
 | | ... | ${nodes['DUT1']} | ${locator_set_num}
 | | And   Enable lisp | ${nodes['DUT1']}
@@ -76,13 +85,12 @@ Vpp can enable and disable Lisp
 | | When Delete all lisp locator_set from VPP | ${nodes['DUT1']}
 | | Then Lisp locator_set should be unset | ${nodes['DUT1']}
 
-| Vpp can add and delete eid address
-| | [Documentation] | Test lisp eid API
-| | ...             | Set lisp eid IP address on the VPP node,
-| | ...             | check the configured data and then remove it.
-| | ...             | Check if all eid IP address was unset
-| | ...             | from the VPP node.
-| | ...
+| TC04: DUT can add and delete eid address
+| | [Documentation]
+| | ... | [Top] DUT1. [Enc] None. [Cfg1] Test LISP eid API; on DUT1 \
+| | ... | configure LISP eid IP address. [Ver1] Check DUT1 configured data
+| | ... | is correct. [Cfg2] Remove configured data. [Ver2] Check DUT1 all
+| | ... | eid IP addresses are removed. [Ref] RFC6830.
 | | Given Enable lisp | ${nodes['DUT1']}
 | | When Lisp eid address is set | ${nodes['DUT1']} | ${eid_table}
 | | Then Lisp eid address is set correctly to eid table | ${nodes['DUT1']}
@@ -90,13 +98,13 @@ Vpp can enable and disable Lisp
 | | When Delete all lisp eid address from VPP | ${nodes['DUT1']} | ${eid_table}
 | | Then Lisp eid table should be empty | ${nodes['DUT1']}
 
-| Vpp can add and delete lisp map resolver address
-| | [Documentation] | Test lisp map resolver address API
-| | ...             | Set lisp map resolver address on the VPP node,
-| | ...             | check the configured data and then remove it.
-| | ...             | Check if all map resolver address was unset
-| | ...             | from the VPP node.
-| | ...
+| TC05: DUT can add and delete LISP map resolver address
+| | [Documentation]
+| | ... | [Top] DUT1. [Enc] None. [Cfg1] Test LISP map resolver address \
+| | ... | API; on DUT1 configure LISP map resolver address. [Ver1] Check
+| | ... | DUT1 configured data is correct. [Cfg2] Remove configured data.
+| | ... | [Ver2] Check DUT1 all map resolver addresses are removed. [Ref]
+| | ... | RFC6830.
 | | Given Enable lisp | ${nodes['DUT1']}
 | | When Lisp map resolver address is set | ${nodes['DUT1']} | ${map_resolver}
 | | Then Lisp map resolver address is set correctly | ${nodes['DUT1']}
diff --git a/tests/suites/lisp/lisp_dataplane_untagged.robot b/tests/suites/lisp/lisp_dataplane_untagged.robot
index 7e952250d5..9cb60cba53 100644
--- a/tests/suites/lisp/lisp_dataplane_untagged.robot
+++ b/tests/suites/lisp/lisp_dataplane_untagged.robot
@@ -12,7 +12,6 @@
 # limitations under the License.
 
 *** Settings ***
-| Documentation | Test Lisp static remote mapping topology.
 | Resource | resources/libraries/robot/default.robot
 | Resource | resources/libraries/robot/testing_path.robot
 | Resource | resources/libraries/robot/ipv4.robot
@@ -30,12 +29,35 @@
 | ...        | AND          | Setup all TGs before traffic script
 | ...        | AND          | Update All Interface Data On All Nodes | ${nodes}
 | Test Teardown | Show Packet Trace on All DUTs | ${nodes}
+| Documentation | *LISP static remote mapping test cases*
+| ...
+| ... | *[Top] Network Topologies:* TG-DUT1-DUT2-TG 3-node circular topology
+| ... | with single links between nodes.
+| ... | *[Enc] Packet Encapsulations:* Eth-IPv4-LISP-IPv4-ICMPv4 on DUT1-DUT2,
+| ... | Eth-IPv4-ICMPv4 on TG-DUTn for IPv4 routing over LISPoIPv4 tunnel;
+| ... | Eth-IPv6-LISP-IPv6-ICMPv6 on DUT1-DUT2, Eth-IPv6-ICMPv6 on TG-DUTn for
+| ... | IPv6 routing over LISPoIPv6 tunnel; Eth-IPv6-LISP-IPv4-ICMPv4 on
+| ... | DUT1-DUT2, Eth-IPv4-ICMPv4 on TG-DUTn for IPv4 routing over LISPoIPv6
+| ... | tunnel; Eth-IPv4-LISP-IPv6-ICMPv6 on DUT1-DUT2, Eth-IPv6-ICMPv6 on
+| ... | TG-DUTn for IPv6 routing over LISPoIPv4 tunnel.
+| ... | *[Cfg] DUT configuration:* DUT1 and DUT2 are configured with IPv4 (IPv6)
+| ... | routing and static routes. LISPoIPv4 (oIPv6) tunnel is configured
+| ... | between DUT1 and DUT2.
+| ... | *[Ver] TG verification:* Test ICMPv4 (or ICMPv6) Echo Request packets
+| ... | are sent in both directions by TG on links to DUT1 and DUT2; on receive
+| ... | TG verifies packets for correctness and their IPv4 (IPv6) src-addr,
+| ... | dst-addr and MAC addresses.
+| ... | *[Ref] Applicable standard specifications:* RFC6830.
 
 *** Test Cases ***
-| VPP can pass IPv4 bidirectionally through LISP
-| | [Documentation] | Test IP4 Lisp remote static mapping.
-| | ...             | Set IP4 lisp topology and check if packet passes through
-| | ...             | Lisp topology.
+| TC01: DUT1 and DUT2 route IPv4 bidirectionally over LISPoIPv4 tunnel
+| | [Documentation]
+| | ... | [Top] TG-DUT1-DUT2-TG. [Enc] Eth-IPv4-LISP-IPv4-ICMPv4 on \
+| | ... | DUT1-DUT2, Eth-IPv4-ICMPv4 on TG-DUTn. [Cfg] On DUT1 and DUT2
+| | ... | configure IPv4 LISP remote static mappings. [Ver] Make TG send
+| | ... | ICMPv4 Echo Req between its interfaces across both DUTs and LISP
+| | ... | tunnel between them; verify IPv4 headers on received packets are
+| | ... | correct. [Ref] RFC6830.
 | | Given Path for 3-node testing is set
 | | ... | ${nodes['TG']} | ${nodes['DUT1']} | ${nodes['DUT2']} | ${nodes['TG']}
 | | And   Interfaces in 3-node path are up
@@ -68,10 +90,14 @@
 | |      ... | ${tg_to_dut2} | ${tg_to_dut2_mac} | ${dut2_to_tg_mac}
 | |      ... | ${tg_to_dut1} | ${dut1_to_tg_mac} | ${tg_to_dut1_mac}
 
-| VPP can pass IPv6 bidirectionally through LISP
-| | [Documentation] | Test IP6 Lisp remote static mapping.
-| | ...             | Set IP6 lisp topology and check if packet passes through
-| | ...             | Lisp topology.
+| TC02: DUT1 and DUT2 route IPv6 bidirectionally over LISPoIPv6 tunnel
+| | [Documentation]
+| | ... | [Top] TG-DUT1-DUT2-TG. [Enc] Eth-IPv6-LISP-IPv6-ICMPv6 on \
+| | ... | DUT1-DUT2, Eth-IPv6-ICMPv6 on TG-DUTn. [Cfg] On DUT1 and DUT2
+| | ... | configure IPv6 LISP remote static mappings. [Ver] Make TG send
+| | ... | ICMPv6 Echo Req between its interfaces across both DUTs and LISP
+| | ... | tunnel between them; verify IPv4 headers on received packets are
+| | ... | correct. [Ref] RFC6830.
 | | Given Path for 3-node testing is set
 | | ... | ${nodes['TG']} | ${nodes['DUT1']} | ${nodes['DUT2']} | ${nodes['TG']}
 | | And   Interfaces in 3-node path are up
@@ -104,10 +130,14 @@
 | |      ... | ${tg_to_dut2} | ${tg_to_dut2_mac} | ${dut2_to_tg_mac}
 | |      ... | ${tg_to_dut1} | ${dut1_to_tg_mac} | ${tg_to_dut1_mac}
 
-| VPP can pass IPv4 over IPv6 bidirectionally through LISP
-| | [Documentation] | Test IP4 over IP6 in Lisp remote static mapping.
-| | ...             | Set IP6 topology and check if the IP4 packet
-| | ...             | passes through IP6 Lisp topology.
+| TC03: DUT1 and DUT2 route IPv4 bidirectionally over LISPoIPv6 tunnel
+| | [Documentation]
+| | ... | [Top] TG-DUT1-DUT2-TG. [Enc] Eth-IPv6-LISP-IPv4-ICMPv4 on \
+| | ... | DUT1-DUT2, Eth-IPv4-ICMPv4 on TG-DUTn. [Cfg] On DUT1 and DUT2
+| | ... | configure IPv6 LISP remote static mappings. [Ver] Make TG send
+| | ... | ICMPv4 Echo Req between its interfaces across both DUTs and LISP
+| | ... | tunnel between them; verify IPv4 headers on received packets are
+| | ... | correct. [Ref] RFC6830.
 | | Given Path for 3-node testing is set
 | | ... | ${nodes['TG']} | ${nodes['DUT1']} | ${nodes['DUT2']} | ${nodes['TG']}
 | | And   Interfaces in 3-node path are up
@@ -140,10 +170,14 @@
 | |      ... | ${tg_to_dut2} | ${tg_to_dut2_mac} | ${dut2_to_tg_mac}
 | |      ... | ${tg_to_dut1} | ${dut1_to_tg_mac} | ${tg_to_dut1_mac}
 
-| VPP can pass IPv6 over IPv4 bidirectionally through LISP
-| | [Documentation] | Test IP6 over IP4 in Lisp remote static mapping.
-| | ...             | Set IP4 topology and check if the IP6 packet
-| | ...             | passes through IP4 Lisp topology.
+| TC04: DUT1 and DUT2 route IPv6 bidirectionally over LISPoIPv4 tunnel
+| | [Documentation]
+| | ... | [Top] TG-DUT1-DUT2-TG. [Enc] Eth-IPv4-LISP-IPv6-ICMPv6 on \
+| | ... | DUT1-DUT2, Eth-IPv6-ICMPv6 on TG-DUTn. [Cfg] On DUT1 and DUT2
+| | ... | configure IPv4 LISP remote static mappings. [Ver] Make TG send
+| | ... | ICMPv6 Echo Req between its interfaces across both DUTs and LISP
+| | ... | tunnel between them; verify IPv4 headers on received packets are
+| | ... | correct. [Ref] RFC6830.
 | | Given Path for 3-node testing is set
 | | ... | ${nodes['TG']} | ${nodes['DUT1']} | ${nodes['DUT2']} | ${nodes['TG']}
 | | And   Interfaces in 3-node path are up
@@ -176,11 +210,16 @@
 | |      ... | ${tg_to_dut2} | ${tg_to_dut2_mac} | ${dut2_to_tg_mac}
 | |      ... | ${tg_to_dut1} | ${dut1_to_tg_mac} | ${tg_to_dut1_mac}
 
-| VPP can disable lisp and then re-enable it and everything should work
-| | [Documentation] | Test disable and enable Lisp.
-| | ...             | Set Lisp and check if lisp work. Then disable Lisp
-| | ...             | and check if it is disabled. At the end re-enable lisp
-| | ...             | and check if Lisp is working.
+| TC05: DUT1 and DUT2 route IPv4 over LISPoIPv4 tunnel after disable-enable
+| | [Documentation]
+| | ... | [Top] TG-DUT1-DUT2-TG. [Enc] Eth-IPv4-LISP-IPv4-ICMPv4 on \
+| | ... | DUT1-DUT2, Eth-IPv4-ICMPv4 on TG-DUTn. [Cfg1] On DUT1 and DUT2
+| | ... | configure IPv4 LISP remote static mappings. [Ver1] Make TG send
+| | ... | ICMPv4 Echo Req between its interfaces across both DUTs and LISP
+| | ... | tunnel between them; verify IPv4 headers on received packets are
+| | ... | correct. [Cfg2] Disable LISP. [Ver2] verify packets are not
+| | ... | received via LISP tunnel. [Cfg3] Re-enable LISP. [Ver3] verify
+| | ... | packets are received again via LISP tunnel. [Ref] RFC6830.
 | | Given Path for 3-node testing is set
 | | ... | ${nodes['TG']} | ${nodes['DUT1']} | ${nodes['DUT2']} | ${nodes['TG']}
 | | And   Interfaces in 3-node path are up