Update RCA files with new findings

Change-Id: I0db4d513cdc84c6f8c1e2dffa46cd41e13df5b21
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit fa87e0689e8712833478c9f921c1477af21aa575)

4 files changed, 37 insertions, 28 deletions

diff --git a/resources/tools/presentation/rca/rca-2n-clx-2t1c-pdr-rca1.yaml b/resources/tools/presentation/rca/rca-2n-clx-2t1c-pdr-rca1.yaml
index 136c23f88d..1c52a778df 100644
--- a/resources/tools/presentation/rca/rca-2n-clx-2t1c-pdr-rca1.yaml
+++ b/resources/tools/presentation/rca/rca-2n-clx-2t1c-pdr-rca1.yaml
@@ -22,8 +22,7 @@
 # see https://yaml-multiline.info/
 
 footnote: "
-
-    [1] DONE Regression in ACL tests due to Gerrit 26112. With CSIT
+    [1] DONE Apparent regression in ACL tests due to Gerrit 26112. With CSIT
     using changed VPP API, instead of failing, misconfigured VPP passes
     the test, albeit with reduced performance. [CSIT-1739]
 
@@ -48,18 +47,20 @@ footnote: "
     [10] OPEN Progression in ip6 base tests with dot1q. [CSIT-1746]
 
     [11] OPEN Progression in memif tests, mainly in
-    avf-eth-l2xcbase-eth-2memif-1dcr. [CSIT-1744]
+    avf-eth-l2xcbase-eth-2memif-1dcr. Two progression candidates found:
+    Gerrit 24053 and Gerrit 26744. Performance results are not consistent enough
+    to separate the two from other possible causes. [CSIT-1744]
 
     [12] OPEN Progression in some l2bdscale tests. [CSIT-1745]
 
-    [13] DONE Stateless ACL test have the same performance in 2005.0-4
+    [13] DONE Stateless ACL tests have the same performance in 2005.0-4
     as in 2001.0-2. The difference shown here is inflated by an API
     change, see [1]. [CSIT-1739]
 
-    [14] DONE Stateful ACL test have better performance in 2005.0-4 as
-    in 2001.0-2. The VPP part of API change, Gerrit 26184, made VPP
-    faster. The difference shown here is further inflated by the API
-    change, see [1]. [CSIT-1739]
+    [14] DONE Stateful ACL tests have better performance in 2005.0-4 as
+    in 2001.0-2. The CSIT part of API change, Gerrit 26112, has fixed
+    an earlier CSIT regression in the same tests. The difference shown here
+    is further inflated by the API mismatch, see [1]. [CSIT-1739]
 
     [15] OPEN Progression in nat44 test (not scale ones). [CSIT-1747]
 
diff --git a/resources/tools/presentation/rca/rca-2n-skx-2t1c-ndr-rca1.yaml b/resources/tools/presentation/rca/rca-2n-skx-2t1c-ndr-rca1.yaml
index 2274748d78..b2103da304 100644
--- a/resources/tools/presentation/rca/rca-2n-skx-2t1c-ndr-rca1.yaml
+++ b/resources/tools/presentation/rca/rca-2n-skx-2t1c-ndr-rca1.yaml
@@ -35,7 +35,7 @@
 # see https://yaml-multiline.info/
 
 footnote: "
-    [1] DONE Regression in ACL tests due to Gerrit 26112. With CSIT
+    [1] DONE Apparent regression in ACL tests due to Gerrit 26112. With CSIT
     using changed VPP API, instead of failing, misconfigured VPP passes
     the test, albeit with reduced performance. [CSIT-1739]
 
@@ -58,18 +58,20 @@ footnote: "
     bihash may have improved code efficiency. [CSIT-1735]
 
     [11] OPEN Progression in memif tests, mainly in
-    avf-eth-l2xcbase-eth-2memif-1dcr. [CSIT-1744]
+    avf-eth-l2xcbase-eth-2memif-1dcr. Two progression candidates found:
+    Gerrit 24053 and Gerrit 26744. Performance results are not consistent enough
+    to separate the two from other possible causes. [CSIT-1744]
 
     [12] OPEN Progression in some l2bdscale tests. [CSIT-1745]
 
-    [13] DONE Stateless ACL test have the same performance in 2005.0-4
+    [13] DONE Stateless ACL tests have the same performance in 2005.0-4
     as in 2001.0-2. The difference shown here is inflated by an API
     change, see [1]. [CSIT-1739]
 
-    [14] DONE Stateful ACL test have better performance in 2005.0-4 as
-    in 2001.0-2. The VPP part of API change, Gerrit 26184, made VPP
-    faster. The difference shown here is further inflated by the API
-    change, see [1]. [CSIT-1739]
+    [14] DONE Stateful ACL tests have better performance in 2005.0-4 as
+    in 2001.0-2. The CSIT part of API change, Gerrit 26112, has fixed
+    an earlier CSIT regression in the same tests. The difference shown here
+    is further inflated by the API mismatch, see [1]. [CSIT-1739]
 
     [15] OPEN Progression in nat44 test (not scale ones). [CSIT-1747]
 
diff --git a/resources/tools/presentation/rca/rca-2n-skx-2t1c-pdr-rca1.yaml b/resources/tools/presentation/rca/rca-2n-skx-2t1c-pdr-rca1.yaml
index 8cc7ee352d..38d67cd539 100644
--- a/resources/tools/presentation/rca/rca-2n-skx-2t1c-pdr-rca1.yaml
+++ b/resources/tools/presentation/rca/rca-2n-skx-2t1c-pdr-rca1.yaml
@@ -23,7 +23,7 @@
 # see https://yaml-multiline.info/
 
 footnote: "
-    [1] DONE Regression in ACL tests due to Gerrit 26112. With CSIT
+    [1] DONE Apparent regression in ACL tests due to Gerrit 26112. With CSIT
     using changed VPP API, instead of failing, misconfigured VPP passes
     the test, albeit with reduced performance. [CSIT-1739]
 
@@ -53,18 +53,20 @@ footnote: "
     bihash may have improved code efficiency. [CSIT-1735]
 
     [11] OPEN Progression in memif tests, mainly in
-    avf-eth-l2xcbase-eth-2memif-1dcr. [CSIT-1744]
+    avf-eth-l2xcbase-eth-2memif-1dcr. Two progression candidates found:
+    Gerrit 24053 and Gerrit 26744. Performance results are not consistent enough
+    to separate the two from other possible causes. [CSIT-1744]
 
     [12] OPEN Progression in some l2bdscale tests. [CSIT-1745]
 
-    [13] DONE Stateless ACL test have the same performance in 2005.0-4
+    [13] DONE Stateless ACL tests have the same performance in 2005.0-4
     as in 2001.0-2. The difference shown here is inflated by an API
     change, see [1]. [CSIT-1739]
 
-    [14] DONE Stateful ACL test have better performance in 2005.0-4 as
-    in 2001.0-2. The VPP part of API change, Gerrit 26184, made VPP
-    faster. The difference shown here is further inflated by the API
-    change, see [1]. [CSIT-1739]
+    [14] DONE Stateful ACL tests have better performance in 2005.0-4 as
+    in 2001.0-2. The CSIT part of API change, Gerrit 26112, has fixed
+    an earlier CSIT regression in the same tests. The difference shown here
+    is further inflated by the API mismatch, see [1]. [CSIT-1739]
 
     [15] OPEN Progression in nat44 test (not scale ones). [CSIT-1747]
 
diff --git a/resources/tools/presentation/rca/rca-3n-skx-2t1c-pdr-rca1.yaml b/resources/tools/presentation/rca/rca-3n-skx-2t1c-pdr-rca1.yaml
index a132a0a232..2c55514909 100644
--- a/resources/tools/presentation/rca/rca-3n-skx-2t1c-pdr-rca1.yaml
+++ b/resources/tools/presentation/rca/rca-3n-skx-2t1c-pdr-rca1.yaml
@@ -28,9 +28,10 @@ footnote: "
     Gerrit 25309. Make VPP in VM worker placement deterministic.
     [CSIT-1738]
 
-    [6] OPEN Regression in CSIT, one specific test showing too small
-    stdev to be considered noise. Tentatively marking also other ipsec anomalies
-    with this, albeit they show higher stdev. [CSIT-1742]
+    [6] DONE Apparent regression in CSIT is caused by VPP renaming
+    the most performant IPsec plugin, thus the current CSIT version used with
+    the previous VPP version measures the less performant VPP IPsec plugin.
+    [CSIT-1742]
 
     [7] POSTPONED Possible anomaly, but stdev of results is high.
     Performance differences considered to probably be just noise.
@@ -45,12 +46,15 @@ footnote: "
     [10] OPEN Progression in ip6 base tests with dot1q. [CSIT-1746]
 
     [11] OPEN Progression in memif tests, mainly in
-    avf-eth-l2xcbase-eth-2memif-1dcr. [CSIT-1744]
+    avf-eth-l2xcbase-eth-2memif-1dcr. Two progression candidates found:
+    Gerrit 24053 and Gerrit 26744. Performance results are not consistent enough
+    to separate the two from other possible causes. [CSIT-1744]
 
     [12] OPEN Progression in some l2bdscale tests. [CSIT-1745]
 
-    [16] OPEN Progression in IPsec tests, only for aes128cbc-hmac512sha.
-    [CSIT-1748]
+    [16] OPEN Apparent progression in IPsec tests, only for aes128cbc-hmac512sha.
+    Considering [6], the positive difference is not large enough,
+    so there was probably a VPP regression. [CSIT-1748]
 
     [17] OPEN Progression in some vhost tests (dpdk in VM). [CSIT-1749]
 "