diff options
author | Peter Mikus <pmikus@cisco.com> | 2018-06-20 06:09:32 +0000 |
---|---|---|
committer | Tibor Frank <tifrank@cisco.com> | 2018-06-20 08:11:07 +0000 |
commit | 39b4a07718ecab94ea331362edb62dfcf678bd09 (patch) | |
tree | b9ec5da71705e9c8a9f4e91f63a7020a4d1c6e63 /docs/new/cpta/methodology | |
parent | b04fc853e356f0a2b8bceade3a9f57a8fa9e9ac7 (diff) |
Revert "CSIT-986: Use MLRsearch from pip"
This reverts commit 0c2c57d9965ab1db0d5404ad103871ac250339cb.
Reason for revert: unless you will fix this broken patch we have to revert this as it breaks several thing in the csit core ci/cd.
1) all tb are pypi offline this means no new pypi is automatically dowloaded. Everytime you change your version you have to update every tb. As this is not automated this will never work and put extreme overhead
2) this code is not pylint checked and not verified by any existing job breaking any kind of verificition mechanics in csit
3)there is no automation in terms of creating pypi (no job) this creates chicken egg problem that you cannot verify change unless new version is installed
Next time please think or consult with more seniored csit core developer
Unless above will be fixed i will revert on monday as now it breaks all jobs. I will set hard verification to framework setup (exception) so this will prevent next time merge.
Possible solution:
1)Move the directory back to resources and reference from csit directly not via pypi, leave the setup crap in dir and let users to create package on their own
Change-Id: Id530a9f19f668e45f73ffc9e7371bb453b59fd1b
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Diffstat (limited to 'docs/new/cpta/methodology')
0 files changed, 0 insertions, 0 deletions