diff options
| author |   Vratko Polak <vrpolak@cisco.com> | 2019-04-16 16:32:59 +0200 |
|---|---|---|
| committer | Vratko Polak <vrpolak@cisco.com> | 2019-04-17 10:39:18 +0000 |
| commit | 258f2666143138f20d84665fcfed53475bc88041 (patch) | |
| tree | be45d45e1913bd0c9c738662efea52deb16ffa9c /docs/test_code_guidelines.rst | |
| parent | c481185ca0662f4e7800af2ae6a8f3f81c753470 (diff) | |
Clean up traffic_profile vs osi_layer
The two types were not well distinguished before.
Error introduced in:
https://gerrit.fd.io/r/#/c/17811/84/resources/libraries/robot/performance/performance_setup.robot@255
Error hotfixed in:
https://gerrit.fd.io/r/#/c/18847/4/resources/libraries/robot/shared/default.robot@109
+ Rename some arguments and improve method docstrings.
Newly introduced argument name osi_layer should be dissimilar enough.
Change-Id: Ie0f6f97dc010fc6477f09c54574970f1d15462e2
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'docs/test_code_guidelines.rst')
| -rw-r--r-- | docs/test_code_guidelines.rst | 25 |
1 files changed, 11 insertions, 14 deletions
diff --git a/docs/test_code_guidelines.rst b/docs/test_code_guidelines.rst index 24544b93de..d1f268772b 100644 --- a/docs/test_code_guidelines.rst +++ b/docs/test_code_guidelines.rst @@ -72,30 +72,27 @@ RobotFramework test case files and resource files *** Keywords *** | Local Template | | [Documentation] - | | ... | [Cfg] DUT runs L2 patch config with ${phy_cores} phy - | | ... | core(s). - | | ... | [Ver] Measure MaxReceivedRate for ${framesize}B frames\ - | | ... | using single trial throughput test. + | | ... | [Cfg] DUT runs L2 patch config with ${phy_cores} phy core(s). + | | ... | [Ver] Measure NDR and PDR values using MLRsearch algorithm.\ | | ... | | ... | *Arguments:* - | | ... | - framesize - Framesize in Bytes in integer\ - | | ... | or string (IMIX_v4_1). Type: integer, string + | | ... | - frame_size - Framesize in Bytes in integer + | | ... | or string (IMIX_v4_1). Type: integer, string | | ... | - phy_cores - Number of physical cores. Type: integer - | | ... | - rxq - Number of RX queues, default value: ${None}.\ - | | ... | Type: integer + | | ... | - rxq - Number of RX queues, default value: ${None}. + | | ... | Type: integer | | ... - | | [Arguments] | ${framesize} | ${phy_cores} | ${rxq}=${None} + | | [Arguments] | ${frame_size} | ${phy_cores} | ${rxq}=${None} + | | ... + | | Set Test Variable | \${frame_size} | | ... | | Given Add worker threads and rxqueues to all DUTs | | ... | ${phy_cores} | ${rxq} | | And Add PCI devices to all DUTs - | | ${max_rate} | ${jumbo} = | Run Keyword - | | ... | Get Max Rate And Jumbo And Handle Multi Seg - | | ... | ${s_24.5G} | ${framesize} | pps_limit=${s_18.75Mpps} + | | Set Max Rate And Jumbo And Handle Multi Seg | | And Apply startup configuration on all VPP DUTs | | When Initialize L2 patch - | | Then Traffic should pass with maximum rate - | | ... | ${max_rate}pps | ${framesize} | ${traffic_profile} + | | Then Find NDR and PDR intervals using optimized search + Every suite and test case template (or testcase) SHALL contain short documentation. |