diff options
author | 2022-01-31 15:24:53 +0100 | |
---|---|---|
committer | 2022-06-30 07:02:06 +0000 | |
commit | 9e22f65d5e9f7045625a8d6bf79ce75d836e1447 (patch) | |
tree | 847c04b2e7890700781289a62ab1a8b49c1ef3af /resources/libraries/bash/entry/check/line.sh | |
parent | 325cef50672aed697e277405fe9bb9b797d02701 (diff) |
style(tox): prepare for fixer scripts
The previous code assumes each tox script is a checker.
We want to add fixer scripts (not voting but editing) soon.
This is the less interesting part of the process,
renaming things and updating comments.
Includes some basic descriptions of how fixers differ from checkers.
Change-Id: I1ca1572a328acd02b41dcf4e70d7cb3746a03b03
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'resources/libraries/bash/entry/check/line.sh')
-rw-r--r-- | resources/libraries/bash/entry/check/line.sh | 50 |
1 files changed, 0 insertions, 50 deletions
diff --git a/resources/libraries/bash/entry/check/line.sh b/resources/libraries/bash/entry/check/line.sh deleted file mode 100644 index 6f373121e0..0000000000 --- a/resources/libraries/bash/entry/check/line.sh +++ /dev/null @@ -1,50 +0,0 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at: -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -set -exuo pipefail - -# This file should be executed from tox, as the assumend working directory -# is different from where this file is located. -# This file does not have executable flag nor shebang, -# to dissuade non-tox callers. - -# This script runs a grep-based command and fails if it detects any lines -# longer than 80 characters. -# The grep output stored to lines.log (overwriting). - -# "set -eu" handles failures from the following two lines. -BASH_CHECKS_DIR="$(dirname $(readlink -e "${BASH_SOURCE[0]}"))" -BASH_FUNCTION_DIR="$(readlink -e "${BASH_CHECKS_DIR}/../../function")" -source "${BASH_FUNCTION_DIR}/common.sh" || { - echo "Source failed." >&2 - exit 1 -} - -# Directory docs contains too many wide formatted tables. -# .txt contains lines with wide URLs. -piped_command='set -exuo pipefail && grep -rn ".\{81\}" "resources/" "tests/"' -piped_command+=' | fgrep -v .svg | fgrep -v .txt | tee "lines.log" | wc -l' -# TODO: The greps "fail" if no long line remains. Fix that if it ever happens. -lines="$(bash -c "${piped_command}")" || die -if [ "${lines}" != "0" ]; then - # TODO: Decide which text goes to stdout and which to stderr. - warn "Long lines detected: ${lines}" - ## TODO: Enable when output size does more good than harm. - # cat "lines.log" >&2 - warn - warn "Line length checker: FAIL" - exit 1 -fi - -warn -warn "Line length checker: PASS" |