style(tox): prepare for fixer scripts

The previous code assumes each tox script is a checker.
We want to add fixer scripts (not voting but editing) soon.

This is the less interesting part of the process,
renaming things and updating comments.

Includes some basic descriptions of how fixers differ from checkers.

Change-Id: I1ca1572a328acd02b41dcf4e70d7cb3746a03b03
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

1 files changed, 0 insertions, 45 deletions

diff --git a/resources/libraries/bash/entry/check/pylint.sh b/resources/libraries/bash/entry/check/pylint.sh
deleted file mode 100644
index fbfea4773e..0000000000
--- a/resources/libraries/bash/entry/check/pylint.sh
+++ /dev/null
@@ -1,45 +0,0 @@
-# Copyright (c) 2021 Cisco and/or its affiliates.
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at:
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-set -exuo pipefail
-
-# This file should be executed from tox, as the assumend working directory
-# is different from where this file is located.
-# This file does not have executable flag nor shebang,
-# to dissuade non-tox callers.
-
-# This script runs pylint and propagates its exit code.
-# Config is taken from pylint.cfg,
-# and proper virtualenv is assumed to be active.
-# The pylint output stored to pylint.log (overwriting).
-
-# "set -eu" handles failures from the following two lines.
-BASH_CHECKS_DIR="$(dirname $(readlink -e "${BASH_SOURCE[0]}"))"
-BASH_FUNCTION_DIR="$(readlink -e "${BASH_CHECKS_DIR}/../../function")"
-source "${BASH_FUNCTION_DIR}/common.sh" || {
-    echo "Source failed." >&2
-    exit 1
-}
-pylint_args=("--rcfile=pylint.cfg" "resources/" "GPL/traffic_scripts")
-if pylint "${pylint_args[@]}" > "pylint.log"; then
-    warn
-    warn "Pylint checker: PASS"
-else
-    # TODO: Decide which text goes to stdout and which to stderr.
-    warn "Pylint exited with nonzero status."
-    ## TODO: Enable when output size does more good than harm.
-    # cat "pylint.log" >&2
-    warn
-    warn "Pylint checker: FAIL"
-    exit 1
-fi