diff options
author | Vratko Polak <vrpolak@cisco.com> | 2023-08-17 14:17:33 +0200 |
---|---|---|
committer | Vratko Polak <vrpolak@cisco.com> | 2023-08-17 14:17:33 +0200 |
commit | 0634490c0557d94856f6061c323cf6a2592f294b (patch) | |
tree | e44b680b5626d64680c46833498d27bf411d25b0 /resources/libraries/bash/function/common.sh | |
parent | 14f0a243ce732df3ea7316fc20ce6132dc54f384 (diff) |
Add ability to parse more kinds of test results
Previously, only BMRR results were recongnized.
Now also lower bounds for PDR (optionally NDR) and soak are recongnized.
This code expects all tests are of the same type,
e.g. when both MRR and NDRPDR tests are run,
only MRR result will get parsed.
If test or parsing fails, generate fake data based on overall pass or fail,
so at least passrate of unknown tests can be compared in theory.
Currently affects only per-patch job (vpp-csit-verify-perf-*),
but is useful mainly for the upcoming bisect job.
+ Do not force MRR test type in vpp-csit jobs.
- Some test results are still not recognized (e.g. hoststack).
+ Do not exit per-patch job early on robot failure.
+ Only changes that introduce a failure (not present in parent) get -1.
+ The same is true also for introducing unrecognized test results.
- The fake values from passrate can be misleading.
+ Add default nic tag only if NIC tag is missing.
+ In all jobs, not only in vpp-csit ones.
+ Do not add NIC tags for device jobs.
- No job supports NDR parsing yet.
+ Can be enabled in future from ci-management side.
Change-Id: Iee904116d1ffed69aec7e31821c67d8447f49ebe
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'resources/libraries/bash/function/common.sh')
-rw-r--r-- | resources/libraries/bash/function/common.sh | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/resources/libraries/bash/function/common.sh b/resources/libraries/bash/function/common.sh index fc019facda..b209958194 100644 --- a/resources/libraries/bash/function/common.sh +++ b/resources/libraries/bash/function/common.sh @@ -533,6 +533,8 @@ function get_test_tag_string () { # Variables set: # - TEST_TAG_STRING - The string following trigger word in gerrit comment. # May be empty, or even not set on event types not adding comment. + # Variables exported optionally: + # - GRAPH_NODE_VARIANT - Node variant to test with, set if found in trigger. # TODO: ci-management scripts no longer need to perform this. @@ -1074,19 +1076,15 @@ function select_tags () { TAGS=() prefix="" - - set +x if [[ "${TEST_CODE}" == "vpp-"* ]]; then if [[ "${TEST_CODE}" != *"device"* ]]; then - # Automatic prefixing for VPP perf jobs to limit the NIC used and - # traffic evaluation to MRR. - if [[ "${TEST_TAG_STRING-}" == *"nic_"* ]]; then - prefix="${prefix}mrrAND" - else - prefix="${prefix}mrrAND${default_nic}AND" + # Automatic prefixing for VPP perf jobs to limit the NIC used. + if [[ "${TEST_TAG_STRING-}" != *"nic_"* ]]; then + prefix="${default_nic}AND" fi fi fi + set +x for tag in "${test_tag_array[@]}"; do if [[ "${tag}" == "!"* ]]; then # Exclude tags are not prefixed. |