diff options
| author |   Vratko Polak <vrpolak@cisco.com> | 2019-07-09 12:17:09 +0200 |
|---|---|---|
| committer |   Dave Wallace <dwallacelf@gmail.com> | 2019-07-12 13:00:49 +0000 |
| commit | 33fb34665214bbbd0a4b3154169b21c2da01f69b (patch) | |
| tree | 9ebb70889824451cf8411875159a6fafd70b60ac /resources/libraries/python/IPv6Util.py | |
| parent | ccfe499e2a27f2caf234ecbb2ec948120810eab6 (diff) | |
PapiExecutor always verifies
Do not support returning unverified replies anymore.
Basically, ".get_replies().verify_replies()" is now just ".get_replies()".
This allows fairly large simplifications both at call sites
and in PapiExecutor.py
+ Rename get_dumps to get_details.
+ Introduce get_reply and get_sw_if_index.
+ Rename variables holding get_*() value,
+ e.g. get_stats() value is stored to variable named "stats".
+ Rename "item" of subsequent loop to hint the type instead.
+ Rename "details" function argument to "verbose".
+ Process reply details in place, instead of building new list.
- Except hybrid blocks which can return both list or single item.
- Except human readable text building blocks.
+ Rename most similar names to sw_if_index.
- Except "vpp_sw_index" and some function names.
+ Use single run_cli_cmd from PapiExecutor.
+ Do not chain methods over multiple lines.
+ Small space gain is not worth readability loss.
+ Include minor code and docstrings improvement.
+ Add some TODOs.
Change-Id: Ib2110a3d2101a74d5837baab3a58dc46aafc6ce3
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'resources/libraries/python/IPv6Util.py')
| -rw-r--r-- | resources/libraries/python/IPv6Util.py | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/resources/libraries/python/IPv6Util.py b/resources/libraries/python/IPv6Util.py index 28e5f7d2fb..9138c09a20 100644 --- a/resources/libraries/python/IPv6Util.py +++ b/resources/libraries/python/IPv6Util.py @@ -39,8 +39,7 @@ class IPv6Util(object): 'interface {ifc}'.format(ifc=interface) with PapiExecutor(node) as papi_exec: - papi_exec.add(cmd, **args).get_replies(err_msg). \ - verify_reply(err_msg=err_msg) + papi_exec.add(cmd, **args).get_reply(err_msg) @staticmethod def vpp_ra_send_after_interval(node, interface, interval=2): @@ -62,8 +61,7 @@ class IPv6Util(object): 'interface {ifc}'.format(ifc=interface) with PapiExecutor(node) as papi_exec: - papi_exec.add(cmd, **args).get_replies(err_msg). \ - verify_reply(err_msg=err_msg) + papi_exec.add(cmd, **args).get_reply(err_msg) @staticmethod def vpp_all_ra_suppress_link_layer(nodes): |