aboutsummaryrefslogtreecommitdiffstats
path: root/resources/libraries/python/Policer.py
diff options
context:
space:
mode:
authorVratko Polak <vrpolak@cisco.com>2019-12-04 13:24:07 +0100
committerPeter Mikus <pmikus@cisco.com>2019-12-05 07:03:57 +0000
commit063abf35e81deaf749ebbcfee339fbd1d9e89412 (patch)
treec932eac04f162c46b0f3c38db10105b945a617cb /resources/libraries/python/Policer.py
parent6221f1b96d2a167c6db74ff26cd7ec7906ae9486 (diff)
Deal with some "pylint: disable=" comments
+ When possible, fix the violation. + Else, add a comment: + An explanation (if not already present) and keep disable. + A TODO (if not already present) and remove the disable. - This makes tox job report more pylint violations, but any such violation is fixable and should be fixed. - Although some need to be fixed in VPP, such as enum item long names. Change-Id: I48604b5eda070083d79dff1439620dbd9e798e1f Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'resources/libraries/python/Policer.py')
-rw-r--r--resources/libraries/python/Policer.py6
1 files changed, 5 insertions, 1 deletions
diff --git a/resources/libraries/python/Policer.py b/resources/libraries/python/Policer.py
index f6a852e417..d5500e1d89 100644
--- a/resources/libraries/python/Policer.py
+++ b/resources/libraries/python/Policer.py
@@ -84,7 +84,11 @@ class DSCP(IntEnum):
class Policer:
"""Policer utilities."""
- # pylint: disable=too-many-arguments, too-many-locals
+ # TODO: Pylint says too-many-arguments and too-many-locals.
+ # It is right, we should refactor the code
+ # and group similar arguments together (into documented classes).
+ # Note that even the call from Robot Framework
+ # is not very readable with this many arguments.
@staticmethod
def policer_set_configuration(
node, policer_name, cir, eir, cbs, ebs, rate_type, round_type,