PapiExecutor always verifies

Do not support returning unverified replies anymore.
Basically, ".get_replies().verify_replies()" is now just ".get_replies()".
This allows fairly large simplifications both at call sites
and in PapiExecutor.py

+ Rename get_dumps to get_details.
+ Introduce get_reply and get_sw_if_index.
+ Rename variables holding get_*() value,
  + e.g. get_stats() value is stored to variable named "stats".
  + Rename "item" of subsequent loop to hint the type instead.
  + Rename "details" function argument to "verbose".
+ Process reply details in place, instead of building new list.
  - Except hybrid blocks which can return both list or single item.
  - Except human readable text building blocks.
+ Rename most similar names to sw_if_index.
  - Except "vpp_sw_index" and some function names.
+ Use single run_cli_cmd from PapiExecutor.
+ Do not chain methods over multiple lines.
  + Small space gain is not worth readability loss.
+ Include minor code and docstrings improvement.
+ Add some TODOs.

Change-Id: Ib2110a3d2101a74d5837baab3a58dc46aafc6ce3
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

1 files changed, 39 insertions, 0 deletions

diff --git a/resources/libraries/python/PythonThree.py b/resources/libraries/python/PythonThree.py
new file mode 100644
index 0000000000..6ecea80173
--- /dev/null
+++ b/resources/libraries/python/PythonThree.py
@@ -0,0 +1,39 @@
+# Copyright (c) 2019 Cisco and/or its affiliates.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at:
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Library holding utility functions to be replaced by later Python builtins."""
+
+from robot.api import logger
+
+
+def raise_from(raising, excepted, level="WARN"):
+    """Function to be replaced by "raise from" in Python 3.
+
+    Neither "six" nor "future" offer good enough implementation right now.
+    chezsoi.org/lucas/blog/displaying-chained-exceptions-stacktraces-in-python-2
+
+    Current implementation just logs the excepted error, and raises the new one.
+    For allower log level values, see:
+    robot-framework.readthedocs.io/en/latest/autodoc/robot.api.html#log-levels
+
+    :param raising: The exception to raise.
+    :param excepted: The exception we excepted and want to log.
+    :param level: Robot logger logging level to log with.
+    :type raising: BaseException
+    :type excepted: BaseException
+    :type level: str
+    :raises: raising
+    """
+    logger.write("Excepted: {exc!r}\nRaising: {rai!r}".format(
+        exc=excepted, rai=raising), level)
+    raise raising