diff options
| author |   Vratko Polak <vrpolak@cisco.com> | 2019-12-04 13:24:07 +0100 |
|---|---|---|
| committer |   Peter Mikus <pmikus@cisco.com> | 2019-12-05 07:03:57 +0000 |
| commit | 063abf35e81deaf749ebbcfee339fbd1d9e89412 (patch) | |
| tree | c932eac04f162c46b0f3c38db10105b945a617cb /resources/libraries/python/TrafficGenerator.py | |
| parent | 6221f1b96d2a167c6db74ff26cd7ec7906ae9486 (diff) | |
Deal with some "pylint: disable=" comments
+ When possible, fix the violation.
+ Else, add a comment:
+ An explanation (if not already present) and keep disable.
+ A TODO (if not already present) and remove the disable.
- This makes tox job report more pylint violations,
but any such violation is fixable and should be fixed.
- Although some need to be fixed in VPP, such as enum item long names.
Change-Id: I48604b5eda070083d79dff1439620dbd9e798e1f
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'resources/libraries/python/TrafficGenerator.py')
| -rw-r--r-- | resources/libraries/python/TrafficGenerator.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/resources/libraries/python/TrafficGenerator.py b/resources/libraries/python/TrafficGenerator.py index 14d2dc8d1c..007079f254 100644 --- a/resources/libraries/python/TrafficGenerator.py +++ b/resources/libraries/python/TrafficGenerator.py @@ -125,7 +125,8 @@ class TGDropRateSearchImpl(DropRateSearch): return tg_instance.get_latency_int() -# pylint: disable=too-many-instance-attributes +# TODO: Pylint says too-many-instance-attributes. +# A fix is developed in https://gerrit.fd.io/r/c/csit/+/22221 class TrafficGenerator(AbstractMeasurer): """Traffic Generator. @@ -201,7 +202,8 @@ class TrafficGenerator(AbstractMeasurer): """ return self._latency - # pylint: disable=too-many-locals + # TODO: pylint says disable=too-many-locals. + # A fix is developed in https://gerrit.fd.io/r/c/csit/+/22221 def initialize_traffic_generator( self, tg_node, tg_if1, tg_if2, tg_if1_adj_node, tg_if1_adj_if, tg_if2_adj_node, tg_if2_adj_if, osi_layer, tg_if1_dst_mac=None, |