diff options
| author |   Peter Mikus <peter.mikus@icloud.com> | 2025-01-31 08:44:49 +0100 |
|---|---|---|
| committer | Peter Mikus <peter.mikus@icloud.com> | 2025-01-31 08:43:11 +0000 |
| commit | a8abc698a4d03488ac3808a9a3f106d6cb047e98 (patch) | |
| tree | 1366e649c70cb1e5f090ad99380af54824898dc6 /resources/libraries/python | |
| parent | 4e6c67677f53c50e230672e0d0a2146ef963b70d (diff) | |
fix(core): VPP startup sequence
Signed-off-by: Peter Mikus <peter.mikus@icloud.com>
Change-Id: I37899c45bf8d87f24cb67cdd120837a833955a3b
Diffstat (limited to 'resources/libraries/python')
| -rw-r--r-- | resources/libraries/python/ContainerUtils.py | 4 | ||||
| -rw-r--r-- | resources/libraries/python/DPDK/DPDKTools.py | 3 | ||||
| -rw-r--r-- | resources/libraries/python/VPPUtil.py | 3 | ||||
| -rw-r--r-- | resources/libraries/python/VppConfigGenerator.py | 1 |
4 files changed, 3 insertions, 8 deletions
diff --git a/resources/libraries/python/ContainerUtils.py b/resources/libraries/python/ContainerUtils.py index 7d6d4d8673..887c869b8b 100644 --- a/resources/libraries/python/ContainerUtils.py +++ b/resources/libraries/python/ContainerUtils.py @@ -1,4 +1,4 @@ -# Copyright (c) 2024 Cisco and/or its affiliates. +# Copyright (c) 2025 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -580,7 +580,6 @@ class ContainerManager: def stop_all_containers(self): """Stop all containers.""" - # TODO: Rework if containers can be affected outside ContainerManager. self._disconnect_papi_to_all_containers() for container in self.containers: self.engine.container = self.containers[container] @@ -588,7 +587,6 @@ class ContainerManager: def destroy_all_containers(self): """Destroy all containers.""" - # TODO: Rework if containers can be affected outside ContainerManager. self._disconnect_papi_to_all_containers() for container in self.containers: self.engine.container = self.containers[container] diff --git a/resources/libraries/python/DPDK/DPDKTools.py b/resources/libraries/python/DPDK/DPDKTools.py index cf5f6fc79e..12800ba4fc 100644 --- a/resources/libraries/python/DPDK/DPDKTools.py +++ b/resources/libraries/python/DPDK/DPDKTools.py @@ -1,4 +1,4 @@ -# Copyright (c) 2024 Cisco and/or its affiliates. +# Copyright (c) 2025 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -94,7 +94,6 @@ class DPDKTools: command = f"cat {Constants.REMOTE_FW_DIR}/dpdk*/VERSION" message = u"Get DPDK version failed!" stdout, _ = exec_cmd_no_error(node, command, message=message) - # TODO: PAL should already tolerate stripped value in the log. logger.info(f"DPDK Version: {stdout}") return stdout.strip() diff --git a/resources/libraries/python/VPPUtil.py b/resources/libraries/python/VPPUtil.py index 1ede76cdd4..29138da4f4 100644 --- a/resources/libraries/python/VPPUtil.py +++ b/resources/libraries/python/VPPUtil.py @@ -1,4 +1,4 @@ -# Copyright (c) 2023 Cisco and/or its affiliates. +# Copyright (c) 2025 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -280,7 +280,6 @@ class VPPUtil: if_dump[u"sub_if_flags"] = if_dump[u"sub_if_flags"].value \ if hasattr(if_dump[u"sub_if_flags"], u"value") \ else int(if_dump[u"sub_if_flags"]) - # TODO: return only base data logger.trace(f"Interface data of host {node[u'host']}:\n{details}") @staticmethod diff --git a/resources/libraries/python/VppConfigGenerator.py b/resources/libraries/python/VppConfigGenerator.py index ea523b7cb0..384964eae0 100644 --- a/resources/libraries/python/VppConfigGenerator.py +++ b/resources/libraries/python/VppConfigGenerator.py @@ -790,7 +790,6 @@ class VppInitConfig: vpp_config.add_unix_log() vpp_config.add_unix_cli_listen() vpp_config.add_unix_cli_no_pager() - vpp_config.add_unix_coredump() vpp_config.add_socksvr(socket=Constants.SOCKSVR_PATH) vpp_config.add_main_heap_size("2G") vpp_config.add_main_heap_page_size(huge_size) |