Add tests for Honeycomb L2 FIB support

JIRA: CSIT-168

- add tests for Honeycomb L2 FIB support
- add keywords for Honeycomb L2 FIB support
- fix typos

Change-Id: I81292c10e26e7ad05725034c1db1db0a81d29283
Signed-off-by: Tibor Frank <tifrank@cisco.com>

1 files changed, 108 insertions, 27 deletions

diff --git a/resources/libraries/robot/honeycomb/bridge_domain.robot b/resources/libraries/robot/honeycomb/bridge_domain.robot
index 29510bdd7a..4c455ff50d 100644
--- a/resources/libraries/robot/honeycomb/bridge_domain.robot
+++ b/resources/libraries/robot/honeycomb/bridge_domain.robot
@@ -16,6 +16,8 @@
 | Library | resources.libraries.python.honeycomb.HcAPIKwBridgeDomain.BridgeDomainKeywords
 | Library | resources.libraries.python.honeycomb.HcAPIKwInterfaces.InterfaceKeywords
 | ...     | WITH NAME | InterfaceAPI
+| Library | resources.libraries.python.InterfaceUtil
+| ...     | WITH NAME | interfaceCLI
 
 *** Keywords ***
 | Honeycomb creates first L2 bridge domain
@@ -23,9 +25,9 @@
 | | ... | VPP node. Any other bridge domains will be removed in the process.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
-| | ... | - bd_name - name of the created bridge domain. Type: string
-| | ... | - settings - settings for the created bridge domain. Type: dictionary
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - bd_name - Name of the created bridge domain. Type: string
+| | ... | - settings - Settings for the created bridge domain. Type: dictionary
 | | ...
 | | ... | *Example:*
 | | ...
@@ -39,9 +41,9 @@
 | | ... | VPP node.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
-| | ... | - bd_name - name of the created bridge domain. Type: string
-| | ... | - settings - settings for the created bridge domain. Type: dictionary
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - bd_name - Name of the created bridge domain. Type: string
+| | ... | - settings - Settings for the created bridge domain. Type: dictionary
 | | ...
 | | ... | *Example:*
 | | ...
@@ -55,9 +57,9 @@
 | | ... | against provided values.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
-| | ... | - bd_name - name of the bridge domain. Type: string
-| | ... | - settings - expected settings for the bridge domain. Type: dictionary
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - bd_name - Name of the bridge domain. Type: string
+| | ... | - settings - Expected settings for the bridge domain. Type: dictionary
 | | ...
 | | ... | *Example:*
 | | ...
@@ -73,9 +75,9 @@
 | | ... | against provided values.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
-| | ... | - bd_name - name of the bridge domain. Type: string
-| | ... | - settings - expected settings for the bridge domain. Type: dictionary
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - bd_name - Name of the bridge domain. Type: string
+| | ... | - settings - Expected settings for the bridge domain. Type: dictionary
 | | ...
 | | ... | *Example:*
 | | ...
@@ -93,11 +95,11 @@
 | | ... | domain.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
-| | ... | - interface1, interface2 - names of interfaces to assign to bridge\
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - interface1, interface2 - Names of interfaces to assign to bridge\
 | | ... | domain. Type: string
-| | ... | - bd_name - name of the bridge domain. Type: string
-| | ... | - settings - bridge domain specific interface settings.\
+| | ... | - bd_name - Name of the bridge domain. Type: string
+| | ... | - settings - Bridge domain specific interface settings.\
 | | ... | Type: dictionary
 | | ...
 | | ... | *Example:*
@@ -117,11 +119,11 @@
 | | ... | bridge domain.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
-| | ... | - interface1, interface2 - names of interfaces to assign to bridge\
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - interface1, interface2 - Names of interfaces to assign to bridge\
 | | ... | domain. Type: string
-| | ... | - bd_name - name of the bridge domain. Type: string
-| | ... | - settings - bridge domain specific interface settings.\
+| | ... | - bd_name - Name of the bridge domain. Type: string
+| | ... | - settings - Bridge domain specific interface settings.\
 | | ... | Type: dictionary
 | | ...
 | | ... | *Example:*
@@ -149,12 +151,12 @@
 | | ... | bridge domain.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
-| | ... | - index - index of bridge domains on VPP node. Starts from 0,\
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - index - Index of bridge domains on VPP node. Starts from 0,\
 | | ... | new BDs reuse numbers after a bridge domain is removed. Type: int
-| | ... | - interface1, interface2 - names of interfaces to assign to bridge\
+| | ... | - interface1, interface2 - Names of interfaces to assign to bridge\
 | | ... | domain. Type: string
-| | ... | - settings - bridge domain specific interface settings.\
+| | ... | - settings - Bridge domain specific interface settings.\
 | | ... | Type: dictionary
 | | ...
 | | ... | *Example:*
@@ -179,7 +181,7 @@
 | | ... | VPP node.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
+| | ... | - node - Information about a DUT node. Type: dictionary
 | | ...
 | | ... | *Example:*
 | | ...
@@ -192,7 +194,7 @@
 | | ... | bridge domains.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
+| | ... | - node - Information about a DUT node. Type: dictionary
 | | ...
 | | ... | *Example:*
 | | ...
@@ -205,7 +207,7 @@
 | | [Documentation] | Uses VAT to verify the removal of all bridge domains.
 | | ...
 | | ... | *Arguments:*
-| | ... | - node - information about a DUT node. Type: dictionary
+| | ... | - node - Information about a DUT node. Type: dictionary
 | | ...
 | | ... | *Example:*
 | | ...
@@ -213,3 +215,82 @@
 | | [Arguments] | ${node}
 | | Run Keyword And Expect Error | ValueError: No JSON object could be decoded
 | | ... | VPP get bridge domain data | ${node}
+
+| Honeycomb adds interface to bridge domain
+| | [Documentation] | Uses Honeycomb API to assign interface to a bridge\
+| | ... | domain.
+| | ...
+| | ... | *Arguments:*
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - interface - Name of interface to assign to bridge domain.\
+| | ... | Type: string
+| | ... | - bd_name - Name of the bridge domain. Type: string
+| | ... | - settings - Bridge domain specific interface settings.\
+| | ... | Type: dictionary
+| | ...
+| | ... | *Example:*
+| | ...
+| | ... | \| Honeycomb adds interfaces to bridge domain \| ${nodes['DUT1']} \
+| | ... | \| GigabitEthernet0/8/0 \| bd-04 \
+| | ... | \| ${{split_horizon_group:2, bvi:False}} \|
+| | ...
+| | [Arguments] | ${node} | ${interface} | ${bd_name} | ${settings}
+| | ...
+| | interfaceAPI.Add bridge domain to interface
+| | ... | ${node} | ${interface} | ${settings['bridge-domain']}
+| | ... | ${settings['split-horizon-group']}
+| | ... | ${settings['bridged-virtual-interface']}
+
+| Bridge domain configuration in interface operational data should be empty
+| | [Documentation] | Get interface operational data and retrieve bridge
+| | ... | domain configuration from it. It should be empty.
+| | ...
+| | ... | *Arguments:*
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - interface - Name of interface where the bridge domain parameters \
+| | ... | will be checked.Type: string
+| | ...
+| | ... | *Example:*
+| | ... | \| Bridge domain configuration in interface operational data should \
+| | ... | be empty \| ${nodes['DUT1']} \| GigabitEthernet0/8/0 \|
+| | ...
+| | [Arguments] | ${node} | ${interface}
+| | ...
+| | ${if_data}= | interfaceAPI.Get BD Oper Data From Interface
+| | ... | ${node} | ${interface}
+| | Should be empty | ${if_data}
+
+| Bridge domain configuration in interface operational data should be
+| | [Documentation] | Get interface operational data and retrieve bridge
+| | ... | domain configuration from it. Compare the data to the expected one.
+| | ...
+| | ... | *Arguments:*
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - interface - Name of interface where the bridge domain parameters \
+| | ... | will be checked. Type: string
+| | ... | - bd_settings - The referential bridge domain data. Type: dictionary
+| | ...
+| | ... | *Example:*
+| | ... | \| Bridge domain configuration in interface operational data should \
+| | ... | be \| ${nodes['DUT1']} \| GigabitEthernet0/8/0 \| ${if_bd_settings} \|
+| | ...
+| | [Arguments] | ${node} | ${interface} | ${bd_settings}
+| | ...
+| | ${if_data}= | interfaceAPI.Get BD Oper Data From Interface
+| | ... | ${node} | ${interface}
+| | interfaceAPI.Compare Data Structures | ${if_data} | ${bd_settings}
+
+| VAT removes bridge domain
+| | [Documentation] Remove the specified bridge domain using VAT.
+| | ...
+| | ... | *Arguments:*
+| | ... | - node - Information about a DUT node. Type: dictionary
+| | ... | - bd_id - Bridge domain ID. Type: integer
+| | ...
+| | ... | *Example:*
+| | ... | \| VAT removes bridge domain \
+| | ... | \| ${nodes['DUT1']} \| 1 \|
+| | ...
+| | [Arguments] | ${node} | ${bd_id}
+| | ...
+| | Delete Bridge Domain VAT | ${node} | ${bd_id}