Honeycomb interface state management test

 - add simple test for interface management through Honeycomb API
 - add status code 500 to honeycomb startup check whitelist,
   due to Honeycomb changes in https://gerrit.fd.io/r/772
 - increase timeout value for Honeycomb startup check
 - modify Honeycomb setup keywords to allow starting Honeycomb
   on individual nodes
 - remove sanity test suite, tests now sorted by functional areas
   such as interfaces, bridge domains, VXlan,...

Change-Id: I87f9cf69577706f3b00e24a8d2c01df52fc707c6
Signed-off-by: selias <samuel.elias@pantheon.tech>

2 files changed, 90 insertions, 23 deletions

diff --git a/resources/libraries/robot/honeycomb.robot b/resources/libraries/robot/honeycomb/honeycomb.robot
index 98b8e23ae8..741807877d 100644
--- a/resources/libraries/robot/honeycomb.robot
+++ b/resources/libraries/robot/honeycomb/honeycomb.robot
@@ -17,14 +17,15 @@
 | Library | resources/libraries/python/HTTPRequest.py
 
 *** Keywords ***
-| Setup Honeycomb service
+| Setup Honeycomb service on DUTs
 | | [Documentation] | *Setup environment for honeycomb testing*
 | | ...
 | | ... | _Setup steps:_
 | | ... | - 1. Login to each honeycomb node using ssh
 | | ... | - 2. Startup honeycomb service
 | | ... | - 3. Monitor service startup using HTTP GET request loop
-| | ... | Expected sequence of HTTP replies: connection refused -> 404 -> 401 -> 503 -> 200 (pass)
+| | ... | Expected sequence of HTTP replies:
+| | ... | connection refused -> 404 -> 401 -> 503 or 500 -> 200 (pass)
 | | ... | - 4. Configure honeycomb nodes using HTTP PUT request
 | | ...
 | | ... | _Used global constants and variables:_
@@ -32,37 +33,27 @@
 | | ... | - HTTPCodes - HTTP protocol status codes
 | | ... | - ${nodes} - dictionary of all nodes in topology.YAML file
 | | ...
-| | Start Honeycomb on all DUTs | ${nodes}
-| | Wait until keyword succeeds | 3min | 10sec | Check honeycomb startup state | ${nodes}
-| | &{Header}= | Create dictionary | Content-Type=application/xml
-| | Add VPP to honeycomb network topology | ${nodes} | ${header}
+| | [Arguments] | @{duts}
+| | Start honeycomb on DUTs | @{duts}
+| | Wait until keyword succeeds | 4min | 20sec
+| | ... | Check honeycomb startup state | @{duts}
 
-| Stop honeycomb service
+| Stop honeycomb service on DUTs
 | | [Documentation] | *Cleanup environment after honeycomb testing*
 | | ...
 | | ... | _Teardown steps:_
 | | ... | - 1. Login to each honeycomb node using ssh
 | | ... | - 2. Stop honeycomb service
 | | ... | - 3. Monitor service shutdown using HTTP GET request loop
-| | ... | Expected sequence of HTTP replies: 200 -> 404 -> connection refused (pass)
+| | ... | Expected sequence of HTTP replies:
+| | ... | 200 -> 404 -> connection refused (pass)
 | | ...
 | | ... | _Used global constants and variables:_
 | | ... | - RESOURCES_TPL_HC - path to honeycomb templates directory
 | | ... | - HTTPCodes - HTTP protocol status codes
 | | ... | - ${nodes} - dictionary of all nodes in topology.YAML file
 | | ...
-| | Stop honeycomb on all DUTs | ${nodes}
-| | Wait until keyword succeeds | 1m | 5s | Check honeycomb shutdown state | ${nodes}
-
-| Honeycomb checks VPP node configuration
-| | [Documentation] | *Check configuration of honeycomb nodes*
-| | ...
-| | ... | _Arguments:_
-| | ... | - None
-| | ...
-| | ... | _Return value:_
-| | ... | - None
-| | ...
-| | ${reply}= | Get configured topology | ${nodes}
-| | :FOR | ${item} | IN | @{reply}
-| | | Should match regexp | ${item} | ^DUT\\d{1,2}$
\ No newline at end of file
+| | [Arguments] | @{duts}
+| | Stop honeycomb on DUTs | @{duts}
+| | Wait until keyword succeeds | 2m | 10s
+| | ... | Check honeycomb shutdown state | @{duts}
diff --git a/resources/libraries/robot/honeycomb/interfaces.robot b/resources/libraries/robot/honeycomb/interfaces.robot
new file mode 100644
index 0000000000..338c3cfc24
--- /dev/null
+++ b/resources/libraries/robot/honeycomb/interfaces.robot
@@ -0,0 +1,76 @@
+# Copyright (c) 2016 Cisco and/or its affiliates.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at:
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+*** Settings ***
+| Library | resources/libraries/python/HoneycombUtil.py
+| Library | resources.libraries.python.InterfaceUtil
+| ... | WITH NAME | InterfaceCLI
+| Library | resources.libraries.python.HoneycombAPIKeywords.InterfaceKeywords
+| ... | WITH NAME | interfaceAPI
+
+*** Keywords ***
+| Honeycomb sets interface state
+| | [Arguments] | ${node} | ${interface} | ${state}
+| | [Documentation] | Uses Honeycomb API to change the admin state
+| | ... | of the specified interface.
+| | ...
+| | ... | *Arguments:*
+| | ... | - state - state to set on interface
+| | ... | - node - dictionary of information about a DUT node
+| | ... | - interface - name of an interface on the specified node
+| | ...
+| | interfaceAPI.Set interface state | ${node} | ${interface} | ${state}
+
+| Interface state from Honeycomb should be
+| | [Arguments] | ${node} | ${interface} | ${state}
+| | [Documentation] | Retrieves interface admin state through Honeycomb and
+| | ... | compares with state supplied in argument
+| | ...
+| | ... | *Arguments:*
+| | ... | - state - expected interface state
+| | ... | - node - dictionary of information about a DUT node
+| | ... | - interface - name of an interface on the specified node
+| | ...
+| | ${api_data}= | interfaceAPI.Get interface oper info | ${node} | ${interface}
+| | ${api_state}= | Set Variable | ${api_data['admin-status']}
+| | Should be equal | ${api_state} | ${state}
+
+| Interface state from VAT should be
+| | [Arguments] | ${node} | ${interface} | ${state}
+| | [Documentation] | Retrieves interface admin state through VAT and compares
+| | ... | with state supplied in argument
+| | ...
+| | ... | *Arguments:*
+| | ... | - state - expected interface state
+| | ... | - node - dictionary of information about a DUT node
+| | ... | - interface - name of an interface on the specified node
+| | ...
+| | ... | _NOTE:_ Vat returns state as int (1/0) instead of string (up/down).
+| | ... | This keyword also handles translation.
+| | ...
+| | ${vat_data}= | InterfaceCLI.VPP get interface data | ${node} | ${interface}
+| | ${vat_state}= | Set Variable if
+| | ... | ${vat_data['admin_up_down']} == 1 | up | down
+| | Should be equal | ${vat_state} | ${state}
+
+| Interface state is
+| | [Arguments] | ${node} | ${interface} | ${state}
+| | [Documentation] | Uses VPP binary API to ensure that the interface under
+| | ... | test is in the specified admin state.
+| | ...
+| | ... | *Arguments:*
+| | ... | - state - state to set on interface
+| | ... | - node - dictionary of information about a DUT node
+| | ... | - interface - name of an interface on the specified node
+| | ...
+| | interfaceAPI.Set interface state | ${node} | ${interface} | ${state}