diff options
author | Vratko Polak <vrpolak@cisco.com> | 2022-08-12 16:25:50 +0200 |
---|---|---|
committer | Vratko Polak <vrpolak@cisco.com> | 2022-08-16 08:03:57 +0000 |
commit | 4640b7da58f69f5b5aac69698656ae334735080c (patch) | |
tree | 1d5669d1a378f25c5c2106ee7a4018d83f6968e1 /resources/libraries/robot | |
parent | ffcf925b2f686bf368c6ee4adb08c7075b732d63 (diff) |
fix(robot): replace Run Keyword Unless
Use Run Keyword If, with the condition negated.
This silences the deprecation warning seen since Robot version bump.
Change-Id: I9a88ff551994df3e129d71327f08207133a958a6
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'resources/libraries/robot')
-rw-r--r-- | resources/libraries/robot/features/acl.robot | 6 | ||||
-rw-r--r-- | resources/libraries/robot/ip/ip4.robot | 24 | ||||
-rw-r--r-- | resources/libraries/robot/ip/ip6.robot | 10 | ||||
-rw-r--r-- | resources/libraries/robot/l2/l2_bridge_domain.robot | 6 | ||||
-rw-r--r-- | resources/libraries/robot/l2/l2_xconnect.robot | 4 | ||||
-rw-r--r-- | resources/libraries/robot/l2/tagging.robot | 16 | ||||
-rw-r--r-- | resources/libraries/robot/overlay/srv6.robot | 6 | ||||
-rw-r--r-- | resources/libraries/robot/performance/performance_utils.robot | 2 | ||||
-rw-r--r-- | resources/libraries/robot/shared/test_setup.robot | 4 |
9 files changed, 39 insertions, 39 deletions
diff --git a/resources/libraries/robot/features/acl.robot b/resources/libraries/robot/features/acl.robot index 1dd706c3ac..f474561a14 100644 --- a/resources/libraries/robot/features/acl.robot +++ b/resources/libraries/robot/features/acl.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -100,10 +100,10 @@ | | Add Macip Acl Multi Entries | ${dut} | rules=${acl0} | | Add Macip Acl Multi Entries | ${dut} | rules=${acl1} | | ${acl_idx}= | Set Variable | 0 -| | Run Keyword Unless | '${dut_if1}' == '${NONE}' +| | Run Keyword If | '${dut_if1}' != '${NONE}' | | ... | Add Del Macip Acl Interface | ${dut} | ${dut_if1} | add | ${acl_idx} | | ${acl_idx}= | Set Variable | 1 -| | Run Keyword Unless | '${dut_if2}' == '${NONE}' +| | Run Keyword If | '${dut_if2}' != '${NONE}' | | ... | Add Del Macip Acl Interface | ${dut} | ${dut_if2} | add | ${acl_idx} | Configure IPv4 ACLs diff --git a/resources/libraries/robot/ip/ip4.robot b/resources/libraries/robot/ip/ip4.robot index ef5b27f7de..1d4e3e22b6 100644 --- a/resources/libraries/robot/ip/ip4.robot +++ b/resources/libraries/robot/ip/ip4.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -83,17 +83,17 @@ | | ... | Vpp Route Add | ${dut2} | 10.10.10.0 | 24 | gateway=1.1.1.1 | | ... | interface=${DUT2_${int}1}[0] | | -| | Run Keyword Unless | '${remote_host1_ip}' == '${NONE}' +| | Run Keyword If | '${remote_host1_ip}' != '${NONE}' | | ... | Vpp Route Add | ${dut1} | ${remote_host1_ip} | ${remote_host_mask} | | ... | gateway=10.10.10.2 | interface=${DUT1_${int}1}[0] -| | Run Keyword Unless | '${remote_host2_ip}' == '${NONE}' +| | Run Keyword If | '${remote_host2_ip}' != '${NONE}' | | ... | Vpp Route Add | ${dut} | ${remote_host2_ip} | ${remote_host_mask} | | ... | gateway=20.20.20.2 | interface=${dut_if2} -| | Run Keyword Unless | '${remote_host1_ip}' == '${NONE}' +| | Run Keyword If | '${remote_host1_ip}' != '${NONE}' | | ... | Run Keyword If | '${dut2_status}' == 'PASS' | | ... | Vpp Route Add | ${dut1} | ${remote_host1_ip} | ${remote_host_mask} | | ... | gateway=1.1.1.2 | interface=${DUT1_${int}2}[0] -| | Run Keyword Unless | '${remote_host2_ip}' == '${NONE}' +| | Run Keyword If | '${remote_host2_ip}' != '${NONE}' | | ... | Run Keyword If | '${dut2_status}' == 'PASS' | | ... | Vpp Route Add | ${dut2} | ${remote_host2_ip} | ${remote_host_mask} | | ... | gateway=1.1.1.1 | interface=${DUT2_${int}1}[0] @@ -267,7 +267,7 @@ | | | ${memif2}= | Set Variable | ${${dut}-memif-${number}-if2} | | | ${fib_table_1}= | Evaluate | ${fib_table_1} + ${1} | | | ${fib_table_2}= | Evaluate | ${fib_table_1} + ${1} -| | | Run Keyword Unless | ${number} == ${count} +| | | Run Keyword If | ${number} != ${count} | | | ... | Add Fib Table | ${nodes['${dut}']} | ${fib_table_2} | | | Assign Interface To Fib Table | ${nodes['${dut}']} | | | ... | ${memif1} | ${fib_table_1} @@ -375,10 +375,10 @@ | | | ... | ${dut1} | ${dut1-vhost-${number}-if1} | 1.1.1.2 | 30 | | | VPP Interface Set IP Address | | | ... | ${dut1} | ${dut1-vhost-${number}-if2} | 1.1.2.2 | 30 -| | | Run Keyword Unless | ${testpmd_mac} +| | | Run Keyword If | not ${testpmd_mac} | | | ... | Vpp Route Add | ${dut1} | 20.0.0.0 | 8 | gateway=1.1.1.1 | | | ... | interface=${dut1-vhost-${number}-if1} | vrf=${fib_table_1} -| | | Run Keyword Unless | ${testpmd_mac} +| | | Run Keyword If | not ${testpmd_mac} | | | ... | Vpp Route Add | ${dut1} | 10.0.0.0 | 8 | gateway=1.1.2.1 | | | ... | interface=${dut1-vhost-${number}-if2} | vrf=${fib_table_2} | | | Run Keyword If | ${testpmd_mac} @@ -494,16 +494,16 @@ | | | ... | ${dut2} | ${dut2-vhost-${number}-if1} | 1.1.1.2 | 30 | | | VPP Interface Set IP Address | | | ... | ${dut2} | ${dut2-vhost-${number}-if2} | 1.1.2.2 | 30 -| | | Run Keyword Unless | ${testpmd_mac} +| | | Run Keyword If | not ${testpmd_mac} | | | ... | Vpp Route Add | ${dut1} | 20.0.0.0 | 8 | gateway=1.1.1.1 | | | ... | interface=${dut1-vhost-${number}-if1} | vrf=${fib_table_1} -| | | Run Keyword Unless | ${testpmd_mac} +| | | Run Keyword If | not ${testpmd_mac} | | | ... | Vpp Route Add | ${dut1} | 10.0.0.0 | 8 | gateway=1.1.2.1 | | | ... | interface=${dut1-vhost-${number}-if2} | vrf=${fib_table_2} -| | | Run Keyword Unless | ${testpmd_mac} +| | | Run Keyword If | not ${testpmd_mac} | | | ... | Vpp Route Add | ${dut2} | 20.0.0.0 | 8 | gateway=1.1.1.1 | | | ... | interface=${dut2-vhost-${number}-if1} | vrf=${fib_table_1} -| | | Run Keyword Unless | ${testpmd_mac} +| | | Run Keyword If | not ${testpmd_mac} | | | ... | Vpp Route Add | ${dut2} | 10.0.0.0 | 8 | gateway=1.1.2.1 | | | ... | interface=${dut2-vhost-${number}-if2} | vrf=${fib_table_2} | | | Run Keyword If | ${testpmd_mac} diff --git a/resources/libraries/robot/ip/ip6.robot b/resources/libraries/robot/ip/ip6.robot index edb264190c..506e5d844a 100644 --- a/resources/libraries/robot/ip/ip6.robot +++ b/resources/libraries/robot/ip/ip6.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -84,17 +84,17 @@ | | ... | Vpp Route Add | ${dut2} | 2001:1::0 | 64 | gateway=2001:3::1 | | ... | interface=${DUT2_${int}1}[0] | | -| | Run Keyword Unless | '${remote_host1_ip}' == '${NONE}' +| | Run Keyword If | '${remote_host1_ip}' != '${NONE}' | | ... | Vpp Route Add | ${dut1} | ${remote_host1_ip} | 128 | | ... | gateway=2001:1::2 | interface=${DUT1_${int}1}[0] -| | Run Keyword Unless | '${remote_host2_ip}' == '${NONE}' +| | Run Keyword If | '${remote_host2_ip}' != '${NONE}' | | ... | Vpp Route Add | ${dut} | ${remote_host2_ip} | 128 | | ... | gateway=2001:2::2 | interface=${dut_if2} -| | Run Keyword Unless | '${remote_host1_ip}' == '${NONE}' +| | Run Keyword If | '${remote_host1_ip}' != '${NONE}' | | ... | Run Keyword If | '${dut2_status}' == 'PASS' | | ... | Vpp Route Add | ${dut1} | ${remote_host1_ip} | 128 | | ... | gateway=2001:3::2 | interface=${DUT1_${int}2}[0] -| | Run Keyword Unless | '${remote_host2_ip}' == '${NONE}' +| | Run Keyword If | '${remote_host2_ip}' != '${NONE}' | | ... | Run Keyword If | '${dut2_status}' == 'PASS' | | ... | Vpp Route Add | ${dut2} | ${remote_host2_ip} | 128 | | ... | gateway=2001:3::1 | interface=${DUT2_${int}1}[0] diff --git a/resources/libraries/robot/l2/l2_bridge_domain.robot b/resources/libraries/robot/l2/l2_bridge_domain.robot index f54d1685c4..dbf26d3f84 100644 --- a/resources/libraries/robot/l2/l2_bridge_domain.robot +++ b/resources/libraries/robot/l2/l2_bridge_domain.robot @@ -1,5 +1,5 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. -# Copyright (c) 2021 PANTHEON.tech and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. +# Copyright (c) 2022 PANTHEON.tech and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -495,7 +495,7 @@ | | VPP Set interface MTU | ${dut1} | ${dut1_eth_bond_if1} | | FOR | ${pf} | IN RANGE | 1 | ${nic_pfs} + 1 | | | ${_even}= | Evaluate | ${pf} % 2 -| | | Run Keyword Unless | ${even} +| | | Run Keyword If | not ${even} | | | ... | VPP Add Bond Member | | | ... | ${dut1} | ${DUT1_${int}${pf}}[0] | ${dut1_eth_bond_if1} | | END diff --git a/resources/libraries/robot/l2/l2_xconnect.robot b/resources/libraries/robot/l2/l2_xconnect.robot index 59199b6c90..1d4d40db3d 100644 --- a/resources/libraries/robot/l2/l2_xconnect.robot +++ b/resources/libraries/robot/l2/l2_xconnect.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -247,7 +247,7 @@ | | VPP Set interface MTU | ${dut1} | ${dut1_eth_bond_if1} | | FOR | ${pf} | IN RANGE | 1 | ${nic_pfs} + 1 | | | ${_even}= | Evaluate | ${pf} % 2 -| | | Run Keyword Unless | ${even} +| | | Run Keyword If | not ${even} | | | ... | VPP Add Bond Member | | | ... | ${dut1} | ${DUT1_${int}${pf}}[0] | ${dut1_eth_bond_if1} | | END diff --git a/resources/libraries/robot/l2/tagging.robot b/resources/libraries/robot/l2/tagging.robot index dd4642c505..843b25d958 100644 --- a/resources/libraries/robot/l2/tagging.robot +++ b/resources/libraries/robot/l2/tagging.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -82,24 +82,24 @@ | | ... | \| ${dut1_if2} \| 10 \| | | | | Set Interface State | ${DUT1} | ${INT1} | up -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | Set Interface State | ${DUT2} | ${INT2} | up | | ${INT1_NAME}= | Get interface name | ${DUT1} | ${INT1} -| | ${INT2_NAME}= | Run Keyword Unless | ${DUT2} == ${None} +| | ${INT2_NAME}= | Run Keyword If | ${DUT2} != ${None} | | ... | Get interface name | ${DUT2} | ${INT2} | | ${subif_name_1} | ${subif_index_1}= | Create Vlan Subinterface | | ... | ${DUT1} | ${INT1_NAME} | ${SUB_ID} | | ${subif_name_2} | ${subif_index_2}= -| | ... | Run Keyword Unless | ${DUT2} == ${None} +| | ... | Run Keyword If | ${DUT2} != ${None} | | ... | Create Vlan Subinterface | ${DUT2} | ${INT2_NAME} | ${SUB_ID} | | Set Interface State | ${DUT1} | ${subif_index_1} | up -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | Set Interface State | ${DUT2} | ${subif_index_2} | up | | Set Test Variable | ${subif_name_1} | | Set Test Variable | ${subif_index_1} -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | Set Test Variable | ${subif_name_2} -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | Set Test Variable | ${subif_index_2} | Configure L2 tag rewrite method on interfaces @@ -115,7 +115,7 @@ | | ... | - TAG_REWRITE_METHOD - Method of tag rewrite. | | | | L2 Vlan tag rewrite | ${DUT1} | ${SUB_INT1} | ${TAG_REWRITE_METHOD} -| | Run Keyword Unless | ${DUT2} == ${None} +| | Run Keyword If | ${DUT2} != ${None} | | ... | L2 Vlan tag rewrite | ${DUT2} | ${SUB_INT2} | ${TAG_REWRITE_METHOD} | Configure L2 tag rewrite method on interface diff --git a/resources/libraries/robot/overlay/srv6.robot b/resources/libraries/robot/overlay/srv6.robot index 9462a71189..6ce7f74712 100644 --- a/resources/libraries/robot/overlay/srv6.robot +++ b/resources/libraries/robot/overlay/srv6.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -263,7 +263,7 @@ | | ... | VPP Add IP Neighbor | | ... | ${dut1} | ${DUT1_${int}2}[0] | ${dut2_if1_ip6} | | ... | ${DUT2_${int}1_mac}[0] -| | Run Keyword Unless | ${dut2_status} +| | Run Keyword If | not ${dut2_status} | | ... | VPP Add IP Neighbor | | ... | ${dut1} | ${DUT1_${int}2}[0] | ${dut2_if1_ip6} | ${TG_pf2_mac}[0] | | Run Keyword If | ${dut2_status} @@ -405,7 +405,7 @@ | | ... | VPP Add IP Neighbor | | ... | ${dut1} | ${DUT1_${int}2}[0] | ${dut2_if1_ip6} | | ... | ${DUT2_${int}1_mac}[0] -| | Run Keyword Unless | ${dut2_status} +| | Run Keyword If | not ${dut2_status} | | ... | VPP Add IP Neighbor | | ... | ${dut1} | ${DUT1_${int}2}[0] | ${dut2_if1_ip6} | ${TG_pf2_mac}[0] | | Run Keyword If | ${dut2_status} diff --git a/resources/libraries/robot/performance/performance_utils.robot b/resources/libraries/robot/performance/performance_utils.robot index c90fc7434d..bdac178125 100644 --- a/resources/libraries/robot/performance/performance_utils.robot +++ b/resources/libraries/robot/performance/performance_utils.robot @@ -330,7 +330,7 @@ | | ... | \| Send ramp-up traffic \| | | | | ${ramp_up_rate} = | Get Ramp Up Rate -| | Run Keyword Unless | ${ramp_up_rate} > 0.0 | Fail | Ramp up rate missing! +| | Run Keyword If | ${ramp_up_rate} <= 0.0 | Fail | Ramp up rate missing! | | ${ramp_up_duration} = | Get Ramp Up Duration | | ${ppta} = | Get Packets Per Transaction Aggregated | | ${traffic_directions} = | Get Traffic Directions diff --git a/resources/libraries/robot/shared/test_setup.robot b/resources/libraries/robot/shared/test_setup.robot index 3bc88858c0..22e017fd6f 100644 --- a/resources/libraries/robot/shared/test_setup.robot +++ b/resources/libraries/robot/shared/test_setup.robot @@ -1,4 +1,4 @@ -# Copyright (c) 2021 Cisco and/or its affiliates. +# Copyright (c) 2022 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -49,4 +49,4 @@ | | ... | Additional Setup for tests which uses namespace. | | | | ${trex_running}= | Is Trex Running | ${tg} -| | Run Keyword Unless | ${trex_running} | Startup Trex | ${tg} | ${osi_layer} +| | Run Keyword If | not ${trex_running} | Startup Trex | ${tg} | ${osi_layer} |