diff options
author | Vratko Polak <vrpolak@cisco.com> | 2018-06-13 13:04:01 +0200 |
---|---|---|
committer | Tibor Frank <tifrank@cisco.com> | 2018-06-15 10:16:43 +0000 |
commit | a2a0ab1cdec3567dcad46c2000337707777aa0ca (patch) | |
tree | 8d6147d2fda535c5c32c432a4ea7f3ec3124c8d9 /resources/tools/presentation/new/jumpavg/BitCountingMetadataFactory.py | |
parent | 5120b1082aa70f6e75511e9d95a2a7c303e25f9a (diff) |
CSIT-1110: Prepare for migrating the new detection
+ Do not declare BitCountingClassifier.classify() as class method.
+ Make BitCountingGroupList subclass of list.
+ Inherit from abstract classes whenever possible.
+ Drop unneeded imports.
+ Add module docstrings and class docstrings anywhere.
+ Add TODOs hinting at possible improvements.
Change-Id: Iccfff5c0e7be0607d6cfa74314083fcfe5a4d7d9
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Diffstat (limited to 'resources/tools/presentation/new/jumpavg/BitCountingMetadataFactory.py')
-rw-r--r-- | resources/tools/presentation/new/jumpavg/BitCountingMetadataFactory.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/resources/tools/presentation/new/jumpavg/BitCountingMetadataFactory.py b/resources/tools/presentation/new/jumpavg/BitCountingMetadataFactory.py index 5a7b393b55..567c3d4fe6 100644 --- a/resources/tools/presentation/new/jumpavg/BitCountingMetadataFactory.py +++ b/resources/tools/presentation/new/jumpavg/BitCountingMetadataFactory.py @@ -11,6 +11,8 @@ # See the License for the specific language governing permissions and # limitations under the License. +"""Module holding BitCountingMetadataFactory class.""" + import math from AvgStdevMetadata import AvgStdevMetadata @@ -19,7 +21,10 @@ from BitCountingMetadata import BitCountingMetadata class BitCountingMetadataFactory(object): - """Class for factory which creates bit counting metadata from data.""" + """Class for factory which creates bit counting metadata from data. + + TODO: Summarize the methods? + """ @staticmethod def find_max_value(values): |