Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Ied1ec832379dad4965ad2299834d2eaa7d1a4c88
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: Iebc24dae2b76408f07c145b2638c346193cf8e1e
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I615affce80f1e6af9ea0a5d581b84e17ee88e458
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I5e48e9d9759b456c8e4b67815045e8376632df65
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I14a59da85112473fde342b2f687bd87256a7d416
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
- No support for IMIX.
+ Fix a bad bug in padding (most ASTF profiles had wrong frame sizes).
+ Fix a big typo in TCP PPS profiles (s->c was not data, just RST).
+ Control transaction size via ASTF_N_DATA_FRAMES env variable.
- Default value 5 leads to transactions smaller than before.
+ It ensures transaction is one burst (per direction) even for jumbo.
+ Edit autogen to set supported frame sizes based on suite id.
+ Both TCP and UDP use the same values:
+ 64B for CPS (exact for UDP, nominal for TCP).
+ 100B, 1518B and 9000B for TPUT and PPS.
- TCP TPUT achievable minimum is 70B.
+ Used 100B to leave room for possible IPv6 ASTF tests.
+ Separate function for code reused by vpp and trex tests.
- I do not really like the new "copy and edit" approach added here.
+ But it is a quick edit, better autogen refactor is low priority.
+ Consider both established and transitory sessions as valid.
- Mostly for compatibility with 2202 behavior and to avoid ramp-ups.
- Assuming both session states have similar enough VPP CPU overhead.
+ Added a TODO to investigate and maybe reconsider later.
+ Update the state timeout value to 240s.
+ That is the default for TCP (for transitory state).
- UDP could keep using 300s.
+ But I prefer UDP and TCP to behave as similarly as possible.
+ Use TRex tunables to get the exact frame size (for data packets).
- It is not clear why the recipe for MSS has to be this complicated.
+ Move code away from profile init, as frame size is not known there.
+ Change internal profile API, so values related to MSS are passed.
+ Lower ramp-up rate for TCP TPUT tests.
+ Because without lower rate, jumbo fails on packet loss in ramp-up.
+ UDP TPUT ramp-up rate also lowered (just to keep suites more similar).
+ Distinguish one-direction and aggregated average frame size.
+ Update keyword documentation where the distiction matters.
+ One-direction is needed for turning bandwidth limit to TPS limit.
+ Aggregated is needed for correct NDRPDR bandwidth result value.
- TCP TPUT will always be few percent below bidirectional maximum.
+ That is unavoidable, as one direction sends more control packets.
+ Add runtime consistency checks so future refactors are safer.
+ Fail if padding requested would be negative.
+ Fail if suite claims unexpected values for packets per transaction.
+ Edit the 4 types of ASTF profiles to keep them similar to each other.
+ Move UDP TPUT limit value from a field back to direct argument.
+ Stop pretending first UDP packet is not data.
+ Apply small improvements where convenient.
+ Replace "aggregate" with "aggregated" where possible.
+ To lower probability of any future typos in variable names.
+ Avoid calling Set Numeric Frame Sizes twice.
+ Code formatting, keyword documentation, code comments, ...
+ Add TODOs for less important code quality improvements.
- Postpone updating of methodology pages to a subsequent change.
Change-Id: I4b381e5210e69669f972326202fdcc5a2c9c923b
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: I907606b1b994e991975f887611750d23fd7f1634
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I5207153be2b3231633ee3c16ac78a099bd60893f
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
3n-aws job was recently removed which caused trending jobs to fail.
For historical reason we keep 3n-aws in trending until 180 days
period pass.
Signed-off-by: Viliam Luc <vluc@cisco.com>
Change-Id: I7b59fc4b6f1b46bf910bc540cf37dd042df9c64a
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I3d7ecad9125e3ff55c0b4e1da5cda5a1ff22d690
|
|
It defines the time period from now back to the past from which data is
raed to dataframes.
Change-Id: Ic6feeb8e7958d69aa2e39922b48e9898e09b45dd
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I5d807944b0158e51998bfc709a87d9d6c826112c
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I1c00a9b3ffa69b1a0be1d51bb72d13516293afd2
|
|
Change-Id: Ic643da296861350b4d86eaec0245c8312f3c1a35
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
+ DPDK matrix
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I473265ae1ebf08e1518a6b6e2998abdc750167d1
|
|
Change-Id: I14046fd1050f130d201bbe81a72e48ad4fd10057
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
The previous path computation code was only correct
for tests with DUT (and TG).
There, we only want to filter by DUT NICs, but not TG NICs
(e.g. to allow testing E810 DUT with MLX TG).
But for tests without DUT (still with TG),
we do indeed want to filter by NICs on TG, so this patch does that.
Change-Id: Ia482c6327af7bca26353ad6e503ae224d90cb3a4
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ifd90f6b77f49e2a6907262d6f1e3da19ef275ac6
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Iad492c1a848052de4e5a7cb50dd3312d25234e2e
|
|
Change-Id: If6d3461a2712a6854e3d80d8ac04329f2debd029
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I0c0069a37783658099fb11d7fa15f45b6d0dc3cd
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I47781b9d0cf6c08d12ac36774b9093c3934d9ee6
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ibea233e89ef87b684adba65ad3a4a13524d32809
|
|
Change-Id: I323e6743ed3f77b552b0556806ad8d7a4ba5675c
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
- not needed
Change-Id: Ic2bc74af1574e766c007f310f626c2e9ba61bbc1
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Id065f8ecd0571567f1f679bdd70c46794fc71a94
|
|
Change-Id: I7ddfb7afd62f4a30c4f5c0ebc1df86d32354b2cd
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I150d6b79f869734385204a2236fe8608474a213d
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I4d850985bafc00594c61e5cf1c2ece2be6a90b1f
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: Ib08b31b6dda79c66f4d204145a1b2ed78e9636b4
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Icc0fd99492c75ce41104c70cc5df279949c8265e
|
|
Change-Id: I5394b562be7991ab268521362270e0771a6528af
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Viliam Luc <vluc@cisco.com>
Change-Id: I4b12f8e49a473ff54ca30d9ed3f02798136c6971
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I8ffe4311a67790066fd82a5ac6c3661e95533693
|
|
Change-Id: I235f78d1e7fab94114958dee8aba004bee6b6b03
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I412eb8aba84919e2cb4aae670b6b856da4bb27d6
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: Ibb83c43162db9c90f816faa2572187a69bb8a0b3
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ic0c02c3bce4544597c8ee49e1f0b8629ad1dd24f
|
|
Change-Id: Ib3fce8f8f011b50919c1abebed21c7e962913650
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I992ac4f2a4ecfa779c9fbf393a2f4dfa8cea704f
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I7880e58b2b97b1c365da7755784d3f93e85568cc
|
|
Change-Id: I017bcc3ef9e9ceb4e8110c8d58a5f4ef1e46db15
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I2614c5688697f4b58c523cc8abe2aa34c11730a1
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I54e3992f81db04c7c978b2157dafd067de917664
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I2829b5931e5a63a33f524e1d14ffb20c27f4ce5a
|
|
Change-Id: Ic8b6974727fce46c840ac8d2f55ee7f3670b6f34
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Change-Id: I65c1a4a229869166c256aa320a54a74669519959
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ieea41e7bbdb6f185c349736a4d0bc0d27fdfa42a
|
|
This reverts commit 22bfd741614145d86751df2d61ff77af9db63627.
Reason for revert: OMFG this patch is causing 90% perf degradation on AWS
Change-Id: Id081f61ae849678b6b877fbf03309c4b1b0c6df6
Signed-off-by: Peter Mikus <pmikus@cisco.com>
|
|
Change-Id: Ia0cf83c3aa789ce5a0a9e0c1b8d86144226827a7
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|