Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Iebd62fd6b0c798f7b4dd1f3b093c156e533b3900
Signed-off-by: Jan Gelety <jgelety@cisco.com>
|
|
Change-Id: Ic8d1080edacea1d27eb80e61f48cd4cd4430c139
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Jan Gelety <jgelety@cisco.com>
Change-Id: I2e72b7e136d3907a038cb7729c11d155a12c486f
(cherry picked from commit 9e2e4eaa2c6854eee47f7057d16b75339f453f89)
|
|
+ Update rst documentation for bash style
+ Command substitution:
+ Clarify when to use backticks.
+ Recommend avoiding nested command substitution.
+ Do not recommend putting command substitution results into quotes.
+ Function definition content:
+ Move "set -exuo pipefail" after comment only blocks.
+ Other set flags allowed for functions with good reasons.
+ Apply the new recommendations.
- Blank lines unified in code but no written recommendation in rst.
+ Add missing references to functions called, variables read or set.
+ Add TODOs to where lists would be long.
+ Minor improvements to function descriptions.
+ Make "if" expressions more python-like.
+ Add missing "|| die" (or "|| true") where spotted.
+ Downgrade DEFAULT_NIC to a local variable.
+ Add TODO to list reasons for blacklisted tags.
Change-Id: I05dce030a8c2cb1b3a242d8b977e8fe150d8ee20
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: I569b089b711f89fecca8dd31d6906ef311982877
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|