Age | Commit message (Collapse) | Author | Files | Lines |
|
The previous code assumes each tox script is a checker.
We want to add fixer scripts (not voting but editing) soon.
This is the less interesting part of the process,
renaming things and updating comments.
Includes some basic descriptions of how fixers differ from checkers.
Change-Id: I1ca1572a328acd02b41dcf4e70d7cb3746a03b03
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I0a84ce88b318c488ba2d519b20237c88b9f9f1e6
|
|
Change-Id: Id80b5611bb9a5d4398d4b2d00e92cda469949607
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Compute Bandwidth keyword returns value in Gbps,
as that is convenient for test messages.
Export Search Bound keyword expects value in bps,
as that is convenient for JSON export.
While the conversion was present in
Display Single PPS Bound keyword, it was missing from
Display Single CPS Bound keyword. Now added.
Change-Id: I5bb5934beeecfa2ee1b77dd1b1bfc788d034c845
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
This is just to make the subsequent fix more readable.
Change-Id: I7cebcaed3f658cd026f05713ea2f94dce60786c0
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
+ print testpmd and l3fwd pid after start
Testpmd and l3fwd utility can be started but link might not be
ready yet. This fix start the utility on all DUTs and do the
check later.
Signed-off-by: Viliam Luc <vluc@cisco.com>
Change-Id: If476e22f206d9a6a0dd399879a88eafedca92bb6
|
|
The test scenario is about two private networks which communication was
protected by ipsec.
The test suites are to show performance impovement about ipsec esp flow
lookup that offloaded by NIC flow director and rss.
Verified on 3n-clx and Intel E810 NIC environment, with 64B ipsec packet
flow, performance improved ~31% with 1C2T, ~110% with 2C4T, ~250% with 4C8T.
Signed-off-by: xinfeng zhao <xinfengx.zhao@intel.com>
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
Change-Id: I30aec8c5115e5a6fbef88c11d1bef2624029d1b9
|
|
Some tests (bonding) are failing as VPP refuses startup.conf.
That is because the config parameter support has been removed:
https://gerrit.fd.io/r/c/vpp/+/34822
That is VPP commit 8c8531c15c9195c2c82695eff6e70887de67fd88.
According to commit message, it was just a workaround
for Cisco ENIC cards, which are no longer tested in CSIT.
+ Delete 1 robot and 1 python keyword as they become unused.
Change-Id: If53e324a27cfbd4659e49ab8bcd03253642dde96
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Iba133914882485191ad962e36fae70b6fda0af98
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ie358593f9977d04aca9e50a14e0d14158e1b0cf1
|
|
Previous change did not consider TCP_PPS and TCP_CPS robot tags
are used by two different suite types (hoststack or ASTF).
This fixes the unintended impact on hoststack.
+ Add HOSTSTACK tag to VSAP suites.
- They could also get VSAP tag, but not needed for this Change.
Fixes: 1daa6fdc0bae284dee1b61f34534e59b60b7526a
Change-Id: Ic583b5ae336c9b74794706fefc232f221a243c87
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I53226ff6a345ac99c1e2e110712b2ff6197efe95
|
|
Signed-off-by: Cui,Cheng <cheng.cui@intel.com>
Change-Id: I71e257e5f16a887a40ff83d782a9ebdee9d05c34
Signed-off-by: Cui,Cheng <cheng.cui@intel.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I80f9f32f10d46eccf1157949a184ec4467d071cd
|
|
The tarball is unnecessarily big, remove superflous directories.
Change-Id: I55f6fae64973cfac34a1dc18cbdc688cd416e8b9
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I60313cd62a878bb713832f14121a938a81c954ed
|
|
- This is actually bug not a feature.
- AB to be added later
- Tested on TREX and iPerf3
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ib6f2d13e3b9401a9fb5759e42a8a310ee11b9d41
|
|
The implementation of GTPU offload rx is to use ip4_gtpu flow MARK action
of NIC and vpp flow REDIRECT_TO_NODE and BUFFER_ADVANCE fuction to direct
received gtpu flow to gtpu4-flow-input graph node, skipped ethernet-input,
ip4-input, ip4-lookup, ip4-local, ip4-udp-lookup normal graph node
processing.
Verified on 3n-clx and Intel E810 NIC environment, single core with 64B packet,
performance improve ~33% that compare with pure software way.
Signed-off-by: xinfeng zhao <xinfengx.zhao@intel.com>
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
Change-Id: I2af4589448bdb1729e4ce206a8cf3a1239c61af8
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ife55633c620a3c762f4d939013a7f6fafb640aa6
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Id0e7d31dc1368140c2c829fb2fcab009fbbed26d
|
|
Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: Id4d84aa7268080843b099fd7ab9851234612968b
|
|
- No support for IMIX.
+ Fix a bad bug in padding (most ASTF profiles had wrong frame sizes).
+ Fix a big typo in TCP PPS profiles (s->c was not data, just RST).
+ Control transaction size via ASTF_N_DATA_FRAMES env variable.
- Default value 5 leads to transactions smaller than before.
+ It ensures transaction is one burst (per direction) even for jumbo.
+ Edit autogen to set supported frame sizes based on suite id.
+ Both TCP and UDP use the same values:
+ 64B for CPS (exact for UDP, nominal for TCP).
+ 100B, 1518B and 9000B for TPUT and PPS.
- TCP TPUT achievable minimum is 70B.
+ Used 100B to leave room for possible IPv6 ASTF tests.
+ Separate function for code reused by vpp and trex tests.
- I do not really like the new "copy and edit" approach added here.
+ But it is a quick edit, better autogen refactor is low priority.
+ Consider both established and transitory sessions as valid.
- Mostly for compatibility with 2202 behavior and to avoid ramp-ups.
- Assuming both session states have similar enough VPP CPU overhead.
+ Added a TODO to investigate and maybe reconsider later.
+ Update the state timeout value to 240s.
+ That is the default for TCP (for transitory state).
- UDP could keep using 300s.
+ But I prefer UDP and TCP to behave as similarly as possible.
+ Use TRex tunables to get the exact frame size (for data packets).
- It is not clear why the recipe for MSS has to be this complicated.
+ Move code away from profile init, as frame size is not known there.
+ Change internal profile API, so values related to MSS are passed.
+ Lower ramp-up rate for TCP TPUT tests.
+ Because without lower rate, jumbo fails on packet loss in ramp-up.
+ UDP TPUT ramp-up rate also lowered (just to keep suites more similar).
+ Distinguish one-direction and aggregated average frame size.
+ Update keyword documentation where the distiction matters.
+ One-direction is needed for turning bandwidth limit to TPS limit.
+ Aggregated is needed for correct NDRPDR bandwidth result value.
- TCP TPUT will always be few percent below bidirectional maximum.
+ That is unavoidable, as one direction sends more control packets.
+ Add runtime consistency checks so future refactors are safer.
+ Fail if padding requested would be negative.
+ Fail if suite claims unexpected values for packets per transaction.
+ Edit the 4 types of ASTF profiles to keep them similar to each other.
+ Move UDP TPUT limit value from a field back to direct argument.
+ Stop pretending first UDP packet is not data.
+ Apply small improvements where convenient.
+ Replace "aggregate" with "aggregated" where possible.
+ To lower probability of any future typos in variable names.
+ Avoid calling Set Numeric Frame Sizes twice.
+ Code formatting, keyword documentation, code comments, ...
+ Add TODOs for less important code quality improvements.
- Postpone updating of methodology pages to a subsequent change.
Change-Id: I4b381e5210e69669f972326202fdcc5a2c9c923b
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
The previous path computation code was only correct
for tests with DUT (and TG).
There, we only want to filter by DUT NICs, but not TG NICs
(e.g. to allow testing E810 DUT with MLX TG).
But for tests without DUT (still with TG),
we do indeed want to filter by NICs on TG, so this patch does that.
Change-Id: Ia482c6327af7bca26353ad6e503ae224d90cb3a4
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I2829b5931e5a63a33f524e1d14ffb20c27f4ce5a
|
|
This reverts commit 22bfd741614145d86751df2d61ff77af9db63627.
Reason for revert: OMFG this patch is causing 90% perf degradation on AWS
Change-Id: Id081f61ae849678b6b877fbf03309c4b1b0c6df6
Signed-off-by: Peter Mikus <pmikus@cisco.com>
|
|
- Robot framework logs contain 'show pci' output from VPP
that is truncated due to the VPP cli pager. Add UNIX cli-no-pager
configuration to the default startup config to fix this issue.
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I80f2cd045063245098f22eb638a9796c5031fecf
|
|
Update ansible, topologies, bash scripts and job specs.
Change-Id: I834b991f281e0b29b4af9dc37fe8028460298d83
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I12d2d58de01693b18628cd73b5d8c36467506f32
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I5f68fd84a9ea034c5d8ff175807033aa0b60d5a2
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I8af9bae81ec83a3195ae83febd978882ebc2474d
|
|
After the previous fix, the code was not straightforward enough.
Change-Id: I4e2d872b3f86de2868d947ad038b5f0f2c7eebd7
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
+ Unify the order of interfaces, along 0-->1 path.
Ticket: CSIT-1806
Fixes: 14a71b74b414df7616ccb5ada3d50ecb90d96bae
Change-Id: Ia20d05b4e16daf60260fcbaea806406fa654a94e
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
- Printing large sets makes no sense.
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ia4bf411368ca2424ad313b8e7bb0fb76cb175988
|
|
The previous grep was too strict about test message.
Change-Id: Ib0c120a32d205b905f257e5b3c948a309ed8abb2
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: Ic1949c46aa339e66a47a0ebbc428499c5cf9305e
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
+ Keep support for VPP 22.02 CLI output.
+ Keep tolerating "timed out" sessions for 2202 output.
+ Subtract timed-out sessions for post-2202 output.
+ Explain the logic differences in docstring.
+ Convert the return value to int.
Change-Id: I8a119e1034848bfd0fb131cb633e2441b44634a2
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
The previous code leads to warnings from Robot.
Change-Id: I323f2abb277ae26d43ee5540a3b21e01a8dd9ef1
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Previously, only x710 was generated, but ICX has xxv710 instead.
Nic drivers (tap or vhost) remain hardcoded.
Change-Id: I0ed3abb60258d74622995a8910f67ae4500ace56
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I0e659937440e9ff7070f0d13b7a1db99f27cf2bb
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I0cfc9d9fbb1a82a308231a5d2c0b12cb632c469b
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ic676d00bd7d3d5d8c244bfd0eb7b10bc74498505
|
|
The function get_pci_addr could check a different PCI_ADDR in case the
netdev device directory doesn't exit. Move the check so that it always
uses the proper PCI_ADDR and add a failure case when the netdev device
directory doesn't exist.
Change-Id: Ibadfea3fba34509cd3ea8f906ac5962c0f01dd17
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
|
|
Change-Id: I82bc5cd69de82a2d6b6689cf3380f667ea905886
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
- UTI export breaks local execution
- disabling useless tox rules
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I2f610b08f06f437e4482f291fa7b47cbb7b92984
|
|
Replace the hardcoded SPD inbound/outbound ranges with values derived
from test inputs.
Add the necessary routes now that the tunnel endpoints are not in the
same subnet. Also add ip neighbor entry on DUT2 for the same reason.
Also replace ipsec sa dump with show ipsec all in teardown of tests
where both SAs and SPDs are configured to improve troubleshooting.
Change-Id: I7d89a99fcf457a701c87bf6ac07364b62802677d
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
|
|
Change-Id: Id3975dfcca0040b799f31dcd14789d8c90993b14
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Part of fixing chain
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ie423ccf5a51751e605d906dd1214f5174bb364ac
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ia5a097797b54c2e71acdcc8d72706e5540536252
|
|
Part of fixing chain after early merge.
Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I06e19def003575993bc3d97c0dc7fbedd3e5ff7a
|
|
Part of fixing chain after early merge.
Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I983b3036a388656bbad91aba71cf14b503f875bd
|