Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: pmikus <peter.mikus@protonmail.ch>
Change-Id: Ib93dc1552945fe91ab5346b9b759d56c7468debf
|
|
Change-Id: If7e00460fee4eee50479dc089c026670dcf3edf9
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
- fix ip6 scale tag
- unified order of tags
Signed-off-by: Viliam Luc <vluc@cisco.com>
Change-Id: I173bd8369167f07a118f607a9c1957e354f772b2
|
|
+ Delete nat44 pps suites.
+ Rename ip4base suites, testcases, suite tags (also tg) to -tput.
+ Also robot tags like UDP_PPS and TCP_PPS.
- Keep traffic types and traffic profile names with pps.
+ They can be renamed in a different change if needed.
+ Update job specs.
- Do not update methodology yet (avoid conflict with another Change).
Ticket: CSIT-1829
Change-Id: Ic0dac441f6e8253edce88e057ab7fad1d3814c24
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
- No support for IMIX.
+ Fix a bad bug in padding (most ASTF profiles had wrong frame sizes).
+ Fix a big typo in TCP PPS profiles (s->c was not data, just RST).
+ Control transaction size via ASTF_N_DATA_FRAMES env variable.
- Default value 5 leads to transactions smaller than before.
+ It ensures transaction is one burst (per direction) even for jumbo.
+ Edit autogen to set supported frame sizes based on suite id.
+ Both TCP and UDP use the same values:
+ 64B for CPS (exact for UDP, nominal for TCP).
+ 100B, 1518B and 9000B for TPUT and PPS.
- TCP TPUT achievable minimum is 70B.
+ Used 100B to leave room for possible IPv6 ASTF tests.
+ Separate function for code reused by vpp and trex tests.
- I do not really like the new "copy and edit" approach added here.
+ But it is a quick edit, better autogen refactor is low priority.
+ Consider both established and transitory sessions as valid.
- Mostly for compatibility with 2202 behavior and to avoid ramp-ups.
- Assuming both session states have similar enough VPP CPU overhead.
+ Added a TODO to investigate and maybe reconsider later.
+ Update the state timeout value to 240s.
+ That is the default for TCP (for transitory state).
- UDP could keep using 300s.
+ But I prefer UDP and TCP to behave as similarly as possible.
+ Use TRex tunables to get the exact frame size (for data packets).
- It is not clear why the recipe for MSS has to be this complicated.
+ Move code away from profile init, as frame size is not known there.
+ Change internal profile API, so values related to MSS are passed.
+ Lower ramp-up rate for TCP TPUT tests.
+ Because without lower rate, jumbo fails on packet loss in ramp-up.
+ UDP TPUT ramp-up rate also lowered (just to keep suites more similar).
+ Distinguish one-direction and aggregated average frame size.
+ Update keyword documentation where the distiction matters.
+ One-direction is needed for turning bandwidth limit to TPS limit.
+ Aggregated is needed for correct NDRPDR bandwidth result value.
- TCP TPUT will always be few percent below bidirectional maximum.
+ That is unavoidable, as one direction sends more control packets.
+ Add runtime consistency checks so future refactors are safer.
+ Fail if padding requested would be negative.
+ Fail if suite claims unexpected values for packets per transaction.
+ Edit the 4 types of ASTF profiles to keep them similar to each other.
+ Move UDP TPUT limit value from a field back to direct argument.
+ Stop pretending first UDP packet is not data.
+ Apply small improvements where convenient.
+ Replace "aggregate" with "aggregated" where possible.
+ To lower probability of any future typos in variable names.
+ Avoid calling Set Numeric Frame Sizes twice.
+ Code formatting, keyword documentation, code comments, ...
+ Add TODOs for less important code quality improvements.
- Postpone updating of methodology pages to a subsequent change.
Change-Id: I4b381e5210e69669f972326202fdcc5a2c9c923b
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I2829b5931e5a63a33f524e1d14ffb20c27f4ce5a
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I12d2d58de01693b18628cd73b5d8c36467506f32
|
|
+ Model version 1.0.0.
- Only some result types are exported.
+ MRR, NDRPDR and SOAK.
- Other result types to be added later.
+ In contrast, all test types are detected.
+ Convert custom classes to JSON-serializable equivalents.
+ Sort dict keys before converting to JSON.
+ Override the order for some known keys.
+ Export sets as sorted arrays.
+ Convert to info content from serialized raw content.
+ Also export outputs for suite setups and teardowns.
+ Info files for setup/teardown exist only temporarily.
+ The data is merged into suite.info.json file.
+ This simplifies presentation of total suite duration.
+ Define model via JSON schema:
- Just test case, suite setup/teardown/suite to be added later.
- Just info, raw to be added later.
+ Proper descriptions.
+ Json is generated from yaml.
+ This is a convenience for maintainers.
+ The officially used schema is the .json one.
+ TODOs written into a separate .txt file.
+ Validate exported instance against the schema.
+ Include format checking.
+ Update CSIT requirements for validation dependencies.
+ This needs python-dateutil==2.8.2, only a patch bump.
+ Compute bandwidth also for soak tests.
+ This unifies with NDRPDR to simplify schema definition.
- PAL may need an update for parsing soak test message.
+ Include SSH log items, raw output only.
+ Generate all outputs in a single filesystem tree.
+ Move raw outputs into test_output_raw.tar.xz.
+ Rename existing tar with suites to generated_robot_files.tar.xz.
Change-Id: I69ff7b330ed1a14dc435fd0ef008e753c0d7f78c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
When building documentation using sphinx we see ~1200 similar warnings [0]
[0] - https://s3-logs.fd.io/vex-yul-rot-jenkins-1/csit-verify-tox-master-ubuntu2004-x86_64/3289/doc_verify.log.gz
These warning are harmless and can be fixed later
Signed-off-by: Viliam Luc <vluc@cisco.com>
Change-Id: I1ac1099d38935971d47491dde905715345d3935c
|
|
If ./{filename} does not execute, {filename} should not be flagged as executable.
No .robot file is executable.
Change-Id: I7add9d223ad0e587bc041a4cca6bac222a89e078
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: I96a031aaf246c2f79c9d90c04038a51915ded4ea
Signed-off-by: Viliam Luc <vluc@cisco.com>
|
|
Change-Id: I2193cc971a827d73965695c251fb00496fe3d2c7
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: Iee3c8ce2079e58da400e52dc4cf6633f90a71f57
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: I911e121475221fbf5449ed49dc6236caf13742b0
Signed-off-by: Viliam Luc <vluc@cisco.com>
|
|
Change-Id: I9d028294deb1e31b6d185deb1c7523e0226a0ada
Signed-off-by: Viliam Luc <vluc@cisco.com>
|