Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Peter Mikus <peter.mikus@protonmail.ch>
Change-Id: I84d9cf2892423e62b116b07982d3e87120b66271
|
|
Two reasons.
Most importantly, executor image creation scripts
will now see the pylint version used in tox job.
Additionally, this makes it easier for people
to run pylint locally (without checking all files as tox does).
Change-Id: I89f1d428e676e27d6f35c79ca9c22224c4c99a3e
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Pylint version bumped to 3.0.1.
Upgrade is needed, because the old version
has only a limited understanding of type hints
and data classes (leading to many false errors).
Config values are simplified,
only few old customizations are kept.
Notably, max line length is increased to 88
(only here, not in other checkers).
Change-Id: I70802a32693a8f21515b9093b12e292f88ee9e3f
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: pmikus <peter.mikus@protonmail.ch>
Change-Id: Ia13e920ef11d364893a51957778e60084f4ac0f9
|
|
Signed-off-by: pmikus <peter.mikus@protonmail.ch>
Change-Id: I461899d72e92e5c5db9f64261206ec0e6704e0c8
|
|
The previous code assumes each tox script is a checker.
We want to add fixer scripts (not voting but editing) soon.
This is the less interesting part of the process,
renaming things and updating comments.
Includes some basic descriptions of how fixers differ from checkers.
Change-Id: I1ca1572a328acd02b41dcf4e70d7cb3746a03b03
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I93e2035568527c2f68732a0c7fe1865d100831ad
|
|
+ Implementation stub so checker can check already.
+ Also add documentation stub for the implemented model.
+ Checker checks also for bumps in documentation version.
- Not comparing implementation and documentation version yet.
Change-Id: I4d19c00315a1c171de325c4494c28f5210635f32
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
+ coverage is not used
+ naming is now covered fully by suitegen which can be
improved to do detections of packet encapsulations
Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I9631988e144d3878a6b146214e3aea75694ebf3f
|
|
Signed-off-by: pmikus <pmikus@cisco.com>
Change-Id: I81958fbf6ef240d53a0fb8708ca882baf02f606c
|
|
Change-Id: I2bbdc28431b6271d1950ec0e74bf708cae841146
Signed-off-by: Tibor Frank <tifrank@cisco.com>
|
|
Just stylistic improvements, no functional change.
+ Use "ignore_outcome = true" instead of "|| true".
+ Document and apply recommended ordering within testenv definition.
+ Fix some typos.
Change-Id: I004f12fbdf6dbeb555daa7cd111938b7eeef20b3
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
A common mistage is to add a file into GPL directory,
with Apache license only.
This adds a tox checker to vote -1 on such changes,
gpl_license.log contains the list of affected files.
There are TODOs related to unlicensed files
or unconventional GPL licenses.
Change-Id: I267e4fb98afd199d5acc7d211068b28c97b31dc9
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: I9368557aed7508d9401628c0ddfda475da42bc99
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Only added/edited files already containing copyright notice
are checked for the correct year (and only if in first 3 lines).
Change-Id: I22c057431847fda3a7dfd4577f8346fadfe4c4f6
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: I8d8619f5a0b7ec7ee45b85ef78ff6bb8e9ea88a1
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
- Install via PIP3
- Use virtualenv Python3 interpret
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Iad22b344b418a1d91774d23d5ea17bfd48d394b3
|
|
- We get to 0
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: I5c079248c1fc2383c399e5034aa46b570c5c1dce
|
|
Signed-off-by: Peter Mikus <pmikus@cisco.com>
Change-Id: Ifa4de8e60742f5c4cf4c2f377692313e23f9983b
|
|
- force a python2 environment in tox for pylint
- let pylint load some compiled modules for member checking
- allow locally enabled pylint rules
- ignore bad enum names
- ignore complexity for code to be refactored by other tickets
- broad excepts are acceptable sometimes
Signed-off-by: Miroslav Los <miroslav.los@pantheon.tech>
Change-Id: If4c3a1b85e8609f074e1de8ce91fc9c4fedbeb38
|
|
Change-Id: Ib4585729f7b84bbcf1db62db801a6b2f24337803
Signed-off-by: Peter Mikus <pmikus@cisco.com>
|
|
Change-Id: I038d90fc481e5f74085d0fe6165b12769d98e8a1
Signed-off-by: Peter Mikus <pmikus@cisco.com>
|
|
Caring about per-file notices is too distracting.
Change-Id: I3f07a9fd1d3a4350135dd3d14f4944647af39a0b
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
+ Only looks at files edited since HEAD~.
+ Only checks files of whitelisted extensions.
+ Distinguishes missing and outdated copyrights.
+ Any line with "Copyright" substring can work.
+ Many copyright lines are tolerated, if at least one has correct year.
+ Voting.
Change-Id: I2cda0459cb191eeec7aada69c508973568039d87
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
+ All perf suites updated, as autogen change is backward incompatible.
+ Only x710 -ndrpdr suites remain in git repository.
+ Removed retry feature of run_tests.
+ Renamed topology_type and traffic_type to traffic_profile.
+ Renamed framesize to frame_size; nic_model to nic_name.
+ Reordered Variables table to start with nic_name and overhead.
+ Fixed wrong overhead value in some cbc-sha1 suites.
+ Fixed some suite tags.
++ Introduced tags to distinguish suites, such as IPSECINT.
+ Bound crypto hardware to NIC name.
+ Implemented NIC limit hiding.
+ Also search and teardown related arguments are now hidden.
+ Main measurement keywords updated to new arg handling.
+ Max rate related keywords moved to performance_limits.robot
+ Teardowns unified.
+ Generated tests are archived.
++ Generated directory is .gitignore-d.
+ Regenerator raises an exception on seeing non-compatible suite.
++ Relatively helpful message should be seen in exception.
+ Suite and template Documentation has generated parts.
+- With short NIC names only.
+ Autogen checker also upgraded.
+ Tag expressions replaced with long files to ensure analogous tests.
Change-Id: I60e9a999187e7da1f60d0eb4fb02afa14682aa46
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
Change-Id: Ieeb54f3e3cb413f15dfbf6595211fd7158aa1e1a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
- Still non-voting, but useful.
Change-Id: Idd6f345f0f14fdbc237ff66f5e010801ea08dc5b
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|
|
The plan is to change csit-validate-pylint-master job
to fail if (and only if) tox fails.
This will allow us to easily add checks,
with or without the voting power.
Each check produces log (ignored in .gitignore)
the voting job can archive.
+ Made autogen quiet by default, to avoid spam in autogen checker.
+ Unified the way direct csit subdirectories are git-ignored.
Change-Id: I6477b1ef7da6d3e30f68c5850d04900cc52f431e
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
|