aboutsummaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorOndrej Fabry <ofabry@cisco.com>2018-08-22 06:07:04 +0200
committerOndrej Fabry <ofabry@cisco.com>2018-08-22 06:07:04 +0200
commit892683bef86cacc2ccda2b4df2b079171bd92164 (patch)
treebb27f2abca3b1998ac808874d4759ff81b9c83dc /core
parent08ddeac03fd3832d44a3dfb48ee85ecd95d2b388 (diff)
Show VPPApiError value always and remove RegisterBinAPITypes for mock adapter
Change-Id: I3b216748df1a372f25cc94e3df5d7b1b2b7a8a40 Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Diffstat (limited to 'core')
-rw-r--r--core/channel.go5
-rw-r--r--core/channel_test.go2
2 files changed, 3 insertions, 4 deletions
diff --git a/core/channel.go b/core/channel.go
index 5f7763e..718f89c 100644
--- a/core/channel.go
+++ b/core/channel.go
@@ -261,9 +261,8 @@ func (ch *channel) processReply(reply *vppReply, expSeqNum uint16, msg api.Messa
if strings.HasSuffix(msg.GetMessageName(), "_reply") {
// TODO: use categories for messages to avoid checking message name
if f := reflect.Indirect(reflect.ValueOf(msg)).FieldByName("Retval"); f.IsValid() {
- if retval := f.Int(); retval != 0 {
- err = api.VPPApiError(retval)
- }
+ retval := int32(f.Int())
+ err = api.RetvalToVPPApiError(retval)
}
}
diff --git a/core/channel_test.go b/core/channel_test.go
index 197dda4..4a9ab2b 100644
--- a/core/channel_test.go
+++ b/core/channel_test.go
@@ -37,7 +37,7 @@ func setupTest(t *testing.T) *testCtx {
RegisterTestingT(t)
ctx := &testCtx{
- mockVpp: &mock.VppAdapter{},
+ mockVpp: mock.NewVppAdapter(),
}
var err error