summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLuca Muscariello <muscariello@ieee.org>2022-10-19 17:51:12 +0200
committerLuca Muscariello <muscariello@ieee.org>2022-10-19 18:07:34 +0200
commit7b3426fb129f41ca05353b5e1dd66264a3a96d0f (patch)
treead1d9795f1b2130112b9bb8a14c68703b5b0940d
parentd00ad4c5c437fd10c850bc073f94d2b790926b1d (diff)
fix(sonar): False positives Identical sub-expressions on both sides of operator
Ref: HICN-816 Signed-off-by: Luca Muscariello <muscariello@ieee.org> Change-Id: Ifdbcad287f89378dc2a35110fac01dba9c341ef9
-rw-r--r--hicn-light/src/hicn/test/test-loop.cc2
-rw-r--r--libtransport/src/core/udp_connector.cc4
-rw-r--r--libtransport/src/protocols/fec/fec.cc4
3 files changed, 5 insertions, 5 deletions
diff --git a/hicn-light/src/hicn/test/test-loop.cc b/hicn-light/src/hicn/test/test-loop.cc
index 0ebf7a22a..71635c929 100644
--- a/hicn-light/src/hicn/test/test-loop.cc
+++ b/hicn-light/src/hicn/test/test-loop.cc
@@ -121,7 +121,7 @@ class LoopTest : public ::testing::Test {
int client_fd =
accept(test->connection_socket_, (struct sockaddr *)(&addr), &addr_len);
if (client_fd == -1) {
- if (errno != EAGAIN && errno != EWOULDBLOCK) {
+ if (errno != EAGAIN && errno != EWOULDBLOCK) { // NOSONAR
fprintf(stderr, "accept failed");
}
diff --git a/libtransport/src/core/udp_connector.cc b/libtransport/src/core/udp_connector.cc
index 7d059dd9d..5f620b1a8 100644
--- a/libtransport/src/core/udp_connector.cc
+++ b/libtransport/src/core/udp_connector.cc
@@ -181,7 +181,7 @@ void UdpTunnelConnector::writeHandler() {
while (retval--) {
output_buffer_.pop_front();
}
- } else if (errno != EWOULDBLOCK && errno != EAGAIN) {
+ } else if (errno != EWOULDBLOCK && errno != EAGAIN) { // NOSONAR
LOG(ERROR) << "Error sending messages: " << strerror(errno);
sent_callback_(this, make_error_code(core_error::send_failed));
return;
@@ -222,7 +222,7 @@ void UdpTunnelConnector::readHandler(const std::error_code &ec) {
int res = recvmmsg(socket_->native_handle(), rx_msgs_ + current_position_,
max_burst - current_position_, MSG_DONTWAIT, nullptr);
if (res < 0) {
- if (errno == EWOULDBLOCK || errno == EAGAIN) {
+ if (errno == EWOULDBLOCK || errno == EAGAIN) { // NOSONAR
// Try again later
return;
}
diff --git a/libtransport/src/protocols/fec/fec.cc b/libtransport/src/protocols/fec/fec.cc
index 5881d4d92..d2105eb53 100644
--- a/libtransport/src/protocols/fec/fec.cc
+++ b/libtransport/src/protocols/fec/fec.cc
@@ -614,7 +614,7 @@ void fec_encode(struct fec_parms *code, gf *src[], gf *fec, int index, int sz) {
int i, k = code->k;
gf *p;
- if (GF_BITS > 8) sz /= 2;
+ if (GF_BITS > 8) sz /= 2; // NOSONAR
if (index < k)
memcpy(fec, src[index], sz * sizeof(gf));
@@ -698,7 +698,7 @@ int fec_decode(struct fec_parms *code, gf *pkt[], int index[], int sz) {
int row, col, k = code->k;
int i = 0;
- if (GF_BITS > 8) sz /= 2;
+ if (GF_BITS > 8) sz /= 2; // NOSONAR
if (shuffle(pkt, index, k)) /* error if true */
return 1;