aboutsummaryrefslogtreecommitdiffstats
path: root/hicn-plugin
AgeCommit message (Collapse)AuthorFilesLines
2023-01-20fix(hicn-plugin): handle inflight interest coming from deleted faceMauro Sardara4-46/+115
Ticket: HICN-830 Change-Id: I14ed32bba2b07575ee604850080309706eb8ce85 Signed-off-by: Mauro Sardara <msardara@cisco.com> (cherry picked from commit 64fa723904d35eda3406058469b890a39c3f628c)
2023-01-20feat: implement set strategy API for hicn-pluginMauro Sardara6-176/+164
Ticket: HICN-829 Change-Id: I3dabc38e9cc2e06ebed14b9ed265d027f77b7e5f Signed-off-by: Mauro Sardara <msardara@cisco.com> (cherry picked from commit da0d60997bce1e40cc0b1c7b7f4f58df56bbead3)
2023-01-20fix: interest aggregationMauro Sardara2-40/+66
Interests processed in the same vector were not aggregated properly. Ticket: HICN-827 Change-Id: I9aa83e8689ec11642525fd3406972f1b2dea4d8f Signed-off-by: Mauro Sardara <msardara@cisco.com>
2023-01-20Merge "fix: correctly set next node for ifaces and faces"Mauro Sardara8-71/+67
2023-01-20fix: correctly set next node for ifaces and facesMauro Sardara8-71/+67
Ticket: HICN-828 Change-Id: I7853bc37e34ca4f2303a537396aef4cb8b06ec98 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2023-01-20feat(vpp): improve tracingMauro Sardara2-2/+6
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Ic20b5cc7f34b35c86b6c100f9a7c868b119bd129
2023-01-18fix: correctly print fib prefixesMauro Sardara1-3/+3
Change-Id: Icd00882577be78fe8996f53f737d87d5c8e2da99 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2023-01-17feat: local-remote strategyMauro Sardara23-183/+586
Ticket: HICN-824 Change-Id: Iea285cb499b13c943a142fa39328ee36c91ae913 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2023-01-10feat: upgrade to VPP 22.10v22.10-rc0Mauro Sardara14-203/+582
Change-Id: I556bd8c44f0ff7a631a0df34b498ffd7952fcf4a Signed-off-by: Mauro Sardara <msardara@cisco.com>
2022-09-30feat: support for new packet format in hicn-lightJordan Augé3-15/+5
Ref: HICN-792 Change-Id: I3204006bd2dd2be6504c33035c6578ec0292455a Signed-off-by: Jordan Augé <jordan.auge+fdio@cisco.com>
2022-09-26chore(hicn-plugin): install hicn.api.jsonMauro Sardara1-0/+5
The hicn.api.json is currently used by govpp/vapi_c_gen/vapi_cpp_gen etc. to generate the APIs to configure the hicn plugin. It should be installed in the system as external component may require it to generate the api, as in the govpp case (cf https://github.com/FDio/govpp/tree/master/binapi). The hicn.api.son file will be installed with the rest of the plugins API (share/vpp/api/plugins) Ticket: HICN-797 Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Ief7f0010a718efd272e260552f2f2d1428fac486
2022-09-12fix(interest_manifest.h): set correct type to pos variable when using it in ↵Mauro Sardara1-1/+1
interest_manifest_foreach_suffix Ref: HICN-780 Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I6025c3e87d4d8cb6a1e5e1f68e856214f8aa81ed
2022-09-02fix(sonar): make sonarqube happyMauro Sardara3-5/+22
Ref: HICN-766 HICN-767 HICN-764 HICN-762 HICN-743 HICN-759 HICN-760 HICN-758 HICN-761 HICN-756 Change-Id: Ic2accf6b6771c7a78d2b22d9bdb8e5a5be9ead8a Signed-off-by: Mauro Sardara <msardara@cisco.com>
2022-09-01feat(hicn-plugin): interest manifestMauro Sardara9-56/+421
Ref: HICN-748 Change-Id: Ie403de53a93094dca997cec379db6f5d3ce8e6be Signed-off-by: Mauro Sardara <msardara@cisco.com>
2022-08-26feat: resize hicn_buffer_t to 24 byesMauro Sardara2-16/+16
Ref: HICN-746 Change-Id: I70d526aa81c158a128408cff7e7a2d8e09ceb01a Signed-off-by: Mauro Sardara <msardara@cisco.com>
2022-08-10feat: add interest manifest serialization/deserializationMauro Sardara3-0/+17
Also: add helpers for interest manifest Ref: HICN-738 Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Ia531605148e00ccbe446da0f4f2d8caae2b098be Signed-off-by: Mauro Sardara <msardara@cisco.com>
2022-08-04feat: Due to the deep modifications related to names and packet format,Luca Muscariello18-193/+258
this task cover a large part of the codebase and involves several changes: - the library provides a name data structure (hicn_name_t ), which is composed of a name prefix (hicn_name_prefix_t) and a name suffix (hicn_name_suffix_t), and it has been extended to provide all support functions required for name manipulation, including common prefix computation, as required for the Longest Prefix Match (LPM)in the forwarder, in addition to Exact Prefix Match (EPM). - all code has been rewritten to use this data structure instead of having for instance the forwarder define its own name class (used to be Name and NameBitVector) the code has been refactored to minimize name allocations and copies, one remaining aspect is the difference of name storage between PIT and CS entries (respectively in the PIT entry, and in the message buffer), which causes the packet cache index to be updated when a PIT entry is converted into a CS entry. By storing the name in the PIT/CS entry everytime, we might save on this operation). - hicn-light FIB has been rewritten : code has been refactored and should now be shorter and documented; unit tests have been drafted but more would be required to cover all cases and match the algorithms to add/remove nodes, as specified in the doc. all protocol details and hICN header formats are now abstracted by the library for the forwarder (and thus header.h and  protocols/*.h have been removed from public includes, and replaced by packet.h providing protocol agnostic packet level functions, completely replacing the compat.h header that used to provide similar functions. - this works by exposing a opaque buffer to the application (a kind of socket buffer) which is used by the lib to cache the packet format and offsets of the different layers in the buffer and provider efficient operations (the packet format is either defined for packet construction, or guessed at ingress, and this structure is updated accordingly only once). Co-authored-by: Jordan Augé <jordan.auge+fdio@cisco.com> Signed-off-by: Luca Muscariello <muscariello@ieee.org> Change-Id: I31e321897f85f0267fe8ba4720363c180564492f
2022-07-01Revision and refactor of the VPP plugin with fixes for theLuca Muscariello39-3553/+2913
packet generator. Hash table for the packet cache has been changed with the bihash. Co-authored-by: Mauro Sardara <msardara@cisco.com> Signed-off-by: Luca Muscariello <muscariello@ieee.org> Change-Id: I0e0191a9f109d37081d32cc55d577ea43533f8c0 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2022-06-30refactor(lib, hicn-light, vpp, hiperf): HICN-723Luca Muscariello25-1806/+2307
- move infra data structure into the shared lib - new packet cache using double hashing and lookup on prefix suffix - testing updates - authenticated requests using interest manifests Co-authored-by: Mauro Sardara <msardara@cisco.com> Co-authored-by: Jordan Augé <jordan.auge+fdio@cisco.com> Co-authored-by: Michele Papalini <micpapal@cisco.com> Co-authored-by: Olivier Roques <oroques+fdio@cisco.com> Co-authored-by: Enrico Loparco <eloparco@cisco.com> Change-Id: Iaddebfe6aa5279ea8553433b0f519578f6b9ccd9 Signed-off-by: Luca Muscariello <muscariello@ieee.org>
2022-04-26HICN-722: Updates on transport, RTC, manifest usage for RTC, infra.Luca Muscariello1-7/+2
Co-authored-by: Mauro Sardara <msardara@cisco.com> Co-authored-by: Jordan Augé <jordan.auge+fdio@cisco.com> Co-authored-by: Michele Papalini <micpapal@cisco.com> Co-authored-by: Angelo Mantellini <manangel@cisco.com> Co-authored-by: Jacques Samain <jsamain@cisco.com> Co-authored-by: Olivier Roques <oroques+fdio@cisco.com> Co-authored-by: Enrico Loparco <eloparco@cisco.com> Co-authored-by: Giulio Grassi <gigrassi@cisco.com> manifest: optimize manifest processing manifest: add FEC parameters to manifests manifest: refactor verification process manifest: report auth alerts in hiperf instead of aborting manifest: remove FEC buffer callback in consumer manifest: refactor and enable manifests by default manifest: update manifest header with transport parameters manifest: batch interests for first manifest from RTC producer manifest: refactor processing of RTC manifests manifest: update manifest-related socket options of consumers manifest: update unit tests for manifests manifest: pack manifest headers manifest: verify FEC packets auth: add consumer socket option to set max unverified delay manifest: process manifests after full FEC decoding manifest: manage forward jumps in RTC verifier fec: remove useless fec codes rs: add new code rate rs: add new code rate rs: add new code rate rs: add new code rate libtransport: increase internal packet cache size remove internal cisco info in cmake manifest: add option to set manifest capacity data_input_node.c: add information about adj_index[VLIB_RX] on received data packetsi sysrepo plugin: update build Change-Id: I0cf64d91bd0a1b7cad4eeaa9871f58f5f10434af Signed-off-by: Mauro Sardara <msardara@cisco.com> Signed-off-by: Luca Muscariello <muscariello@ieee.org>
2022-03-31feat: boostrap hicn 22.02Luca Muscariello103-1508/+2446
The current patch provides several new features, improvements, bug fixes and also complete rewrite of entire components. - lib The hicn packet parser has been improved with a new packet format fully based on UDP. The TCP header is still temporarily supported but the UDP header will replace completely the new hicn packet format. Improvements have been made to make sure every packet parsing operation is made via this library. The current new header can be used as header between the payload and the UDP header or as trailer in the UDP surplus area to be tested when UDP options will start to be used. - hicn-light The portable packet forwarder has been completely rewritten from scratch with the twofold objective to improve performance and code size but also to drop dependencies such as libparc which is now removed by the current implementation. - hicn control the control library is the agent that is used to program the packet forwarders via their binary API. This component has benefited from significant improvements in terms of interaction model which is now event driven and more robust to failures. - VPP plugin has been updated to support VPP 22.02 - transport Major improvement have been made to the RTC protocol, to the support of IO modules and to the security sub system. Signed manifests are the default data authenticity and integrity framework. Confidentiality can be enabled by sharing the encryption key to the prod/cons layer. The library has been tested with group key based applications such as broadcast/multicast and real-time on-line meetings with trusted server keys or MLS. - testing Unit testing has been introduced using GoogleTest. One third of the code base is covered by unit testing with priority on critical features. Functional testing has also been introduce using Docker, linux bridging and Robot Framework to define test with Less Code techniques to facilitate the extension of the coverage. Co-authored-by: Mauro Sardara <msardara@cisco.com> Co-authored-by: Jordan Augé <jordan.auge+fdio@cisco.com> Co-authored-by: Michele Papalini <micpapal@cisco.com> Co-authored-by: Angelo Mantellini <manangel@cisco.com> Co-authored-by: Jacques Samain <jsamain@cisco.com> Co-authored-by: Olivier Roques <oroques+fdio@cisco.com> Co-authored-by: Enrico Loparco <eloparco@cisco.com> Co-authored-by: Giulio Grassi <gigrassi@cisco.com> Change-Id: I75d0ef70f86d921e3ef503c99271216ff583c215 Signed-off-by: Luca Muscariello <muscariello@ieee.org> Signed-off-by: Mauro Sardara <msardara@cisco.com>
2021-07-20HICN-716 Upgrade to VPP 21.06Mauro Sardara64-1723/+1637
Also: - Format hicn-plugin code Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I0f4626fdeaf0fc5ae1f43904ca006b092e3e9d5f
2021-07-06[HICN-713] Transport Library Major Refactoring 2Mauro5-21/+18
Co-authored-by: Luca Muscariello <muscariello@ieee.org> Co-authored-by: Michele Papalini <micpapal@cisco.com> Co-authored-by: Olivier Roques <oroques+fdio@cisco.com> Co-authored-by: Giulio Grassi <gigrassi@cisco.com> Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I5b2c667bad66feb45abdb5effe22ed0f6c85d1c2
2021-04-15[HICN-690] Transport Library Major RefactoryLuca Muscariello7-11/+25
The current patch provides a major refactory of the transportlibrary. A summary of the different components that underwent major modifications is reported below. - Transport protocol updates The hierarchy of classes has been optimized to have common transport services across different transport protocols. This can allow to customize a transport protocol with new features. - A new real-time communication protocol The RTC protocol has been optimized in terms of algorithms to reduce consumer-producer synchronization latency. - A novel socket API The API has been reworked to be easier to consumer but also to have a more efficient integration in L4 proxies. - Several performance improvements A large number of performance improvements have been included in particular to make the entire stack zero-copy and optimize cache miss. - New memory buffer framework Memory management has been reworked entirely to provide a more efficient infra with a richer API. Buffers are now allocated in blocks and a single buffer holds the memory for (1) the shared_ptr control block, (2) the metadata of the packet (e.g. name, pointer to other buffers if buffer is chained and relevant offsets), and (3) the packet itself, as it is sent/received over the network. - A new slab allocator Dynamic memory allocation is now managed by a novel slab allocator that is optimised for packet processing and connection management. Memory is organized in pools of blocks all of the same size which are used during the processing of outgoing/incoming packets. When a memory block Is allocated is always taken from a global pool and when it is deallocated is returned to the pool, thus avoiding the cost of any heap allocation in the data path. - New transport connectors Consumer and producer end-points can communication either using an hicn packet forwarder or with direct connector based on shared memories or sockets. The usage of transport connectors typically for unit and funcitonal testing but may have additional usage. - Support for FEC/ECC for transport services FEC/ECC via reed solomon is supported by default and made available to transport services as a modular component. Reed solomon block codes is a default FEC model that can be replaced in a modular way by many other codes including RLNC not avaiable in this distribution. The current FEC framework support variable size padding and efficiently makes use of the infra memory buffers to avoid additiona copies. - Secure transport framework for signature computation and verification Crypto support is nativelty used in hICN for integrity and authenticity. Novel support that includes RTC has been implemented and made modular and reusable acrosso different transport protocols. - TLS - Transport layer security over hicn Point to point confidentiality is provided by integrating TLS on top of hICN reliable and non-reliable transport. The integration is common and makes a different use of the TLS record. - MLS - Messaging layer security over hicn MLS integration on top of hICN is made by using the MLSPP implemetation open sourced by Cisco. We have included instrumentation tools to deploy performance and functional tests of groups of end-points. - Android support The overall code has been heavily tested in Android environments and has received heavy lifting to better run natively in recent Android OS. Co-authored-by: Mauro Sardara <msardara@cisco.com> Co-authored-by: Michele Papalini <micpapal@cisco.com> Co-authored-by: Olivier Roques <oroques+fdio@cisco.com> Co-authored-by: Giulio Grassi <gigrassi@cisco.com> Change-Id: If477ba2fa686e6f47bdf96307ac60938766aef69 Signed-off-by: Luca Muscariello <muscariello@ieee.org>
2021-02-11[HICN-683] Add clang format for hicn-plugin.Mauro18-2218/+1929
As vpp has moved away from the dear old indent, also the hicn plugin should do the same and use clang-format. Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Iee896f3ce01cef53b1acfccbebeef66ca77add7d Signed-off-by: Mauro Sardara <msardara@cisco.com>
2021-02-10[HICN-682] Fix hicn-plugin to be compatible with version 21.01Mauro Sardara11-1031/+919
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Ia116ad74ce78e2ca2d7ee624eea75a38936d27f8 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2021-02-05[HICN-681] Remove compilation warning in ubuntu 20.04 jobs.Mauro Sardara1-2/+2
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Id9666941d2a84d5deb75716a410abe9305923531 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2020-11-23[HICN-659] Fix udp-encap inconsistenciesMauro Sardara1-22/+27
Independently of the type of tunnel, encapsulated packet can be either v6 or v4, so we need to create 2 faces for each version of the tunnel. Currently we are wrongly associating v4 tunnels with v4 packets and v6 tunnel with v6 packets. Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I81e6e4b8b71ae7949d27065cc61b1b5b23db6a8d
2020-11-20[HICN-658] Fix vapi_connect_safe.Mauro Sardara1-10/+8
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Icd8d0f0da817e617a2a8b85788d6a648083f35af
2020-11-20[HICN-658] Improve memif connector.Mauro Sardara1-8/+8
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Ie3b48148dcb3f782a1ca906a5ba59d605f17f93e Signed-off-by: Mauro Sardara <msardara@cisco.com>
2020-11-11[HICN-653] Fix libmemif-{dev,devel} dependenciesMauro Sardara1-1/+1
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I10e901cce08d4188f62261553012295407a0f0cf
2020-11-10[HICN-651] Offload checksum computation also for data packets.Mauro Sardara4-24/+63
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I3663ac73cdbaad3e53d4b1973a7bcbb333b3910c
2020-11-10[HICN-651] Offload checksum computation to VPP.Mauro Sardara1-4/+19
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I42d69455542f3def0076fe58020f8f10347ef83f
2020-11-06[HICN-653] Cleanup build scripts.Mauro Sardara1-0/+10
Main changes: - Next VPP version is now counted 4 months (instead of 3) from the current one - CMake will now use Ninja as generator - Build functions are gathered under build/functions.sh and they are shared instead of being duplicated in build-extras and build-packages - Various bug fixes for dependencies and versioning. Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I3f482d2c87847a465019dd0992ee9375c88bb412 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2020-09-22[HICN-640] Put all interfaces in VRF 10, not only MPLS interfaces.Mauro Sardara1-7/+0
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I2c7ff24ee4d31e4f5659ef88f8a6c4a9d9c630b1
2020-09-18Revert to [HICN-638] Check if systemd is running before enabling hicn-light ↵Mauro Sardara121-5644/+306
service Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I1810d96e001a4e6e097e1efa331b682af750925d
2020-09-14[HICN-574] Host stack plugin for VPP.Mauro Sardara121-300/+5638
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I8d8fdffef31a7013265d6529c5f52f3d5ec70d18 Signed-off-by: Mauro Sardara <msardara@cisco.com> Signed-off-by: Mauro <you@example.com> Signed-off-by: Mauro Sardara <msardara@cisco.com>
2020-09-14[HICN-598] [HICN-599] Fix hicn_name_t definition conflicts.Mauro Sardara1-6/+6
Change-Id: Ica8db44e27c3a4911ea869e91f96b781809373d8 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2020-09-09[HICN-637] Remove hicn_plugin dependency from libtransport.Mauro Sardara1-15/+15
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: Iabfe133ffc2235fa2341538767ce83c2e5ad77b1 Signed-off-by: Mauro Sardara <msardara@cisco.com>
2020-05-28[HICN-617] Prepare hicn-plugin for VPP 20.05 release.Mauro Sardara2-148/+142
Signed-off-by: Mauro Sardara <msardara@cisco.com> Change-Id: I701379bf0f088cad4a94209664de16e7bfe76f5e Signed-off-by: Mauro Sardara <msardara@cisco.com>
2020-05-13Merge "[HICN-606] Added doxygen documentation"Luca Muscariello46-895/+834
2020-05-06[HICN-606] Added doxygen documentationAlberto Compagno46-895/+834
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com> Change-Id: If2bf7f4f310adf6adbbb9ea29eafcb2a0ee40d54
2020-05-05[HICN-608] Added configuratin option to manage hicn behaviour with interfacesAlberto Compagno5-7/+28
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com> Change-Id: I8d48237b5dce737be443ec8949ac11721158d830
2020-05-04[HICN-603] Cleanup code for managing routeAlberto Compagno6-621/+26
- Remove old code to add and remove hicn route. Routes are now added only through the ip route commands/apis - Adjusted the cli to set the strategy for a particular prefix - Adjusted libtransport consumer and producer app creation - Adjusted sysrepo plugin. Added hicn enable and disable and removed old api related to hicn routes and hicn faces - Adjusted libhicnctrl. Only routes api and listener are now available for hicn-plugin Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com> Change-Id: Ib4f7f45ba0b99253d60a9da2b295d6e783e5cd51
2020-05-04[HICN-602] Added bidirectional udp tunnelsAlberto Compagno22-54/+1343
- Implemented a udp decapsulation node - Added a hash table to identify the incoming udp tunnel when an interest or data packets are received - Added udp punting through udp_register_dst_port Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com> Change-Id: Iffea4d81c5ea8ce8ccbbfd749113f06a698a2afe
2020-05-04[HICN-592] Updating the vrf 0 (default fib) when a mapme event occursAlberto Compagno13-202/+337
Updates on the vrf 0 will be reflected on the hicn vrf thanks to the fib entry tracking. Change-Id: I4afd6256593f27172c4b0a613316fb8428fa8e50 Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
2020-05-04[HICN-591] Created new command "hicn enable <prefix>" that enable hicn on a ↵Alberto Compagno20-292/+790
given prefix The changes include: - we use now a different vrf for the hicn routes. The default vrf (fib) contains every route, we sync the route we marked as hicn on the hicn vrf. In the vrf we use a custom dpo to implement the forwarding strategy. Change-Id: I399805eff8a62a5c41bf7b50831986a35bce4f76 Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com>
2020-05-04[HICN-590] Removed andjacency type specific face implementationAlberto Compagno63-6693/+1756
Changes in the new implementation are: - the adjacency index is replaced with a dpo that allows the single face node to dispatch the packet to the right vlib node. - local and remote address in the face are replaced with a single nat address which is used to perform the nat operation when rewriting an interest or a data (in case of tunnels the nat address will be equal to 0) - the list of next hop in the load balance is no longer a list of dpos but a list of face id (this makes the code easier and increases the number of next hop we supports) Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com> Change-Id: I4ac2b4eb09425bfe1b3ca9f82d7d0ff564297b0d
2020-04-27[HICN-604] using host order port value to punt udp packetAlberto Compagno1-2/+2
Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com> Change-Id: I9c135c76b881fecafe673517501d9539d2e30b2d
2020-04-27[HICN-604] Added missing punting for udp facesAlberto Compagno1-1/+8
Every time a udp face is created, a punting on the source port of the face is added Signed-off-by: Alberto Compagno <acompagn+fdio@cisco.com> Change-Id: I2b6205cdeb0ef8f527e2ce9a2046c345275b3bca