summaryrefslogtreecommitdiffstats
path: root/infra/cfg-init
diff options
context:
space:
mode:
authorMaros Marsalek <mmarsale@cisco.com>2016-09-05 12:10:26 +0200
committerMarek Gradzki <mgradzki@cisco.com>2016-09-07 06:50:30 +0000
commit1326e9fa5cffe326b82aeee9d82d008526aff947 (patch)
treef8ca808f3aa3a9338573d8892b83305210a664a1 /infra/cfg-init
parent6e77db8e850be8ad8a3d91bf43fb8986125ae60f (diff)
Cleanup TODOs and FIXMEs
- Fix minor ones - Report bigger and include issue number in comment - Pull common dependencies into dependency management of common/parents Change-Id: I06a6ac37c52b603fd73ed42023d6b2e7fa18010f Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Diffstat (limited to 'infra/cfg-init')
-rw-r--r--infra/cfg-init/pom.xml1
-rw-r--r--infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/AbstractDataTreeConverter.java5
-rw-r--r--infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/InitializerRegistryImpl.java2
3 files changed, 5 insertions, 3 deletions
diff --git a/infra/cfg-init/pom.xml b/infra/cfg-init/pom.xml
index df481b7da..c1fd353dc 100644
--- a/infra/cfg-init/pom.xml
+++ b/infra/cfg-init/pom.xml
@@ -39,6 +39,7 @@
<artifactId>data-api</artifactId>
<version>${project.version}</version>
</dependency>
+
<!-- Testing Dependencies -->
<dependency>
<groupId>junit</groupId>
diff --git a/infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/AbstractDataTreeConverter.java b/infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/AbstractDataTreeConverter.java
index 5476bb423..86188dd3f 100644
--- a/infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/AbstractDataTreeConverter.java
+++ b/infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/AbstractDataTreeConverter.java
@@ -97,9 +97,10 @@ public abstract class AbstractDataTreeConverter<O extends DataObject, C extends
writeTx.submit().checkedGet();
}
- // TODO make this class concrete and use function dependency instead of abstract method
+ // TODO HONEYCOMB-158 make this class concrete and use function dependency instead of abstract method
/**
- * Converts operational data to config data for given root node
+ * Converts operational data to config data for given root node.
+ *
* @param operationalData data object representing operational data
* @return data object representing config data
*/
diff --git a/infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/InitializerRegistryImpl.java b/infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/InitializerRegistryImpl.java
index 2433130a9..cc1c2dbeb 100644
--- a/infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/InitializerRegistryImpl.java
+++ b/infra/cfg-init/src/main/java/io/fd/honeycomb/data/init/InitializerRegistryImpl.java
@@ -35,7 +35,7 @@ public class InitializerRegistryImpl implements InitializerRegistry {
@Override
public void initialize() throws InitializeException {
- // TODO check if readers are there
+ // TODO HONEYCOMB-159 check if readers are there
LOG.debug("InitializerRegistryImpl.initialize()");
for (DataTreeInitializer initializer : initializers) {
initializer.initialize();