Remove ReflectionToStringBuilder.toString invocation on jvpp DTOs

VPP-413 introduced toString methods for all DTOs

Change-Id: Ib81acca4867c49198d7d2ca550bf3a920a0d4f1a
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>

3 files changed, 6 insertions, 28 deletions

diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceEthWriter.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceEthWriter.java
index d204e1631..f6bb9c879 100644
--- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceEthWriter.java
+++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceEthWriter.java
@@ -20,7 +20,6 @@ import com.google.common.annotations.VisibleForTesting;
 import io.fd.honeycomb.translate.v3po.util.TranslateUtils;
 import java.util.List;
 import javax.annotation.Nonnull;
-import org.apache.commons.lang3.builder.ReflectionToStringBuilder;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160708.access.lists.acl.access.list.entries.ace.actions.PacketHandling;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160708.access.lists.acl.access.list.entries.ace.matches.ace.type.AceEth;
 import org.openvpp.jvpp.core.dto.ClassifyAddDelSession;
@@ -92,10 +91,7 @@ final class AceEthWriter extends AbstractAceWriter<AceEth> {
         request.skipNVectors = 0;
         request.matchNVectors = MATCH_N_VECTORS;
 
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("ACE action={}, rule={} translated to table={}.", action, aceEth,
-                ReflectionToStringBuilder.toString(request));
-        }
+        LOG.debug("ACE action={}, rule={} translated to table={}.", action, aceEth, request);
         return request;
     }
 
@@ -134,10 +130,7 @@ final class AceEthWriter extends AbstractAceWriter<AceEth> {
                 String.format("Ace %s does not define neither source nor destination MAC address", aceEth.toString()));
         }
 
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("ACE action={}, rule={} translated to session={}.", action, aceEth,
-                ReflectionToStringBuilder.toString(request));
-        }
+        LOG.debug("ACE action={}, rule={} translated to session={}.", action, aceEth, request);
         return request;
     }
 
diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceIp4Writer.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceIp4Writer.java
index 857f00393..cb232ed3e 100644
--- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceIp4Writer.java
+++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceIp4Writer.java
@@ -22,7 +22,6 @@ import static io.fd.honeycomb.translate.v3po.util.TranslateUtils.ipv4AddressNoZo
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.primitives.Ints;
 import javax.annotation.Nonnull;
-import org.apache.commons.lang3.builder.ReflectionToStringBuilder;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160708.access.lists.acl.access.list.entries.ace.actions.PacketHandling;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160708.access.lists.acl.access.list.entries.ace.matches.ace.type.AceIp;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160708.access.lists.acl.access.list.entries.ace.matches.ace.type.ace.ip.ace.ip.version.AceIpv4;
@@ -127,10 +126,7 @@ final class AceIp4Writer extends AbstractAceWriter<AceIp> {
                 String.format("Ace %s does not define packet field match values", aceIp.toString()));
         }
 
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("ACE action={}, rule={} translated to table={}.", action, aceIp,
-                ReflectionToStringBuilder.toString(request));
-        }
+        LOG.debug("ACE action={}, rule={} translated to table={}.", action, aceIp, request);
         return request;
     }
 
@@ -186,10 +182,7 @@ final class AceIp4Writer extends AbstractAceWriter<AceIp> {
                 String.format("Ace %s does not define packet field match values", aceIp.toString()));
         }
 
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("ACE action={}, rule={} translated to session={}.", action, aceIp,
-                ReflectionToStringBuilder.toString(request));
-        }
+        LOG.debug("ACE action={}, rule={} translated to session={}.", action, aceIp, request);
         return request;
     }
 
diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceIp6Writer.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceIp6Writer.java
index d847ed845..1e222ec6a 100644
--- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceIp6Writer.java
+++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/acl/AceIp6Writer.java
@@ -23,7 +23,6 @@ import java.net.InetAddress;
 import java.net.UnknownHostException;
 import java.util.BitSet;
 import javax.annotation.Nonnull;
-import org.apache.commons.lang3.builder.ReflectionToStringBuilder;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160708.access.lists.acl.access.list.entries.ace.actions.PacketHandling;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160708.access.lists.acl.access.list.entries.ace.matches.ace.type.AceIp;
 import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160708.access.lists.acl.access.list.entries.ace.matches.ace.type.ace.ip.ace.ip.version.AceIpv6;
@@ -150,11 +149,7 @@ final class AceIp6Writer extends AbstractAceWriter<AceIp> {
                 String.format("Ace %s does not define packet field match values", aceIp.toString()));
         }
 
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("ACE action={}, rule={} translated to table={}.", action, aceIp,
-                ReflectionToStringBuilder.toString(request));
-        }
-
+        LOG.debug("ACE action={}, rule={} translated to table={}.", action, aceIp, request);
         return request;
     }
 
@@ -219,10 +214,7 @@ final class AceIp6Writer extends AbstractAceWriter<AceIp> {
                 String.format("Ace %s does not define packet field match values", aceIp.toString()));
         }
 
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("ACE action={}, rule={} translated to session={}.", action, aceIp,
-                ReflectionToStringBuilder.toString(request));
-        }
+        LOG.debug("ACE action={}, rule={} translated to session={}.", action, aceIp, request);
         return request;
     }