HONEYCOMB-67: Minor corrections in tests, styles

Removed unnecessary calls from tests
Sonar corrections

Change-Id: Ib182d66fd47a4feb9686989d086482ffe188470f
Signed-off-by: Tibor Sirovatka <tsirovat@cisco.com>

1 files changed, 5 insertions, 3 deletions

diff --git a/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/test/TestHelperUtils.java b/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/test/TestHelperUtils.java
index 598b62f05..e82b3ec03 100644
--- a/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/test/TestHelperUtils.java
+++ b/v3po/v3po2vpp/src/test/java/io/fd/honeycomb/v3po/translate/v3po/test/TestHelperUtils.java
@@ -22,14 +22,16 @@ import org.openvpp.jvpp.dto.JVppReply;
 import java.util.concurrent.CompletableFuture;
 
 public class TestHelperUtils {
+    private final static int ERROR_RETVAL = -1;
+
     /**
      * Static helper method for creation of Exception failure state in CompletableFuture object
-     * @param retval result of the operation in exception
+     * with retval = -1
      * @return CompletableFuture with VppCallbackException as a cause
      */
-    public static CompletableFuture<? extends JVppReply>  createFutureException(final int retval) {
+    public static CompletableFuture<? extends JVppReply>  createFutureException() {
         final CompletableFuture<? extends JVppReply> replyFuture = new CompletableFuture<>();
-        replyFuture.completeExceptionally(new VppCallbackException("test-call", 1, retval));
+        replyFuture.completeExceptionally(new VppCallbackException("test-call", 1, ERROR_RETVAL));
         return replyFuture;
     }
 }