verify L2/L3 configuration cannot be done under traffic

also ping and arp

Signed-off-by: imarom <imarom@cisco.com>

2 files changed, 4 insertions, 9 deletions

diff --git a/scripts/automation/trex_control_plane/stl/trex_stl_lib/trex_stl_client.py b/scripts/automation/trex_control_plane/stl/trex_stl_lib/trex_stl_client.py
index 945aacd0..743ff27c 100755
--- a/scripts/automation/trex_control_plane/stl/trex_stl_lib/trex_stl_client.py
+++ b/scripts/automation/trex_control_plane/stl/trex_stl_lib/trex_stl_client.py
@@ -2973,11 +2973,6 @@ class STLClient(object):
         ports = ports if ports is not None else self.get_resolvable_ports()
         ports = self._validate_port_list(ports)
             
-        active_ports = list_intersect(ports, self.get_active_ports())
-        if active_ports:
-            raise STLError('Port(s) {0} are active, please stop them before resolving'.format(active_ports))
-                     
-        
         self.logger.pre_cmd('Resolving destination on port(s) {0}:'.format(ports))
         with self.logger.supress():
             rc = self.__resolve(ports, retries)
diff --git a/scripts/automation/trex_control_plane/stl/trex_stl_lib/trex_stl_port.py b/scripts/automation/trex_control_plane/stl/trex_stl_lib/trex_stl_port.py
index 487f3055..66d8be2b 100644
--- a/scripts/automation/trex_control_plane/stl/trex_stl_lib/trex_stl_port.py
+++ b/scripts/automation/trex_control_plane/stl/trex_stl_lib/trex_stl_port.py
@@ -114,7 +114,7 @@ class Port(object):
                 return port.err("{0} - port is not owned".format(func.__name__))
 
             if not port.is_writeable():
-                return port.err("{0} - port is not in a writeable state".format(func.__name__))
+                return port.err("{0} - port is active, please stop the port before executing command".format(func.__name__))
 
             return func(*args, **kwargs)
 
@@ -123,7 +123,7 @@ class Port(object):
 
 
     def err(self, msg):
-        return RC_ERR("port {0} : {1}\n".format(self.port_id, msg))
+        return RC_ERR("port {0} : *** {1}".format(self.port_id, msg))
 
     def ok(self, data = ""):
         return RC_OK(data)
@@ -519,7 +519,7 @@ class Port(object):
 
         return self.ok()
      
-    @owned
+    @writeable
     def set_l2_mode (self, dst_mac):
         if not self.is_service_mode_on():
             return self.err('port service mode must be enabled for configuring L2 mode. Please enable service mode')
@@ -535,7 +535,7 @@ class Port(object):
         return self.sync()
         
         
-    @owned
+    @writeable
     def set_l3_mode (self, src_addr, dest_addr, resolved_mac = None):
         if not self.is_service_mode_on():
             return self.err('port service mode must be enabled for configuring L3 mode. Please enable service mode')