diff options
| author |   Ole Troan <ot@cisco.com> | 2016-08-04 10:19:17 +0200 |
|---|---|---|
| committer |   Dave Barach <openvpp@barachs.net> | 2016-08-11 19:41:39 +0000 |
| commit | 58a90a4b1648a1581a69c06ec729f20979f9e6b2 (patch) | |
| tree | 007e324c0646270135cc85c3527278aff6dabe41 | |
| parent | da76de230417eb9811d04013d8fd13fdbfdaa677 (diff) | |
Coverty error: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT)
While the code is correct (assignment was intended) I have rewritten
it for readability.
Change-Id: I5f6fd7d7377c3904e74de4edfd478322a75af612
Signed-off-by: Ole Troan <ot@cisco.com>
| -rw-r--r-- | vnet/vnet/map/map.c | 19 |
1 files changed, 13 insertions, 6 deletions
diff --git a/vnet/vnet/map/map.c b/vnet/vnet/map/map.c index cd327777404..8236811f8b1 100644 --- a/vnet/vnet/map/map.c +++ b/vnet/vnet/map/map.c @@ -1099,12 +1099,19 @@ map_params_reass_command_fn (vlib_main_t * vm, unformat_input_t * input, while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT) { - if (!unformat (line_input, "lifetime %u", &lifetime) && - !unformat (line_input, "ht-ratio %lf", &ht_ratio) && - !unformat (line_input, "pool-size %u", &pool_size) && - !unformat (line_input, "buffers %llu", &buffers) && - !((unformat (line_input, "ip4")) && (ip4 = 1)) && - !((unformat (line_input, "ip6")) && (ip6 = 1))) + if (unformat (line_input, "lifetime %u", &lifetime)) + ; + else if (unformat (line_input, "ht-ratio %lf", &ht_ratio)) + ; + else if (unformat (line_input, "pool-size %u", &pool_size)) + ; + else if (unformat (line_input, "buffers %llu", &buffers)) + ; + else if (unformat (line_input, "ip4")) + ip4 = 1; + else if (unformat (line_input, "ip6")) + ip6 = 1; + else { unformat_free (line_input); return clib_error_return (0, "invalid input"); |