aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarco Varlese <marco.varlese@suse.com>2018-04-18 08:50:57 +0200
committerChris Luke <chris_luke@comcast.com>2018-04-18 15:32:42 +0000
commit8579a389fc5172d8f1fc9039b6499449cb5a0bf5 (patch)
treec26208266250498f96759a4376b9e29d083b73e5
parent6cdad6d8ff0378dbc5037bb4e52e5016eaf2596e (diff)
SCTP: coverity warnings
This patch addresses the warning 182994 Change-Id: I071f3cbdf9965c7b57d444f79430ee75c66c856e Signed-off-by: Marco Varlese <marco.varlese@suse.com>
-rw-r--r--src/vnet/sctp/sctp_input.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/src/vnet/sctp/sctp_input.c b/src/vnet/sctp/sctp_input.c
index bc36a7f91d5..775d14ae21a 100644
--- a/src/vnet/sctp/sctp_input.c
+++ b/src/vnet/sctp/sctp_input.c
@@ -483,7 +483,6 @@ sctp_handle_init_ack (sctp_header_t * sctp_hdr,
{
sctp_init_ack_chunk_t *init_ack_chunk =
(sctp_init_ack_chunk_t *) (sctp_hdr);
- sctp_state_cookie_param_t state_cookie;
char hostname[FQDN_MAX_LENGTH];
@@ -560,8 +559,9 @@ sctp_handle_init_ack (sctp_header_t * sctp_hdr,
sctp_state_cookie_param_t *state_cookie_param =
(sctp_state_cookie_param_t *) opt_params_hdr;
- clib_memcpy (&state_cookie, state_cookie_param,
+ clib_memcpy (&(sctp_conn->cookie_param), state_cookie_param,
sizeof (sctp_state_cookie_param_t));
+
break;
}
case SCTP_HOSTNAME_ADDRESS_TYPE:
@@ -587,9 +587,6 @@ sctp_handle_init_ack (sctp_header_t * sctp_hdr,
}
}
- clib_memcpy (&(sctp_conn->cookie_param), &state_cookie,
- sizeof (sctp_state_cookie_param_t));
-
sctp_prepare_cookie_echo_chunk (sctp_conn, idx, b0, 1);
/* Start the T1_COOKIE timer */