aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenoît Ganne <bganne@cisco.com>2021-02-26 14:46:58 +0100
committerDave Barach <openvpp@barachs.net>2021-03-02 12:59:55 +0000
commit5943e36b60955ff7baaac383dcd121e36c999711 (patch)
tree99913db859d4ea82ebb1d93bf14496f840660ead
parent8c45e5109522cf9bbc98785283cd4c923f486fe6 (diff)
classify: fix crash if no pcap filter has been configured
If no pcap filters have ever been configured and we try to enable pcap capture with a filter, cm->classify_table_index_by_sw_if_index is not initialized yet. Type: fix Change-Id: I2f509c58f9984951b1ad81c1c8ed912cb594fce1 Signed-off-by: Benoît Ganne <bganne@cisco.com>
-rw-r--r--src/vnet/interface_cli.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/vnet/interface_cli.c b/src/vnet/interface_cli.c
index a901e17e413..54e0673544f 100644
--- a/src/vnet/interface_cli.c
+++ b/src/vnet/interface_cli.c
@@ -1971,7 +1971,8 @@ vnet_pcap_dispatch_trace_configure (vnet_pcap_dispatch_trace_args_t * a)
/* Classify filter specified, but no classify filter configured */
if ((a->rx_enable + a->tx_enable + a->drop_enable) && a->filter &&
- cm->classify_table_index_by_sw_if_index[0] == ~0)
+ (!cm->classify_table_index_by_sw_if_index ||
+ cm->classify_table_index_by_sw_if_index[0] == ~0))
return VNET_API_ERROR_NO_SUCH_LABEL;
if (a->rx_enable + a->tx_enable + a->drop_enable)