aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Vinciguerra <pvinci@vinciconsulting.com>2020-12-16 21:03:16 -0500
committerOle Tr�an <otroan@employees.org>2021-02-15 09:57:11 +0000
commitd1f05f7f861fca5e54b30acdd17b6d528d1e5eff (patch)
treec649cd7730a4273c78a39f1624f0fb1ccbc61ad7
parent1fd1ea253470ea63e9174466daa5de73c4ea7576 (diff)
tests: explicitly close subprocess files
Resolve the following error: /vpp/test/framework.py:657: ResourceWarning: unclosed file <_io.BufferedReader name=6> del cls.vpp Object allocated at (most recent call last): File "/usr/lib/python3.8/subprocess.py", lineno 844 self.stdout = io.open(c2pread, 'rb', bufsize) Type: test Change-Id: Ia2974da594f0582dcff1f4bdf40d25475769c46c Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
-rw-r--r--test/framework.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/test/framework.py b/test/framework.py
index c9ecafd2bca..9bb3e01c31e 100644
--- a/test/framework.py
+++ b/test/framework.py
@@ -679,6 +679,8 @@ class VppTestCase(unittest.TestCase):
cls.vpp.communicate()
cls.logger.debug("Deleting class vpp attribute on %s",
cls.__name__)
+ cls.vpp.stdout.close()
+ cls.vpp.stderr.close()
del cls.vpp
if cls.vpp_startup_failed: