diff options
| author |   Arthur de Kerhor <arthurdekerhor@gmail.com> | 2024-01-08 19:30:57 +0100 |
|---|---|---|
| committer |   Beno�t Ganne <bganne@cisco.com> | 2024-01-29 10:22:17 +0000 |
| commit | af1ddd39f1f5fa6a00e70356bac2b0bd38f76566 (patch) | |
| tree | c4b96e271328e97576e080ca4bd9422b66f428bb | |
| parent | 707210c636095d10df66f4a9d047860b155be782 (diff) | |
ip: don't export useless error counters for ip6 rewrite
the error node is set to ip6_input in the inline funcition
associated with ip6_rewrite. Thus, error counters defined
for node ip6 rewrite are never used.
Type: fix
Change-Id: Id6bef633928b0fff9069498c2e39e9f5bea2cf9b
Signed-off-by: Arthur de Kerhor <arthurdekerhor@gmail.com>
| -rw-r--r-- | src/vnet/ip/ip6_forward.c | 2 | ||||
| -rw-r--r-- | test/test_mtu.py | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/vnet/ip/ip6_forward.c b/src/vnet/ip/ip6_forward.c index 84ea5a068aa..2171cb8b576 100644 --- a/src/vnet/ip/ip6_forward.c +++ b/src/vnet/ip/ip6_forward.c @@ -2256,8 +2256,6 @@ VLIB_REGISTER_NODE (ip6_rewrite_node) = .name = "ip6-rewrite", .vector_size = sizeof (u32), .format_trace = format_ip6_rewrite_trace, - .n_errors = IP6_N_ERROR, - .error_counters = ip6_error_counters, .n_next_nodes = IP6_REWRITE_N_NEXT, .next_nodes = { diff --git a/test/test_mtu.py b/test/test_mtu.py index 4159deb414e..ed4fcb57818 100644 --- a/test/test_mtu.py +++ b/test/test_mtu.py @@ -113,6 +113,8 @@ class TestMTU(VppTestCase): # n.show2() self.validate_bytes(bytes(p[1]), icmp4_reply) + self.assert_error_counter_equal("/err/ip4-input/mtu_exceeded", 11) + # Now with DF off. Expect fragments. # First go with 1500 byte packets. p_payload = UDP(sport=1234, dport=1234) / self.payload(1500 - 20 - 8) @@ -191,6 +193,8 @@ class TestMTU(VppTestCase): for p in rx: self.validate_bytes(bytes(p[1]), icmp6_reply_str) + self.assert_error_counter_equal("/err/ip6-input/mtu_exceeded", 9) + # Reset MTU self.vapi.sw_interface_set_mtu(self.pg1.sw_if_index, [current_mtu, 0, 0, 0]) |