diff options
| author |   Dave Barach <dave@barachs.net> | 2020-06-16 08:40:53 -0400 |
|---|---|---|
| committer |   Dave Wallace <dwallacelf@gmail.com> | 2020-06-16 17:32:17 +0000 |
| commit | 1af730d0dfbb91475c6808ed579494d3d223b724 (patch) | |
| tree | c6eabf52103e066dedb2eafc952399c996523593 | |
| parent | cea46522e79637f6ec37c03ec3fbeb87b160a378 (diff) | |
misc: fix sonarclound warnings
Type: fix
Ticket: VPP-1888
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9c2fb926a5e010658088a74051c8c3462ff61734
| -rw-r--r-- | src/plugins/acl/acl_test.c | 5 | ||||
| -rw-r--r-- | src/plugins/dns/dns_test.c | 6 | ||||
| -rw-r--r-- | src/plugins/http_static/static_server.c | 2 |
3 files changed, 11 insertions, 2 deletions
diff --git a/src/plugins/acl/acl_test.c b/src/plugins/acl/acl_test.c index e559f3acc9c..c139b325568 100644 --- a/src/plugins/acl/acl_test.c +++ b/src/plugins/acl/acl_test.c @@ -615,10 +615,13 @@ api_acl_add_replace_from_file (vat_main_t * vam) break; } + if (file_name == NULL) + goto done; + fd = open(file_name, O_RDONLY); if (fd < 0) { - clib_warning("Could not open file '%s'"); + clib_warning("Could not open file '%s'", file_name); goto done; } diff --git a/src/plugins/dns/dns_test.c b/src/plugins/dns/dns_test.c index 9d5be8fcc1b..aefcefb51ac 100644 --- a/src/plugins/dns/dns_test.c +++ b/src/plugins/dns/dns_test.c @@ -123,6 +123,12 @@ api_dns_resolve_name (vat_main_t * vam) break; } + if (name == 0) + { + errmsg ("missing name to resolve"); + return -99; + } + if (vec_len (name) > 127) { errmsg ("name too long"); diff --git a/src/plugins/http_static/static_server.c b/src/plugins/http_static/static_server.c index d7a7fcf2947..45d8731af83 100644 --- a/src/plugins/http_static/static_server.c +++ b/src/plugins/http_static/static_server.c @@ -937,7 +937,7 @@ state_sent_ok (session_t * s, http_session_t * hs, /* What kind of dog food are we serving? */ suffix = (char *) (hs->path + vec_len (hs->path) - 1); - while (*suffix != '.') + while ((u8 *) suffix >= hs->path && *suffix != '.') suffix--; suffix++; http_type = "text/html"; |