diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2022-01-31 18:29:09 +0100 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2022-02-06 11:46:49 +0000 |
| commit | 7a2574a8ca4bf378e876df40c6e8d290d53d5f7e (patch) | |
| tree | 17b0bfc37503010d3d2777731025a2b919ed8562 | |
| parent | 291307e427e37ea6d31a85db53dc87665e076734 (diff) | |
dpdk: remove dead code
rte_eth_tx_burst() returns the number of packets actually stored in
transmit descriptors and the return type is uint16. n_sent cannot be
negative and the if branch is dead code.
Type: improvement
Change-Id: Idc2980d342756c1093ddf74ea6207d072e819331
Signed-off-by: Benoît Ganne <bganne@cisco.com>
| -rw-r--r-- | src/plugins/dpdk/device/device.c | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/src/plugins/dpdk/device/device.c b/src/plugins/dpdk/device/device.c index c9061a9949a..fa19f5c8457 100644 --- a/src/plugins/dpdk/device/device.c +++ b/src/plugins/dpdk/device/device.c @@ -25,7 +25,6 @@ #include <vlib/unix/unix.h> #define foreach_dpdk_tx_func_error \ - _(BAD_RETVAL, "DPDK tx function returned an error") \ _(PKT_DROP, "Tx packet drops (dpdk tx failure)") typedef enum @@ -173,23 +172,10 @@ static_always_inline /* no wrap, transmit in one burst */ n_sent = rte_eth_tx_burst (xd->port_id, queue_id, mb, n_left); - n_retry--; clib_spinlock_unlock_if_init (&txq->lock); - if (PREDICT_FALSE (n_sent < 0)) - { - // emit non-fatal message, bump counter - vnet_main_t *vnm = vnet_get_main (); - vnet_interface_main_t *im = &vnm->interface_main; - u32 node_index; - - node_index = vec_elt_at_index (im->hw_interfaces, - xd->hw_if_index)->tx_node_index; - - vlib_error_count (vm, node_index, DPDK_TX_FUNC_ERROR_BAD_RETVAL, 1); - return n_left; // untransmitted packets - } + n_retry--; n_left -= n_sent; mb += n_sent; } |