diff options
| author |   Jakub Grajciar <jgrajcia@cisco.com> | 2018-10-08 13:35:32 +0200 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2018-10-08 17:44:58 +0000 |
| commit | 4a0559a804237f71b19d395b0fd25029cd03b248 (patch) | |
| tree | fe7f2028321a6e04a9e4f304640b159f294cc195 | |
| parent | cef5db0acdd076c33ed891c359b15086713aaafa (diff) | |
memif: socket filename add/del bugfix
Check access rights using effective user/group IDs
Change-Id: I3683258c24bcd7817024bffbd56b54b2f596fdd7
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
| -rw-r--r-- | src/plugins/memif/memif.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/memif/memif.c b/src/plugins/memif/memif.c index e35a8dcb4a0..63f72a30de4 100644 --- a/src/plugins/memif/memif.c +++ b/src/plugins/memif/memif.c @@ -618,7 +618,6 @@ memif_delete_socket_file (u32 sock_id) int memif_socket_filename_add_del (u8 is_add, u32 sock_id, u8 * sock_filename) { - struct stat file_stat; char *dir = 0, *tmp; u32 idx = 0; @@ -680,8 +679,9 @@ memif_socket_filename_add_del (u8 is_add, u32 sock_id, u8 * sock_filename) vec_add1 (dir, '\0'); } - if (((dir == 0) || (stat (dir, &file_stat) == -1) - || (!S_ISDIR (file_stat.st_mode))) && (idx != 0)) + /* check dir existance and access rights for effective user/group IDs */ + if (faccessat ( /* ignored */ -1, dir, F_OK | R_OK | W_OK, AT_EACCESS) < + 0) { vec_free (dir); return VNET_API_ERROR_INVALID_ARGUMENT; |