aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Barach <dave@barachs.net>2020-05-04 14:47:45 -0400
committerDamjan Marion <dmarion@me.com>2020-05-06 10:24:21 +0000
commitc72950e811880c22e5b350c4b1cb5e31b0735b4d (patch)
tree27d8263ae8ca9f408b5855527af0e98406900514
parent971c5be27996985e40f178c8d540a5807a428283 (diff)
misc: fix coverity warnings
Type: fix Ticket: VPP-1837 Signed-off-by: Dave Barach <dave@barachs.net> Change-Id: I51660e4b02f449bd2db12a8cfd395c6c343d2dee
-rw-r--r--src/vlib/linux/pci.c2
-rw-r--r--src/vnet/lisp-cp/one_api.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/vlib/linux/pci.c b/src/vlib/linux/pci.c
index 8af1cdab0d4..722fb888117 100644
--- a/src/vlib/linux/pci.c
+++ b/src/vlib/linux/pci.c
@@ -1137,7 +1137,7 @@ vlib_pci_map_region_int (vlib_main_t * vm, vlib_pci_dev_handle_t h,
if (*result == (void *) -1)
{
error = clib_error_return_unix (0, "mmap `BAR%u'", bar);
- if (p->type == LINUX_PCI_DEVICE_TYPE_UIO)
+ if (p->type == LINUX_PCI_DEVICE_TYPE_UIO && (fd != -1))
close (fd);
return error;
}
diff --git a/src/vnet/lisp-cp/one_api.c b/src/vnet/lisp-cp/one_api.c
index 912b9dffd0e..f7a972be7a2 100644
--- a/src/vnet/lisp-cp/one_api.c
+++ b/src/vnet/lisp-cp/one_api.c
@@ -1119,7 +1119,7 @@ one_adjacency_copy (vl_api_one_adjacency_t * dst, lisp_adjacency_t * adjs)
a.leid.address.nsh.si = gid_address_nsh_si (&adj->leid);
break;
default:
- ASSERT (0);
+ ALWAYS_ASSERT (0);
}
a.reid.type = eid_type;
a.leid.type = eid_type;