diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2022-04-28 11:07:14 +0200 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2022-04-28 14:45:22 +0000 |
| commit | 07c73690e992525320be1067cff33a6b8d5ec9e3 (patch) | |
| tree | 488d05bf8bb0332b267d173221862a6368987f1c | |
| parent | 975e0dfe166cd19c883c1bf67514f23314804c9d (diff) | |
af_xdp: more meaningful frame_size error message
Type: improvement
Change-Id: If3a83848ae0741334887c654b65e424b99caa73c
Signed-off-by: Benoît Ganne <bganne@cisco.com>
| -rw-r--r-- | src/plugins/af_xdp/device.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/src/plugins/af_xdp/device.c b/src/plugins/af_xdp/device.c index d107a39b199..5a16ede1323 100644 --- a/src/plugins/af_xdp/device.c +++ b/src/plugins/af_xdp/device.c @@ -33,6 +33,10 @@ #include <vnet/interface/tx_queue_funcs.h> #include "af_xdp.h" +#ifndef XDP_UMEM_MIN_CHUNK_SIZE +#define XDP_UMEM_MIN_CHUNK_SIZE 2048 +#endif + af_xdp_main_t af_xdp_main; typedef struct @@ -272,8 +276,18 @@ af_xdp_create_queue (vlib_main_t *vm, af_xdp_create_if_args_t *args, (umem, uword_to_pointer (vm->buffer_main->buffer_mem_start, void *), vm->buffer_main->buffer_mem_size, fq, cq, &umem_config)) { + uword sys_page_size = clib_mem_get_page_size (); args->rv = VNET_API_ERROR_SYSCALL_ERROR_1; args->error = clib_error_return_unix (0, "xsk_umem__create() failed"); + /* this should mimic the Linux kernel net/xdp/xdp_umem.c:xdp_umem_reg() + * check */ + if (umem_config.frame_size < XDP_UMEM_MIN_CHUNK_SIZE || + umem_config.frame_size > sys_page_size) + args->error = clib_error_return ( + args->error, + "(unsupported data-size? (should be between %d and %d))", + XDP_UMEM_MIN_CHUNK_SIZE - sizeof (vlib_buffer_t), + sys_page_size - sizeof (vlib_buffer_t)); goto err0; } |