summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Yourtchenko <ayourtch@gmail.com>2019-11-18 10:23:54 +0000
committerDave Wallace <dwallacelf@gmail.com>2020-08-12 01:22:20 +0000
commitcf758ecb71e1337f0d1fd5e9fd4744b263f01f25 (patch)
treeb75c12c86ed605a1e3bb4385d679fdbb52a60e0e
parenta8f870ac34730540cde525e0394191dcae1f5203 (diff)
vppinfra: fix coverity issue 205691 in pmalloc
set the address to MMAP_FAILED if mmap has failed, so that we do not attempt to free it in the error handling path. Change-Id: I6e6b51a365fb68086dc20aa40a676a36af59a3ba Type: fix Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com> (cherry picked from commit 9ce35233658d6c19a4458ec7e728b6ee75fd3ace)
-rw-r--r--src/vppinfra/pmalloc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/vppinfra/pmalloc.c b/src/vppinfra/pmalloc.c
index ce78ca00334..cca8039433d 100644
--- a/src/vppinfra/pmalloc.c
+++ b/src/vppinfra/pmalloc.c
@@ -331,6 +331,7 @@ pmalloc_map_pages (clib_pmalloc_main_t * pm, clib_pmalloc_arena_t * a,
pm->error = clib_error_return_unix (0, "failed to mmap %u pages at %p "
"fd %d numa %d flags 0x%x", n_pages,
va, a->fd, numa_node, mmap_flags);
+ va = MAP_FAILED;
goto error;
}