summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFlorin Coras <fcoras@cisco.com>2023-11-28 23:21:18 -0800
committerDave Wallace <dwallacelf@gmail.com>2023-11-29 16:59:36 +0000
commit557b20c4eab7b7aefd281f28f7535c4ea22a2845 (patch)
tree7921888156202ad93eeed8530583b4bd601642fa
parent32c00ce79a9618ae1123fdd1a83084a90cc9ae97 (diff)
tcp: fix rxt send of new data assert
We might have less than 1 mss when attempting write but more after write, as application could be actively enqueuing more data. Relax assert. Type: fix Signed-off-by: Florin Coras <fcoras@cisco.com> Change-Id: I54a83c4460f8e022a88758f0ebd7828df711dbb9
-rw-r--r--src/vnet/tcp/tcp_output.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/vnet/tcp/tcp_output.c b/src/vnet/tcp/tcp_output.c
index 069c349a235..e6c87b6a3d0 100644
--- a/src/vnet/tcp/tcp_output.c
+++ b/src/vnet/tcp/tcp_output.c
@@ -1117,8 +1117,7 @@ tcp_prepare_segment (tcp_worker_ctx_t * wrk, tcp_connection_t * tc,
data = tcp_init_buffer (vm, *b);
n_bytes = session_tx_fifo_peek_bytes (&tc->connection, data, offset,
max_deq_bytes);
- ASSERT (n_bytes == clib_min (max_deq_bytes, transport_max_tx_dequeue (
- &tc->connection)));
+ ASSERT (n_bytes > 0);
b[0]->current_length = n_bytes;
tcp_push_hdr_i (tc, *b, tc->snd_una + offset, /* compute opts */ 0,
/* burst */ 0, /* update_snd_nxt */ 0);