summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Yourtchenko <ayourtch@gmail.com>2018-07-16 15:28:47 +0200
committerFlorin Coras <florin.coras@gmail.com>2018-08-03 01:18:13 +0000
commit0e10dd17b66736ac604f8e85ba17c202c893fb28 (patch)
tree95ce00ffeb47256c8d455e52861d5497db7d5a4a
parentc76d6e2c4a659f3d142274561b50507e85412fca (diff)
acl-plugin: fill in the 5tuple structure all at once, avoid short writes
This change avoids the long-read-after-short-write, resulting in a small performance improvement. Change-Id: Ic01d1fd19182e96100ccaf441d7ab5e5898b9734 Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
-rw-r--r--src/plugins/acl/dataplane_node.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/plugins/acl/dataplane_node.c b/src/plugins/acl/dataplane_node.c
index 7db0efa7be3..00cad47fb23 100644
--- a/src/plugins/acl/dataplane_node.c
+++ b/src/plugins/acl/dataplane_node.c
@@ -144,11 +144,9 @@ acl_fa_node_fn (vlib_main_t * vm,
* Extract the L3/L4 matching info into a 5-tuple structure.
*/
- acl_plugin_fill_5tuple_inline (&acl_main, lc_index0, b[0], is_ip6,
- is_input, is_l2_path,
- (fa_5tuple_opaque_t *) & fa_5tuple);
- fa_5tuple.l4.lsb_of_sw_if_index = sw_if_index0 & 0xffff;
- fa_5tuple.pkt.mask_type_index_lsb = ~0;
+ acl_fill_5tuple (&acl_main, sw_if_index0, b[0], is_ip6,
+ is_input, is_l2_path, &fa_5tuple);
+
#ifdef FA_NODE_VERBOSE_DEBUG
clib_warning
("ACL_FA_NODE_DBG: packet 5-tuple %016llx %016llx %016llx %016llx %016llx %016llx",