summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven <sluong@cisco.com>2019-01-06 11:23:24 -0800
committerDave Barach <openvpp@barachs.net>2019-01-07 22:38:39 +0000
commit98311da8b42d1e97e4a6cc22cb2032ba84f08fad (patch)
tree23eb49e08c6e7b3ff23a3756b9b267acc5c3ad3a
parent754f24b35946021bb5e648c2bbf772791afe6e20 (diff)
string_test: coverity woe
Remove the needless tests and checks which coverity complains about in string_test.c Change-Id: I971650cada77136f06528a65625ef99bd3d7e915 Signed-off-by: Steven <sluong@cisco.com>
-rw-r--r--src/plugins/unittest/string_test.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/src/plugins/unittest/string_test.c b/src/plugins/unittest/string_test.c
index 65b7c62ece8..0d41bb27918 100644
--- a/src/plugins/unittest/string_test.c
+++ b/src/plugins/unittest/string_test.c
@@ -351,10 +351,6 @@ test_clib_strcmp (vlib_main_t * vm, unformat_input_t * input)
indicator = clib_strcmp (s, s);
if (indicator != 0)
return -1;
- /* verify it against strcmp */
- indicator = strcmp (s, s);
- if (indicator != 0)
- return -1;
/* OK, seems to work */
return 0;
@@ -518,8 +514,6 @@ test_clib_strncmp (vlib_main_t * vm, unformat_input_t * input)
sizeof ("Every moment is a fresh beginning") - 1);
if (v_indicator != 0)
return -1;
- if (v_indicator != indicator)
- return -1;
/* OK, seems to work */
return 0;