diff options
| author |   Steven Luong <sluong@cisco.com> | 2019-03-05 15:42:21 -0800 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2019-03-06 11:35:30 +0000 |
| commit | 99ae31d5acadfe33a0855786bf88a4ff2fe6d0f2 (patch) | |
| tree | d5727964d98df412e6607705df5e4841d3fc4b6c | |
| parent | 951551081b555f37e9eb068876d83ea57621143a (diff) | |
ip: coverity woes
coverity complains about logically dead code for the statement if (error) because
error was assigned to 0 prior to the check. I believe error was meant to get the
return status of the call vnet_punt_socket_add.
Change-Id: I794167493f63cb898d3618c2c28817823f46b765
Signed-off-by: Steven Luong <sluong@cisco.com>
| -rw-r--r-- | src/vnet/ip/punt_api.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/vnet/ip/punt_api.c b/src/vnet/ip/punt_api.c index 3ca9621a410..ecb461bcdda 100644 --- a/src/vnet/ip/punt_api.c +++ b/src/vnet/ip/punt_api.c @@ -80,10 +80,10 @@ vl_api_punt_socket_register_t_handler (vl_api_punt_socket_register_t * mp) clib_error_t *error; vl_api_registration_t *reg; - error = 0; - vnet_punt_socket_add (vm, ntohl (mp->header_version), - mp->punt.ipv, mp->punt.l4_protocol, - ntohs (mp->punt.l4_port), (char *) mp->pathname); + error = vnet_punt_socket_add (vm, ntohl (mp->header_version), + mp->punt.ipv, mp->punt.l4_protocol, + ntohs (mp->punt.l4_port), + (char *) mp->pathname); if (error) { rv = -1; |