diff options
| author |   Florin Coras <fcoras@cisco.com> | 2024-02-13 15:37:20 -0500 |
|---|---|---|
| committer |   Dave Wallace <dwallacelf@gmail.com> | 2024-02-15 17:52:51 +0000 |
| commit | 0ded4890beaa3aa1f36c61ff6125d19582b25391 (patch) | |
| tree | 793e71c474be109a178c64605db8458757fd7324 | |
| parent | e439b1e70e4e6ca3c98264512a78a1fc741d74ac (diff) | |
tls: mark ho done atomically after ctx init
Make sure ctx is initialized before ho is marked as done.
Type: fix
Change-Id: If0525a9890a56e289e2ab006c669a9d64dc6505d
Signed-off-by: Florin Coras <fcoras@cisco.com>
| -rw-r--r-- | src/vnet/tls/tls.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/vnet/tls/tls.c b/src/vnet/tls/tls.c index 30aafe096a5..9694b27a79e 100644 --- a/src/vnet/tls/tls.c +++ b/src/vnet/tls/tls.c @@ -595,12 +595,13 @@ tls_session_connected_cb (u32 tls_app_index, u32 ho_ctx_index, u32 ctx_handle; ho_ctx = tls_ctx_half_open_get (ho_ctx_index); - ho_ctx->flags |= TLS_CONN_F_HO_DONE; ctx_handle = tls_ctx_alloc (ho_ctx->tls_ctx_engine); ctx = tls_ctx_get (ctx_handle); clib_memcpy_fast (ctx, ho_ctx, sizeof (*ctx)); + /* Half-open freed on tcp half-open cleanup notification */ + __atomic_fetch_or (&ho_ctx->flags, TLS_CONN_F_HO_DONE, __ATOMIC_RELEASE); ctx->c_thread_index = vlib_get_thread_index (); ctx->tls_ctx_handle = ctx_handle; |