diff options
| author |   Andrew Yourtchenko <ayourtch@gmail.com> | 2022-04-15 14:23:41 +0000 |
|---|---|---|
| committer | Andrew Yourtchenko <ayourtch@gmail.com> | 2022-04-15 15:46:57 +0000 |
| commit | 105cb1e4cfed2f7a92946fe7e9efc442e0183714 (patch) | |
| tree | d4877e6e5fd0787784cef68053d1013b0fb40468 | |
| parent | 8b153de6cdd8d87ae38447487565b346e735dc86 (diff) | |
api: fix infinite loop in show api dump CLI
The following illustrates the problem:
./build-root/install-vpp_debug-native/vpp/bin/vpp api-trace { on } unix { cli-listen /tmp/vpp-api-cli.sock } plugins { plugin dpdk_plugin.so { disable } }
sleep 5
./build-root/install-vpp_debug-native/vpp/bin/vppctl -s /tmp/vpp-api-cli.sock show version
./build-root/install-vpp_debug-native/vpp/bin/vppctl -s /tmp/vpp-api-cli.sock show api dump file /tmp/api-table.master-api-baseline compare
The last CLI hangs in an infinite loop.
Fix the typo which got in during the conversion of _vec_len to read-only:
.@@ -1285,7 +1285,7 @@ extract_name (u8 * s)
. rv = vec_dup (s);
.
. while (vec_len (rv) && rv[vec_len (rv)] != '_')
.- _vec_len (rv)--;
.+ vec_dec_len (rv, 0);
.
Type: fix
Fixes: 8bea589cfe0fca1a6f560e16ca66a4cf199041a2
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: I4f895348ae0ebaaba9da97c3a440912d38210f10
| -rw-r--r-- | src/vlibmemory/vlib_api_cli.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vlibmemory/vlib_api_cli.c b/src/vlibmemory/vlib_api_cli.c index bdbedec009b..39e22507c1b 100644 --- a/src/vlibmemory/vlib_api_cli.c +++ b/src/vlibmemory/vlib_api_cli.c @@ -1285,7 +1285,7 @@ extract_name (u8 * s) rv = vec_dup (s); while (vec_len (rv) && rv[vec_len (rv)] != '_') - vec_dec_len (rv, 0); + vec_dec_len (rv, 1); rv[vec_len (rv)] = 0; |