diff options
| author |   Dave Barach <dave@barachs.net> | 2020-06-16 08:40:53 -0400 |
|---|---|---|
| committer |   Andrew Yourtchenko <ayourtch@gmail.com> | 2020-08-18 19:47:21 +0000 |
| commit | 3180fe56516829e1a7458d25ae2545ad07d0daca (patch) | |
| tree | bc2efaab4bf14bc8072b7e8173ba5f7a4c5d2b8a | |
| parent | 6ed81620909387c7a55dbe03b152a75fdc219a64 (diff) | |
misc: fix sonarclound warnings
Type: fix
Ticket: VPP-1888
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9c2fb926a5e010658088a74051c8c3462ff61734
(cherry picked from commit 1af730d0dfbb91475c6808ed579494d3d223b724)
| -rw-r--r-- | src/plugins/acl/acl_test.c | 5 | ||||
| -rw-r--r-- | src/plugins/dns/dns_test.c | 6 | ||||
| -rw-r--r-- | src/plugins/http_static/static_server.c | 2 |
3 files changed, 11 insertions, 2 deletions
diff --git a/src/plugins/acl/acl_test.c b/src/plugins/acl/acl_test.c index ec951ad7057..d6a6d582702 100644 --- a/src/plugins/acl/acl_test.c +++ b/src/plugins/acl/acl_test.c @@ -669,10 +669,13 @@ api_acl_add_replace_from_file (vat_main_t * vam) break; } + if (file_name == NULL) + goto done; + fd = open(file_name, O_RDONLY); if (fd < 0) { - clib_warning("Could not open file '%s'"); + clib_warning("Could not open file '%s'", file_name); goto done; } diff --git a/src/plugins/dns/dns_test.c b/src/plugins/dns/dns_test.c index 6b0b371dca1..ada9c0b7aa1 100644 --- a/src/plugins/dns/dns_test.c +++ b/src/plugins/dns/dns_test.c @@ -186,6 +186,12 @@ api_dns_resolve_name (vat_main_t * vam) break; } + if (name == 0) + { + errmsg ("missing name to resolve"); + return -99; + } + if (vec_len (name) > 127) { errmsg ("name too long"); diff --git a/src/plugins/http_static/static_server.c b/src/plugins/http_static/static_server.c index ef9d3d77e41..73ea8895de3 100644 --- a/src/plugins/http_static/static_server.c +++ b/src/plugins/http_static/static_server.c @@ -933,7 +933,7 @@ state_sent_ok (session_t * s, http_session_t * hs, /* What kind of dog food are we serving? */ suffix = (char *) (hs->path + vec_len (hs->path) - 1); - while (*suffix != '.') + while ((u8 *) suffix >= hs->path && *suffix != '.') suffix--; suffix++; http_type = "text/html"; |