summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Barach <dave@barachs.net>2016-11-07 09:55:55 -0500
committerDamjan Marion <dmarion.lists@gmail.com>2016-11-07 15:47:53 +0000
commitd4048a46bbd15ba95cd62ea29c18cf6e7ddccb20 (patch)
tree9689f38266cfc2c1b1dcd31da9d75b404ca54109
parente74c1dc577edf19d485e8a37977b06f502cc76bd (diff)
Fix a class of spurious clib_memcpy (...) warnings, VPP-486
Coverity doesn't understand the vector-unit memcpy functions. #ifdef them out of the way when running a coverity scan. Change-Id: I312eec1c861c1d3722510d2c121fb5f398fca868 Signed-off-by: Dave Barach <dave@barachs.net>
-rw-r--r--vppinfra/vppinfra/string.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/vppinfra/vppinfra/string.h b/vppinfra/vppinfra/string.h
index dda27b7961b..69a99a3f0ce 100644
--- a/vppinfra/vppinfra/string.h
+++ b/vppinfra/vppinfra/string.h
@@ -56,6 +56,11 @@
/* Exchanges source and destination. */
void clib_memswap (void *_a, void *_b, uword bytes);
+/*
+ * the vector unit memcpy variants confuse coverity
+ * so don't let it anywhere near them.
+ */
+#ifndef __COVERITY__
#if __AVX__
#include <vppinfra/memcpy_avx.h>
#elif __SSSE3__
@@ -63,6 +68,9 @@ void clib_memswap (void *_a, void *_b, uword bytes);
#else
#define clib_memcpy(a,b,c) memcpy(a,b,c)
#endif
+#else /* __COVERITY__ */
+#define clib_memcpy(a,b,c) memcpy(a,b,c)
+#endif
#endif /* included_clib_string_h */