summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenoît Ganne <bganne@cisco.com>2019-04-26 11:09:49 +0200
committerDave Barach <openvpp@barachs.net>2019-04-30 16:54:08 +0000
commitc6eb5bc967d3d70016b4e4e182b3d68b1e558f60 (patch)
treea8b7e58956d6df963dcbbe2771131ca6bb109c59
parenta878014c6e0c9d9d5677fe9feeb8a9effb894e3d (diff)
elf: fix memcmp() overflow
name can be (and will be) smaller than section_name_start. Both name and section_name_start are NULL-terminated so we can use strcmp. Change-Id: Iec414810109f9267de20c25c0fe601df35daf89e Signed-off-by: Benoît Ganne <bganne@cisco.com>
-rw-r--r--src/vppinfra/elf_clib.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vppinfra/elf_clib.c b/src/vppinfra/elf_clib.c
index 7bb72ee3e3f..2bc05e1d8d4 100644
--- a/src/vppinfra/elf_clib.c
+++ b/src/vppinfra/elf_clib.c
@@ -153,7 +153,7 @@ clib_elf_parse_file (clib_elf_main_t * cem,
clib_elf_section_bounds_t *b;
/* Section name must begin with CLIB_ELF_SECTION key. */
- if (memcmp (name, section_name_start, section_name_start_len))
+ if (strcmp ((char *) name, section_name_start))
continue;
name += section_name_start_len;